Re: [win-pv-devel] [PATCH 9/9] Remove logging from failed Pdo Pnp IRPs

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Owen Smith
> Sent: 22 April 2016 15:16
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith
> Subject: [win-pv-devel] [PATCH 9/9] Remove logging from failed Pdo Pnp
> IRPs
> 
> Logging fail codes for unhandled Pnp IRPs is unneccesary and adds
> significant noise with multiple VBDs. Its unlikely the return value
> from storport is going to add significant insight to diagnose
> problems.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenvbd/pdo.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/src/xenvbd/pdo.c b/src/xenvbd/pdo.c
> index 918b824..8a2cbe4 100644
> --- a/src/xenvbd/pdo.c
> +++ b/src/xenvbd/pdo.c
> @@ -2366,7 +2366,6 @@ PdoDispatchPnp(
>      PIO_STACK_LOCATION  Stack = IoGetCurrentIrpStackLocation(Irp);
>      UCHAR               Minor = Stack->MinorFunction;
>      ULONG               TargetId = PdoGetTargetId(Pdo);
> -    NTSTATUS            Status;
> 
>      __PdoCheckEjectPending(Pdo);
> 
> @@ -2418,11 +2417,7 @@ PdoDispatchPnp(
>          break;
>      }
>      PdoDereference(Pdo);
> -    Status = DriverDispatchPnp(DeviceObject, Irp);
> -    if (!NT_SUCCESS(Status)) {
> -        Verbose("Target[%d] : %02x:%s -> %08x\n", TargetId, Minor,
> PnpMinorFunctionName(Minor), Status);
> -    }
> -    return Status;
> +    return DriverDispatchPnp(DeviceObject, Irp);
>  }
> 
>  __drv_maxIRQL(DISPATCH_LEVEL)
> --
> 1.9.4.msysgit.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel