Re: [win-pv-devel] [PATCH] Check Mdl, not Controller->Mdl for allocation failure

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Ben Chalmers
> Sent: 20 April 2018 14:49
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Ben Chalmers <ben.chalmers@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Check Mdl, not Controller->Mdl for
> allocation failure
> 
> Ensure we fall through error handlers, rather than BSOD
> 
> Signed-Off-By:  Ben Chalmers <ben.chalmers@xxxxxxxxxx>

Acked-By: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenvif/controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xenvif/controller.c b/src/xenvif/controller.c
> index 004bccb..4c019d0 100644
> --- a/src/xenvif/controller.c
> +++ b/src/xenvif/controller.c
> @@ -901,7 +901,7 @@ ControllerSetHashKey(
>      Mdl = __AllocatePage();
> 
>      status = STATUS_NO_MEMORY;
> -    if (Controller->Mdl == NULL)
> +    if (Mdl == NULL)
>          goto fail1;
> 
>      ASSERT(Mdl->MdlFlags & MDL_MAPPED_TO_SYSTEM_VA);
> --
> 2.10.1.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel