Re: [win-pv-devel] [PATCH] Add a user mode library wrapper for XENIFACE IOCTLs

['Marek Marczykowski-Górecki' <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Jul 11, 2018 at 07:51:02AM +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: 'Marek Marczykowski-Górecki'
> > [mailto:marmarek@xxxxxxxxxxxxxxxxxxxxxx]
> > Sent: 10 July 2018 21:01
> > To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> > Cc: win-pv-devel@xxxxxxxxxxxxxxxxxxxx; Rafal Wojdyla
> > <omeg@xxxxxxxxxxxxxxxxxxxxxx>
> > Subject: Re: [win-pv-devel] [PATCH] Add a user mode library wrapper for
> > XENIFACE IOCTLs
> > 
> > On Tue, Jul 10, 2018 at 07:46:13PM +0000, Paul Durrant wrote:
> > > > -----Original Message-----
> > > > From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx]
> > On
> > > > Behalf Of Marek Marczykowski-Górecki
> > > > Sent: 09 July 2018 11:22
> > > > To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > > > Cc: Rafal Wojdyla <omeg@xxxxxxxxxxxxxxxxxxxxxx>; Marek Marczykowski-
> > > > Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > > > Subject: [win-pv-devel] [PATCH] Add a user mode library wrapper for
> > > > XENIFACE IOCTLs
> > > >
> > > > From: Rafal Wojdyla <omeg@xxxxxxxxxxxxxxxxxxxxxx>
> > > >
> > > > Signed-off-by: Rafal Wojdyla <omeg@xxxxxxxxxxxxxxxxxxxxxx>
> > > > [fix compile warnings, update visual studio files]
> > > > Signed-off-by: Marek Marczykowski-Górecki
> > > > <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > > > ---
> > > > This was posted before here:
> > > > https://lists.xenproject.org/archives/html/win-pv-devel/2015-
> > > > 11/msg00014.html
> > > >
> > > > Back then I've raised a concern about code duplication caused by a
> > > > different API than libxc (having libxenvchan in mind). But two years
> > > > latter it looks like it isn't such a problem. libxenchan is the only
> > > > piece being effectively duplicated (at least in Qubes OS), and
> > > > everything else is really different anyway because of Linux/Windows
> > > > differences. So, I think it isn't an issue.
> > > >
> > > > Also I've renamed XcEvtchnBindUnbound to XcEvtchnOpenUnbound, as
> > > > requested in review back then.
> > > >
> > > > This has been tested with vs2017/WDK10 build for Windows 7 64bit, both
> > > > on Windows 7 and Windows 10. The patch assume "Add Windows 7 build
> > > > target" patches applied, but it should be easy to apply without them
> > > > too.
> > > > I've updated vs2015 files too, but don't have tools to test them (it
> > > > isn't possible to download free vs2015 anymore).
> > >
> > > Marek,
> > >
> > > I seem to be having tremendous difficulty in persuading vs2017 to build
> > this. No useful error message that I can find... just:
> > >
> > > DriverBuildNotifications:
> > >   Building 'xencontrol' with toolset 'WindowsApplicationForDrivers10.0' 
> > > and
> > the 'Desktop' target platform.
> > > InitializeBuildStatus:
> > >   Touching "Windows8Debug\xencontrol.tlog\unsuccessfulbuild".
> > > ClCompile:
> > >   C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\Community\VC\Tools\MSVC\14.14.26428\bin\HostX86\x86\CL.
> > exe /c /IC:\git\xeniface\vs2017\..\include /IWindows8Debug\ /Zi /nologo
> > /Wall /WX /diagnostics:classic /MP /Od /Oy- /D CODE_ANALYSIS /D __i386__
> > /D WIN32 /D _WINDOWS /D _USRDLL /D XENCONTROL_EXPORTS /D
> > _X86_=1 /D i386=1 /D STD_CALL /D WIN32_LEAN_AND_MEAN=1 /D
> > _WIN32_WINNT=0x0602 /D WINVER=0x0602 /D WINNT=1 /D
> > NTDDI_VERSION=0x06020000 /D DBG=1 /D _WINDLL /D _UNICODE /D
> > UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t- /Zc:forScope
> > /Zc:inline /Fo"Windows8Debug\\" /Fd"Windows8Debug\vc141.pdb" /Gz /TC
> > /wd4127 /wd4711 /wd4548 /wd4820 /wd4668 /wd4255 /wd6001 /wd6054
> > /wd28196 /FI"C:\Program Files (x86)\Windows
> > Kits\10\Include\10.0.17134.0\shared\warning.h" /analyze /analyze:quiet
> > /analyze:plugin"C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\Community\VC\Tools\MSVC\14.14.26428\bin\HostX86\x86\Esp
> > XEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\Community\VC\Tools\MSVC\14.14.26428\bin\HostX86\x86\loca
> > lespc.dll" /analyze:plugin"C:\Program Files (x86)\Windows
> > Kits\10\bin\10.0.17134.0\x86\WindowsPrefast.dll"
> > /analyze:plugin"C:\Program Files (x86)\Windows
> > Kits\10\bin\10.0.17134.0\x86\drivers.dll" /FC /errorReport:queue
> > /analyze:ruleset"C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\Community\Team Tools\Static Analysis Tools\Rule
> > Sets\NativeRecommendedRules.ruleset" ..\..\src\xencontrol\xencontrol.c
> > >   xencontrol.c
> > > c:\git\xeniface\src\xencontrol\xencontrol.c(924): error C2220: warning
> > treated as error - no 'object' file generated
> > [C:\git\xeniface\vs2017\xencontrol\xencontrol.vcxproj]
> > > c1 : fatal error C1258: Failed to save XML Log file
> > 'c:\git\xeniface\vs2017\xencontrol\windows8debug\xencontrol.nativecodea
> > nalysis.xml'. The system cannot find the path specified.
> > [C:\git\xeniface\vs2017\xencontrol\xencontrol.vcxproj]
> > 
> > Missing "vs2017\xencontrol\windows8debug" directory?
> > 
> > > Done Building Project
> > "C:\git\xeniface\vs2017\xencontrol\xencontrol.vcxproj" (default targets) --
> > FAILED.
> > > Done Building Project "C:\git\xeniface\vs2017\xeniface.sln" (Build
> > target(s)) -- FAILED.
> > >
> > > Build FAILED.
> > >
> > > I'm not convinced the patch applied correctly as exchange seemed to do its
> > best to mangle the line endings and introduce line wrap in stupid places. Do
> > you happen to have the code on a git branch I can get to, so I can grab it
> > directly?
> > 
> > Sure, it's here:
> > https://github.com/QubesOS/qubes-vmm-xen-win-pvdrivers-xeniface
> > upstream-xencontrol
> >
> 
> Thanks. I'm having exactly the same issue having pulled the branch, so I 
> guess it has to be my toolchain. I updated to the very latest vs2017 and WDK 
> 10 1803 yesterday. I'll retry with vs2015 for comparison.

Oh, I know - I forgot to add xencontrol project to package project
dependencies (in sln file). I've force-pushed fixed version to the above
branch.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel