[win-pv-devel] [PATCH xenvbd] Remove bogus ASSERTion

[Paul Durrant <paul.durrant@xxxxxxxxxx>]

In a checked build the code in BlkifRingSchedule() sometimes hits the
ASSERTion:

ASSERT3U(State->Count, ==, 0);

This check is there because this code was ported across from XENVIF. In
the context of that driver the check is valid because it should never be
possible to post a partial sequence of netif requests (since that would
violate the protocol). However, in the context of XENVBD posting blkif
requests, it is perfectly reasonable for a subset of blkif requests for
a single SRB to be posted, and hence __BlkifRingPostRequests() may exit
before State->Count falls to zero. Thus the ASSERTion is invalid in this
context and needs to be removed.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xenvbd/ring.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/xenvbd/ring.c b/src/xenvbd/ring.c
index 2f5c876..d595226 100644
--- a/src/xenvbd/ring.c
+++ b/src/xenvbd/ring.c
@@ -1419,8 +1419,6 @@ BlkifRingSchedule(
             RING_SIZE(&BlkifRing->Front) / 4)
             __BlkifRingPushRequests(BlkifRing);
 
-        ASSERT3U(State->Count, == , 0);
-
         if (IsListEmpty(&BlkifRing->SrbQueue))
             break;
 
-- 
2.5.3


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel