Re: [win-pv-devel] [PATCH 3/4] Avoid assertion failure on PdoDestroy

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Owen Smith
> Sent: 05 November 2018 16:30
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH 3/4] Avoid assertion failure on PdoDestroy
> 
> Avoid triggering ASSERT(IsZeroMemory(Pdo, sizeof(XENCONS_PDO))
> by NULL-ing Pdo->Context.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xencons/pdo.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/xencons/pdo.c b/src/xencons/pdo.c
> index 3b483a5..b7177a9 100644
> --- a/src/xencons/pdo.c
> +++ b/src/xencons/pdo.c
> @@ -2002,6 +2002,7 @@ fail6:
>      else
>          FrontendDestroy(Pdo->Context);
> 
> +    Pdo->Context = NULL;
>      Pdo->IsDefault = FALSE;
> 
>  fail5:
> @@ -2077,6 +2078,7 @@ PdoDestroy(
>      else
>          FrontendDestroy(Pdo->Context);
> 
> +    Pdo->Context = NULL;
>      Pdo->IsDefault = FALSE;
> 
>      RtlFreeUnicodeString(&Pdo->Dx->Link);
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel