Re: [win-pv-devel] [PATCH] Fix parameter ordering

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On 
> Behalf Of Owen Smith
> Sent: 27 March 2019 15:12
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Fix parameter ordering
> 
> When the Order parameter was added to the MemoryPopulatePhysmap and
> MemoryDecreaseReservation calls, the callers were transposing the Order
> and Requested parameters.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Mea culpa

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenbus/balloon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xenbus/balloon.c b/src/xenbus/balloon.c
> index 2f1284e..202733c 100644
> --- a/src/xenbus/balloon.c
> +++ b/src/xenbus/balloon.c
> @@ -350,7 +350,7 @@ BalloonPopulatePhysmap(
> 
>      KeQuerySystemTime(&Start);
> 
> -    Count = MemoryPopulatePhysmap(Requested, PAGE_ORDER_4K, PfnArray);
> +    Count = MemoryPopulatePhysmap(PAGE_ORDER_4K, Requested, PfnArray);
> 
>      KeQuerySystemTime(&End);
>      TimeDelta = __max(((End.QuadPart - Start.QuadPart) / 10000ull), 1);
> @@ -437,7 +437,7 @@ BalloonDecreaseReservation(
> 
>      KeQuerySystemTime(&Start);
> 
> -    Count = MemoryDecreaseReservation(Requested, PAGE_ORDER_4K, PfnArray);
> +    Count = MemoryDecreaseReservation(PAGE_ORDER_4K, Requested, PfnArray);
> 
>      KeQuerySystemTime(&End);
>      TimeDelta = __max(((End.QuadPart - Start.QuadPart) / 10000ull), 1);
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel