Re: [win-pv-devel] [PATCH] Report version details to XenStore

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On 
> Behalf Of Owen Smith
> Sent: 03 June 2019 11:35
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Report version details to XenStore
> 
> Requires adding the XENBUS_STORE and XENBUS_SUSPEND interface to add the
> version details, and deal with re-adding after a suspend/resume.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
>  include/revision.h           |  11 +-
>  include/store_interface.h    | 348 +++++++++++++++++++++++++++++
>  include/suspend_interface.h  | 177 +++++++++++++++
>  src/coinst/coinst.c          |   2 +-
>  src/xenhid.inf               |   6 +-
>  src/xenhid/fdo.c             | 510 
> +++++++++++++++++++++++++++++++++++++++++--
>  src/xenhid/string.c          | 467 +++++++++++++++++++++++++++++++++++++++
>  src/xenhid/string.h          |  51 +++++
>  vs2015/xenhid/xenhid.vcxproj |   1 +
>  vs2017/xenhid/xenhid.vcxproj |   1 +
>  10 files changed, 1547 insertions(+), 27 deletions(-)
>  create mode 100644 include/store_interface.h
>  create mode 100644 include/suspend_interface.h
>  create mode 100644 src/xenhid/string.c
>  create mode 100644 src/xenhid/string.h
> 
> diff --git a/include/revision.h b/include/revision.h
> index b30aee7..d81a16a 100644
> --- a/include/revision.h
> +++ b/include/revision.h
> @@ -34,12 +34,13 @@
> 
>  // Key:
>  // H  - XENHID_HID_INTERFACE
> +// ST - XENBUS_STORE_INTERFACE
> +// SU - XENBUS_SUSPEND_INTERFACE
> 
>  //                    REVISION   H
> -#define DEFINE_REVISION_TABLE           \
> -    DEFINE_REVISION(0x0800000B,  1),    \
> -    DEFINE_REVISION(0x0800000C,  1),    \
> -    DEFINE_REVISION(0x0800000D,  1),    \
> -    DEFINE_REVISION(0x09000000,  1)
> +#define DEFINE_REVISION_TABLE               \

Don't you want "H ST SU" or somesuch here? Otherwise we won't know what number 
refers to which interface without further digging.

With that fixed...

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> +    DEFINE_REVISION(0x09000000,  1, 0, 0),  \
> +    DEFINE_REVISION(0x09000001,  1, 1, 1),  \
> +    DEFINE_REVISION(0x09000002,  1, 2, 1)
> 
>  #endif  // _REVISION_H
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel