Re: [win-pv-devel] [PATCH 1/3] Update rsp_event during Poll

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Owen Smith
> Sent: 03 September 2019 15:43
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH 1/3] Update rsp_event during Poll
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

For posterity I think we need a justification for this change in the commit 
message. I think I understand things well enough to add one myself so...

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenvbd/ring.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/xenvbd/ring.c b/src/xenvbd/ring.c
> index 0dfba7f..74426f1 100644
> --- a/src/xenvbd/ring.c
> +++ b/src/xenvbd/ring.c
> @@ -1294,6 +1294,7 @@ BlkifRingPoll(
>          KeMemoryBarrier();
> 
>          BlkifRing->Front.rsp_cons = rsp_cons;
> +        BlkifRing->Shared->rsp_event = rsp_cons + 1;
>      }
> 
>  done:
> @@ -1327,8 +1328,6 @@ __BlkifRingPushRequests(
>  #pragma warning (push)
>  #pragma warning (disable:4244)
> 
> -    BlkifRing->Shared->rsp_event = BlkifRing->Front.req_prod_pvt;
> -
>      // Make the requests visible to the backend
>      RING_PUSH_REQUESTS_AND_CHECK_NOTIFY(&BlkifRing->Front, Notify);
> 
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel