Re: [win-pv-devel] [PATCH xeniface] Get rid of bogus time adjustment

[Owen Smith <owen.smith@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Paul Durrant
> Sent: 16 September 2019 14:27
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH xeniface] Get rid of bogus time adjustment
> 
> Xen maintains synchronization between the wallclock (as reported in the
> shared info) and the emulated RTC. Thus all the guest agent needs to know,
> to correctly interpret the wallclock, is whether Windows is setting the RTC in
> local time or UTC. No adjustment of the wallclock is required.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
>  src/xenagent/service.cpp | 25 -------------------------
>  1 file changed, 25 deletions(-)
> 
> diff --git a/src/xenagent/service.cpp b/src/xenagent/service.cpp index
> a77ff23..8f8f445 100644
> --- a/src/xenagent/service.cpp
> +++ b/src/xenagent/service.cpp
> @@ -404,28 +404,6 @@ bool CXenIfaceCreator::IsRTCInUTC()
>      return val;
>  }
> 
> -void CXenIfaceCreator::AdjustXenTimeToUTC(FILETIME* now) -{

AdjustXenTimeToUTC will also need the method taking out of service.h

> -    std::string vm;
> -    if (!m_device->StoreRead("vm", vm))
> -        return;
> -
> -    std::string offs;
> -    if (!m_device->StoreRead(vm + "/rtc/timeoffset", offs))
> -        return;
> -
> -    long offset = (long)atoi(offs.c_str());
> -
> -    ULARGE_INTEGER lnow;
> -    lnow.LowPart  = now->dwLowDateTime;
> -    lnow.HighPart = now->dwHighDateTime;
> -
> -    lnow.QuadPart -= ((LONGLONG)offset * 1000000);
> -
> -    now->dwLowDateTime  = lnow.LowPart;
> -    now->dwHighDateTime = lnow.HighPart;
> -}
> -
>  void CXenIfaceCreator::SetXenTime()
>  {
>      bool IsUTC = IsRTCInUTC();
> @@ -440,9 +418,6 @@ void CXenIfaceCreator::SetXenTime()
>      if (!m_device->SharedInfoGetTime(&now))
>          return;
> 
> -    if (IsUTC)
> -        AdjustXenTimeToUTC(&now);
> -
>      SYSTEMTIME sys = { 0 };
>      if (!FileTimeToSystemTime(&now, &sys))
>          return;
> --
> 2.5.3
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel