Re: [win-pv-devel] [PATCH v4 6/7] Add guide on Communication Best Practice

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 13/01/2020, 19:54, "George Dunlap" <George.Dunlap@xxxxxxxxxx> wrote:

    
    > On Dec 30, 2019, at 7:32 PM, Lars Kurth <lars.kurth@xxxxxxxxxxxxxx> wrote:
    > 
    > From: Lars Kurth <lars.kurth@xxxxxxxxxx>
    > 
    > This guide covers the bulk on Best Practice related to code review
    > It primarily focusses on code review interactions
    > It also covers how to deal with Misunderstandings and Cultural
    > Differences
    > 
    > +### Avoid opinion: stick to the facts
    
    In my talk on this subject I said “Avoid *inflammatory language*”.  At some 
level it’s good to have strong opinions on what code should look like.  It’s 
not opinions that are a problem, or even expressing opinions, but expressing 
them in a provocative or inflammatory way.

Let me look at this again: I don't feel strongly about it

I changed the title because I felt that the bulk of the 
example is actually about sticking to the facts an opinion 
and the inflammatory element was secondary. So it felt more
natural to me to change the title.

But then looking at the definition of inflammatory language,
aka  "an inflammatory question or an inflammatory statement
would be one which would somehow predispose the listeners
towards a subject in an unreasonable, prejudiced way."
It is clearly also true that the example is inflammatory.

I think I may have tripped over an area where there is no good
language match: the German translations of inflammatory
aufrührerisch & aufwieglerisch have an element of rebellion
and mischief to them (at least when I grew up).

I am wondering though, whether it is necessary to include 
a definition of an inflammatory question or an inflammatory
statement if we stick with it in the title

    > 
    > +> Foot binding was the custom of applying tight binding to the feet of 
young
    > +> girls to modify the shape and size of their feet. ... foot binding was 
a
    > +> painful practice and significantly limited the mobility of women, 
resulting
    > +> in lifelong disabilities for most of its subjects. ... Binding usually
    > +> started during the winter months since the feet were more likely to be 
numb,
    > +> and therefore the pain would not be as extreme. …The toes on each foot
    > +> were curled under, then pressed with great force downwards and squeezed
    > +> into the sole of the foot until the toes broke…
    
    In my talk I covered the last three words behind a blue square, since this 
image is pretty violent — and is gendered violence at that.  Some people joke 
about “triggering”, but there are certainly people who  have experienced 
violence, who when they come across descriptions of it unexpectedly suddenly 
have loads of unwelcome emotions to deal with; and I venture to guess that most 
people skimming through such a guide wouldn’t be expecting to come across 
something like this.
    
    Personally I would replace the last three words with [redacted].  The point 
can be made without being so explicit.  Anyone who wants to know what happens 
can go look up the entry themselves.

OK. I can do that. 
I copied the text from the content outline on slide share and wasn't even 
looking at the slides themselves
    
Lars
    
    

_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel