Re: [win-pv-devel] [PATCH] Increase FrontendPath length for long DeviceIds

["Durrant, Paul" <pdurrant@xxxxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf
> Of Owen Smith
> Sent: 15 January 2020 12:51
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Increase FrontendPath length for long
> DeviceIds
> 
> The DeviceIds maximum value is 1 << 28 | 0xfffff << 8 | 0xff, which is a
> 9 digit decimal numver. Values higher than this are invalid. Ensure the
> FrontendPath buffer is large enough to contain valid DeviceId values.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul@xxxxxxx>

> ---
>  src/xenvbd/frontend.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xenvbd/frontend.c b/src/xenvbd/frontend.c
> index 3fa19a0..d74f0b3 100644
> --- a/src/xenvbd/frontend.c
> +++ b/src/xenvbd/frontend.c
> @@ -62,7 +62,7 @@ struct _XENVBD_FRONTEND {
>      PXENVBD_TARGET              Target;
>      ULONG                       TargetId;
>      ULONG                       DeviceId;
> -    CHAR
> FrontendPath[sizeof("device/vbd/XXXXXXXX")];
> +    CHAR
> FrontendPath[sizeof("device/vbd/XXXXXXXXX")];
>      PCHAR                       BackendPath;
>      CHAR
> TargetPath[sizeof("data/scsi/target/XXXX")];
>      USHORT                      BackendDomain;
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel