RE: [PATCH] Dont mix Exclusive and Shared locking calls

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> owen.smith@xxxxxxxxxx
> Sent: 04 August 2020 15:49
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [PATCH] Dont mix Exclusive and Shared locking calls
> 
> From: Owen Smith <owen.smith@xxxxxxxxxx>
> 
> If the lock is acquired with ExAcquireSpinLockSharedAtDpcLevel(), it
> should always be released with ExReleaseSpinLockSharedFromDpcLevel()
> (unless the lock is converted to an exclusive lock)
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul@xxxxxxx>

> ---
>  src/xenvif/mac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xenvif/mac.c b/src/xenvif/mac.c
> index 3301ef9..a89904b 100644
> --- a/src/xenvif/mac.c
> +++ b/src/xenvif/mac.c
> @@ -394,7 +394,7 @@ fail2:
>  fail1:
>      Error("fail1 (%08x)\n", status);
> 
> -    __MacReleaseLockExclusive(Mac);
> +    __MacReleaseLockShared(Mac);
>      KeLowerIrql(Irql);
> 
>      return status;
> @@ -974,7 +974,7 @@ MacQueryMulticastAddresses(
>  fail1:
>      *Count = Mac->MulticastCount;
> 
> -    __MacReleaseLockExclusive(Mac);
> +    __MacReleaseLockShared(Mac);
>      KeLowerIrql(Irql);
> 
>      return status;
> --
> 2.16.2.windows.1
>