[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/2] Allow user to specify desired build architecture
- To: Nicholas Tsirakis <niko.tsirakis@xxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Mon, 9 Nov 2020 08:07:52 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXNtx4HZIH1s/GlQQJyv45y1wFzMdYuhdlSQbNvHw2Q=; b=BizfD2DI8+ufOvelwk+ufMxiUEfTduq6Lc6m70FUbI6Z46lfkxoPWL/IZNP+SH0t40E2HD4ID/UDDPFd9W4+MZwDj3uUrDrgJzmnxIbYNCg5H+YrIxVFNHzRvKXB1T5t3ant+HI1BWMHTT/DodelqIrU4sm7mJ+feidXsLfUXejCTLU2/nsU4G1oBbUpCkIMbl7MYMb1refyQseO0muVHsO5pbDbrImqJumPyN9OTulQ1ye/BHaJlbgjOF4auAwTquZ8Nno38cNnLwrymlUOmYbxncdT6T22YFgiXnpdNgn6+OVsHla24xVIrAcH74UtnJ7zBaqo2ppIDVQiXDstxg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tg0D3Eqku2A2vh+iApATRBtE5sVrEmJalTbbOvNCU9f5+74sL9e5wbc/d7z0Z2ZbFCY61jNTuO+BPpgoyT8S8ZS71scJgwBksUnxC7EtcLIVtgfcMfGL8txvaX9ghQ46IKXtX4kf+Dnk45mwzJRL7RJhkOMk+wUNZ+Vp9tJOuv9XEGkaBWS5OUflxJKtsU+WHSu5xze1YgTlN+slJFkPcTUCgNQtjjOIMxMwj4jxh2qR3o88rvzwc7vGds2PgSDp5wfcYHRCS6lbpp73OuMIrwwSZkHUiyb86wqXrWeB+TgLgJSf3zD4n8+24R7QbnuZMArIyikEuIKghkPh9E7KJw==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "paul@xxxxxxx" <paul@xxxxxxx>, Ben Chalmers <ben.chalmers@xxxxxxxxxx>, Nicholas Tsirakis <tsirakisn@xxxxxxxxxxxx>
- Delivery-date: Mon, 09 Nov 2020 08:08:03 +0000
- Ironport-sdr: 3i5+QI52im9pG3m0N7VRDxdfK1TFvO0lqxmPdmcRqOxxVDQ2Q42OAVVr7lVJdKNVhBc+UONqQ1 ZncVukkDMA3iNMs4UK38niRI7bgGejJ3HV/NF5p5r5LrKdw48W78CQ4pC/4XK9zqiy+8brA3Ls dlpZ4lj2AzhJgv92QOil1ZUobBr6Q0LQo7Z6lXxRhkTn3xxGGy99ejKuWFw9mzmUbXqZ4cJGST erJpo+RI0HN5XLtvnDOwEMkAjaTZJ4zFP+6Ku6DBuFzSkiwoTMWsCEOIgLz+LgKSU63RGaS51n +Tg=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHWtH5BJf25pae+0UWo81C4mchDeam/dNoQ
- Thread-topic: [PATCH 1/2] Allow user to specify desired build architecture
I would suggest using
[string]::IsNullOrEmpty($Arch)
Instead of
$Arch -eq ""
Owen
> -----Original Message-----
> From: Nicholas Tsirakis <niko.tsirakis@xxxxxxxxx>
> Sent: 06 November 2020 20:49
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: paul@xxxxxxx; Ben Chalmers <ben.chalmers@xxxxxxxxxx>; Owen Smith
> <owen.smith@xxxxxxxxxx>; Nicholas Tsirakis <tsirakisn@xxxxxxxxxxxx>
> Subject: [PATCH 1/2] Allow user to specify desired build architecture
>
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> Often times we only need to build a driver for a single targeted architecture.
> Continue to build both by default, but allow the user to specify one if
> desired.
>
> Signed-off-by: Nicholas Tsirakis <tsirakisn@xxxxxxxxxxxx>
> ---
> build.ps1 | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/build.ps1 b/build.ps1
> index c66ac05..06626fd 100644
> --- a/build.ps1
> +++ b/build.ps1
> @@ -5,6 +5,7 @@
> param(
> [Parameter(Mandatory = $true)]
> [string]$Type,
> + [string]$Arch,
> [switch]$Sdv
> )
>
> @@ -82,8 +83,13 @@ Set-Item -Path Env:MAJOR_VERSION -Value '9'
> Set-Item -Path Env:MINOR_VERSION -Value '1'
> Set-Item -Path Env:MICRO_VERSION -Value '0'
>
> -Build "x86" $Type
> -Build "x64" $Type
> +if ($Arch -eq "" -or $Arch -eq "x86" -or $Arch -eq "Win32") {
> + Build "x86" $Type
> +}
> +
> +if ($Arch -eq "" -or $Arch -eq "x64") {
> + Build "x64" $Type
> +}
>
> if ($Sdv) {
> SdvBuild
> --
> 2.25.4
>
|
