[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Add log to Xenfilt DriverAddDevice
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Martin Harvey <martin.harvey@xxxxxxxxxx>
- Date: Tue, 13 Jul 2021 08:25:47 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Z3ehxAg8/Va5uCBkwHVEaxkKhsmQNDeQkqDiCp4b8g=; b=bytBKxPB+gqB+OHB+G21H7ypHIZhoJ3G1ookgm0z3d0wBOCez+z0gqqrsJfQjZlmzd5WpcaE+6VwYOYfrk7ZHm52Nk96ZWZTvQqJaZYQ1SC4ZXoZ3bn1ozHPg99VRD776xbSI+A5BfaXh+woZutYycP/Q9MudBpZykd1ZQHCh1qmrx0c5VBofEBCmAnCLzdNp9KgND0w+wFmC8F6aoj3TejNJAMNEwrUuO++JXBrAz5EH6tKQzL/o+VhBTfrZQjK/gXkQ9W3rhevnv6KQkUTM6v0DwVnVDQElqK7pRzynUai0fFfVw19x8jxqI+l32k6kgV8Xdk1jIi60klnCpplhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EeBNBCJGiyiWmzZubc+dt47EtRYKDT5O0MJl2LzzV95MDfeXslQG5BlKrLnTQbocEzKiT/41fIQXdElVVCZo/u7Umt2NiBJGVAUC1rey/rvF0BSVcEVMBAfMmT3zbRLYQ/l7EcP57teiuEDXUxsP9+JQ1jxikJIPLMFe30nXotcMC+2tKjgh0OdhS0bfOvUZdb4JmVUfnSkPqj/lIFWS0/HvrgrnW5DaOE5qS6plqMqSC37fBbuctilM52ajSBJk0NdA+FDzfyeIa6UakjkdEvEqH+zgD/wvZ5T28robFYB2zo+iPxnsY+OA7Zxnk6g1VZ82jS/KRZaottFZ1CNdRA==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Tue, 13 Jul 2021 08:25:55 +0000
- Ironport-hdrordr: A9a23:ml26UaDs7qvpyP7lHeg5sceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPEfP+UsssQIb6Ky90c67MDzhHP9OkMUs1NKZPTUO11HYVb2KgbGSoQEIXheOjNK1tp 0QPZSWaueAdWSS5PySiGLTfrZQo+VvsprY/ts2p00dFT2CAJsQizuRfzzrdHGeMzM2YqbReq Dsg/Zvln6FQzA6f867Dn4KU6zovNvQjq/rZhYAGloO9BSOpSnA0s+6LzGomjMlFx9fy7Yr9m bI1ybj4L+4jv29whjAk0fO8pVtnsf7wNcrPr3NtiFVEESutu+bXvUlZ1SwhkFwnAhp0idsrD D4mWZjAy200QKWQoj6m2q15+Cq6kdQ15ar8y7nvZKkm72jeNtyMbsxuatJNhTe8EYup9d6ze ZC2H+YrYNeCVfakD36/MWgbWAjqqOYmwtVrQcotQ0XbWLeUs4lkaUPuEdOVJsQFiPz744qVO FoEcHH/f5TNVeXdWrQsGVjyMGlGi1bJGbNfmES/siOlzRGlnFwyEUVgMQZg3cb7Zo4D51J/f 7NPKhknKxHCsUWcaV+DuEcRtbfMB2HffsNChPkHb3DLtBLB5vgke+F3FwF3pDfRHVT9upDpH 3oaiIriVIP
- Ironport-sdr: 1egGcXfEZ22MdCvAu2b5u1Stuyau5STfJ6m6NEwwNkkombvE4dF0k3Pl2ZoagA9Timbnz3Yiem BaxwLsCm5zaZa/cAn/Gqby7dp+0f72MN9sEajUQGja0HeY3UrxcO2dd3ePRkdhB//mXZSaWzNj PLL409s5nqRX41QSbA4x4mE0c5ZxcbO3lkcBT66XTisje4kNwk5QQ32ZMRZxUPiOaiHCJQ4pCW nVBZRBH9vBq+E9E+tbnh7BqhEEKAWJPLi5JzLaEu8dTO0hj3HPjK9C+Nh+jXAe8CeB01mSHFMu bn4=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXcw8lO0GbhNNyjkas71fAJtHqXKs/u8QAgADdFTA=
- Thread-topic: [PATCH] Add log to Xenfilt DriverAddDevice
Yes, we definitely need to log all filter AddDevice calls. Here's why:
Cut a long story short, the customer likes to do all the things to a VM which
they normally like to do to windows machines. This includes upgrading windows
editions via windows update on Win10, and also in some cases, mounting the ISO
for a newer windows server version, and upgrading the version of windows server.
These upgrade cases do some driver migration steps, which often (but not
always) work perfectly. Unfortunately, we've seen cases where class UpperFilter
registry keys go missing / don't work, such that XenFilt no longer binds to
ACPI/PNP0A03 (PCIBus if memory serves).
If XenFilt can't filter the appropriate devices, **Everything** breaks -
particularly, Plug/Unplug doesn't work right, and the machine continually
prompts for reboot. I can go back thru case reports and give more details if
required.
Tracking this down as the newbie back in early 2020 took **weeks**, where it
could have taken a day or so. That debug print would make debugging similar
cases very much easier, and it's a problem we're likely to run into again.
Please include the debug print for developers sanity.
MH.
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Paul Durrant
Sent: 12 July 2021 20:06
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] Add log to Xenfilt DriverAddDevice
> Log all calls to DriverAddDevice, and the type of the device if
> possible
Any particular reason existent logging is insufficient? I think we need more
justification here.
|
