[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Log module loading
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Martin Harvey <martin.harvey@xxxxxxxxxx>
- Date: Tue, 13 Jul 2021 08:39:07 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x8OuwpgkQgwL7qS3Nl+FPFUnymj6QsYs0vkAM6DZiCg=; b=iwY0A9VJ/32GGGJi5Irfr02pTP378KXIlMTNoMjj9NY5WGDGTZTVwYEN7qwKV40fcEyZ88ahTpEvZvhEue/jYYYW61oz4Fnc1eYFcWgBsLm7GfMFNXH94rVJS1tqOFXZCBoFBBJHgvFZjSgrOd1Qld9M7lgB7IlbWATrIeDiRqnv1rer6PGseKuyoma2v+jXIKjDLDLyp6c2i4zfyzWHdEqyMztKAcExdIlLvmJ6wR0V6ENHi9bMZvU0etIQfhMdjfiF1bHmGTON12EUMdam+CHJ6H2Kzz7YBW2ToIOuzBn+wgpLemsy/k4gNXMN6K/RZclKwStwFHJ7WhqyZ/p5OA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZA37plO2DpceCbBvsx4NM2TJUPPQ9k2oyCdx1Oy9HEmNu2CR/edjlto6w5PEWhz9RYJGEiECHjEEAH12xLuvYFai7YCzEqqgVONyf7i0gVe1FqtSe5rIKs8RZfWq9hYEyhNh2LOc5937lMbJ4Egw4FvJ9JUEkcy5Tlu4Kx/PeXW0RwqfUNVahJmS9N87S5oQFnf1524eTKPrBXjT3kWZsS+fXXnuh3J3J/3WDafe7dkVRcyTzgprPWTvWWGYzhwdHyEexgVuD1afNSmf7jPAW2OmVzJL1PzgqCMuqLuzLkf3FTT6r6t3t3pK3GmssLkJviyQ8lsWSsPoGiW7Vvm0A==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Tue, 13 Jul 2021 08:39:15 +0000
- Ironport-hdrordr: A9a23:x6/saaGVeTDEIXJfpLqFfZHXdLJyesId70hD6qkvc3Jom52j+P xGws526fatskdtZJhSo6H9BEDmewKSyXcV2/hcAV7GZmjbUQSTXfhfBOfZsl/d8mjFh5RgPM RbAuZD4b/LfCBHZK/BiWHSebtBsbq6GeKT9JzjJh9WPFlXgspbnmNE43OgYytLrX59dP0E/f Snl696jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelEMKgWXo/0cL5/aJHw7SQvAx9L5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa3nZcjEBS59L7tUYvGLf2qYUh2LA37QdQCtMNDSj64IcoHK 1nC9zd/u9fdRefY2rCtmdizdSwVjBrdy32CHQqq4iQyXxbjXp5x0wXyIgWmWoB7os0T91B6/ 7fOqplmblSRosdbL57Bu0GXcyrY1a9Ci4k8FjiVmgPMZt3dk4lh6SHk4nd1dvaDKDglqFC6K gpeGkox1IPRw==
- Ironport-sdr: X2+nQmJ1tH5mhV3oDPMmtzusDNMt8b11XfAjnw2J28jiRcq06Wdub6GVQH8UBLWYm8ForiGaGn jNUs4VlEPKjixCcneaA+XpEbx4EYZjKV9q0vDF3Fl68C/40PhmdnJRuZYa3JnOc576eURHhLCF 6SgySuRdALzUo0LJtr4i4WekZPIZ6aNQksVUmdgMM8SM5ovP15Hg3Nw/UT6CxtkAuHqCOawyNT 484kDeT2ucjXfNv45Xo/32I/PnFpYBZcQIo0EexNBj/jLZ746YiOBH1OzKg87/A0rZ3EIECzDL NeI=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXcw2/Knojojq7r0i0Tdd3ept0D6s/uiSAgADkXnA=
- Thread-topic: [PATCH] Log module loading
I note that very close to the debug print that was changed, we have
INSERT_BEFORE and INSERT_AFTER macros. The positioning and existence of them
there seems a bit crazy - double linked list handling seems to be a general
thing that should either be handled by nt!Rtl___, nt!Ex___, or put in a common
file.
MH.
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Paul Durrant
Sent: 12 July 2021 20:00
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] Log module loading
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
On 07/07/2021 09:54, Martin Harvey wrote:
> From: Paul Durrant <paul.durrant@xxxxxxxxxx>
>
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
> src/xen/module.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/xen/module.c b/src/xen/module.c index
> 584a63d..9c4a5ea 100644
> --- a/src/xen/module.c
> +++ b/src/xen/module.c
> @@ -145,6 +145,11 @@ ModuleAdd(
> BOOLEAN After;
> NTSTATUS status;
>
> + Info("%p - %p [%s]\n",
Not necessarily sure we want to log at this level in the general case. I think
it would be reasonable for this to be a debug log line.
Paul
> + Start,
> + Start + Size - 1,
> + Name);
> +
> New = __ModuleAllocate(sizeof (MODULE));
>
> status = STATUS_NO_MEMORY;
>
|
