[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Martin Harvey <martin.harvey@xxxxxxxxxx>
- Date: Wed, 14 Jul 2021 12:30:53 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eZAEMGHGPI1oPCx6I3d2+PvZ/4ui8AtjBDcrxpAiXbE=; b=UzqwYAEatsg0HziR1iMKcPb+zrD00CJNkjCpMVt02sZdDkQRNMH/CTfI1xRR0lFGVRJbH23ug9U5nuyHmvO9pZH6Xkdo6DPIbna2ZIB7Jm/iveYFhC6rvNM12StrzideNEVMh9rDcN+YwZ2P0sFbVX7doErdDV5Z/yo0v6xuWGWEu1zldzzMpxtAImxYqRg1dv7TPl+VMNv/IT3fj3cspED0f0uttOiPmVSSf45xM6JaLmmxqas1fJdNKdZf9CPu8SEIy8VsOqQN3uwYfyBsW1gV4PrWwY344wm+OIxFgiaYnUhsImoZ2YVeAD03Ibh/4cRd2Tcx04gDZu8ue+9SHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n2dtR6IOGfUbQboCc9BN0cx8/kaKDBm/xXfahtevRaVBDyN4PRJ707KbgJF1duub/5lcICeK+loI14FODJLlKFKbJZBG0DKzd96kZYNfpHm/pUAU2PB3AQyOC6/NSabkbw3eC2b6d3FuEgi9IOB7pZS+LBKCMOLA7taPrCbo8b/rwJZWG/4zIVRp+A+0MWuv40zSeS6Viq03UqBQLmgJ/4C3D1a8XMC4pQLkVz8FIKMn+75aA+2ZW1/XpMAc0BCceWm5YK2L1QQ8qsCt0HXmRQlmDgTjCtA4spJdj4LC80KNui0EeR+r27NcYIY9xoDGBxbToUvrD0E+xQBuoy8ztw==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Wed, 14 Jul 2021 12:31:02 +0000
- Ironport-hdrordr: A9a23:Ga7avqEO0KQYoYC8pLqFfZHXdLJyesId70hD6qkvc3Jom52j+P xGws526fatskdtZJhSo6H9BEDmewKSyXcV2/hcAV7GZmjbUQSTXfhfBOfZsl/d8mjFh5RgPM RbAuZD4b/LfCBHZK/BiWHSebtBsbq6GeKT9JzjJh9WPFlXgspbnmNE43OgYytLrX59dP0E/f Snl696jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelEMKgWXo/0cL5/aJHw7SQvAx9L5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa3nZcjEBS59L7tUYvGLf2qYUh2LA37QdQCtMNDSj64IcoHK 1nC9zd/u9fdRefY2rCtmdizdSwVjBrdy32CHQqq4iQyXxbjXp5x0wXyIgWmWoB7os0T91B6/ 7fOqplmblSRosdbL57Bu0GXcyrY1a9Ci4k8FjiVmgPMZt3dk4lh6SHk4nd1dvaDKDglqFC6K gpeGkox1IPRw==
- Ironport-sdr: NAwvLFSxQr0XCafJpAhuojhwzOHKaKCK8dJk8kbFxyykmDz0WIaNxNEtvnVetxjbKCh/6lZVKe BHx5wI0BO3aSE7TPSutRJelCRQCa9Fw8wKuaHIgZpecHiTHZK3BQmk/Mb9WWBAcszHVx2rjaZo 5/bY8bbggkim2T4CgojWVASWAayiSp+d8ZPZuDR2NtUDX1w1MjiNSvMVKfvnY57eMSM6Z694At 3A4fN236mPcpsBfn0XkJg7g3TMmxACuSyCic5HyKCsjhkm2MAqov/i1YnX2H1D0C8WW9RoUAWo Oko=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXcw87fHf7Qwb5uU2wdCPUfVSNNKs/vOyAgADnUNCAABgCAIABtUvw
- Thread-topic: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag
OK. Let's not upstream this. Owen and I *may* be able to find some time in the
future for stress testing of the various allocation calls one might use in
these places, and their effect on reliability and performance. Anecdotally,
we've seen situations when Mm calls do nasty things, and also seen situations
where using lots of pool does nasty things, but we haven't seen the two cases
intersect. Maybe revisit in a few weeks / months when I have hard data.
MH.
-----Original Message-----
From: Paul Durrant <xadimgnik@xxxxxxxxx>
Sent: 13 July 2021 11:24
To: Martin Harvey <martin.harvey@xxxxxxxxxx>; win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] Change AllocatePage to use ExAllocatePoolWithTag
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
On 13/07/2021 09:58, Martin Harvey wrote:
>
> NB. We also have a xenvif patch with a corresponding change that we were
> going to push up, so this is all or nothing for both xenbus or xenvif.
>
> MH.
I know. Ben implemented the change in multiple places. I'd rather not use pool
memory for whole pages if we don't have to.
Paul
|
