Re: [PATCH 2/3] Add logging for XenFilt AddDevice.

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 15/07/2021 14:15, Martin Harvey wrote:
> Recent releases of Windows (10 and 11 in particular) allow
> online edition updates which involve a driver migration step,
> which occurs in SAFEBOOT mode.
>
> In some rare cases, this step may fail (for a variety of reasons).
> This additional logging added to debug such upgrade cases.
>
> Signed-Off-By: Martin Harvey <martin.harvey@xxxxxxxxxx>
Acked-by: Paul Durrant <paul@xxxxxxx>

> ---
>   src/xenfilt/driver.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/src/xenfilt/driver.c b/src/xenfilt/driver.c
> index e9e6673..f131282 100644
> --- a/src/xenfilt/driver.c
> +++ b/src/xenfilt/driver.c
> @@ -723,6 +723,19 @@ fail1:
>       return status;
>   }
>   
> +static FORCEINLINE PCHAR
> +__EmulatedTypeName(
> +    IN  XENFILT_EMULATED_OBJECT_TYPE    Type
> +    )
> +{
> +    switch (Type) {
> +    case XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN:  return "UNKNOWN";
> +    case XENFILT_EMULATED_OBJECT_TYPE_PCI:      return "PCI";
> +    case XENFILT_EMULATED_OBJECT_TYPE_IDE:      return "IDE";
> +    default:                                    return "InvalidType";
> +    }
> +}
> +
>   static XENFILT_EMULATED_OBJECT_TYPE
>   DriverGetEmulatedType(
>       IN  PCHAR                       Id
> @@ -804,6 +817,10 @@ DriverAddDevice(
>           }
>       }
>   
> +    Info("%p %s\n",
> +         PhysicalDeviceObject,
> +         __EmulatedTypeName(Type));
> +
>       status = STATUS_SUCCESS;
>       if (Type == XENFILT_EMULATED_OBJECT_TYPE_UNKNOWN)
>           goto done;