RE: [PATCH] Fix compile on EWDK 22000

[Owen Smith <owen.smith@xxxxxxxxxx>]

-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
Paul Durrant
Sent: Thursday, August 5, 2021 7:09 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] Fix compile on EWDK 22000

[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments 
unless you have verified the sender and know the content is safe.

On 03/08/2021 15:38, Owen Smith wrote:
> - Adds warnings 4061 and 4062 to ignore list
> - Defines signtool file digest as SHA256
> - Adds alias for GetProjectInfoForReference target
>    It appears that VS2019/EWDK22000 changed a target name, and without the 
> alias
>    the build will fail.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Do the other drivers also suffer from this problem?

   Paul


All the drivers suffer the same problem, and I'm now looking at getting 
SDV/CodeQL/CodeAnalysis logs correct for the Static Tools Logo test in the 
Server 2022 HLK, which looks like more work is needed. From what I can tell, 
the DVL.XML logs should have an entry for CodeAnalysis and Semmle (CodeQL) 
indicating these tools have been run (I'm not sure yet if the logs need to be 
clean). So far, it looks like SDV with 20344 and 22000 cannot cope with 
RunCodeAnalysis=true and EnablePREFast=true at least during the "sdv /check" 
step. (Downside is testing this is very slow, as I must complete a SDV analysis 
cycle which can take several hours to complete)

Owen

> ---
>   vs2019/package/package.vcxproj             | 5 +++++
>   vs2019/version/version.vcxproj             | 6 ++++++
>   vs2019/xennet/xennet.vcxproj               | 7 ++++++-
>   vs2019/xennet_coinst/xennet_coinst.vcxproj | 5 +++++
>   4 files changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/vs2019/package/package.vcxproj 
> b/vs2019/package/package.vcxproj index dd794b5..e4c6f0f 100644
> --- a/vs2019/package/package.vcxproj
> +++ b/vs2019/package/package.vcxproj
> @@ -56,6 +56,11 @@
>     <ItemGroup>
>       <PackageFiles Include="$(OutDir)\$(ProjectName)\*" />
>     </ItemGroup>
> +  <ItemDefinitionGroup>
> +    <DriverSign>
> +      <FileDigestAlgorithm>sha256</FileDigestAlgorithm>
> +    </DriverSign>
> +  </ItemDefinitionGroup>
>     <Target Name="Archive" AfterTargets="TestSign">
>       <Copy
>          SourceFiles="@(PackageFiles)"
> diff --git a/vs2019/version/version.vcxproj 
> b/vs2019/version/version.vcxproj index 9d149d0..b6ec6f3 100644
> --- a/vs2019/version/version.vcxproj
> +++ b/vs2019/version/version.vcxproj
> @@ -13,4 +13,10 @@
>     <Target Name="Build">
>       <Exec Command="powershell.exe -ExecutionPolicy Bypass -NoProfile 
> -NonInteractive -File $(Script) $(Platform) $(SolutionDir) $(IncludeDir) 
> $(SourceDir)" />
>     </Target>
> +  <Target Name="GetProjectInfoForReference"
> +          Returns="@(ProjectInfoForReference)">
> +    <ItemGroup>
> +      <ProjectInfoForReference Include="@(LibFullPath)" />
> +    </ItemGroup>
> +  </Target>
>   </Project>
> diff --git a/vs2019/xennet/xennet.vcxproj 
> b/vs2019/xennet/xennet.vcxproj index 027dc4a..beb5bb3 100644
> --- a/vs2019/xennet/xennet.vcxproj
> +++ b/vs2019/xennet/xennet.vcxproj
> @@ -26,7 +26,7 @@
>         <IntrinsicFunctions>true</IntrinsicFunctions>
>         
> <AdditionalIncludeDirectories>$(WindowsSdkDir)\include\km;..\..\include;..\..\include\xen;</AdditionalIncludeDirectories>
>         <WarningLevel>EnableAllWarnings</WarningLevel>
> -      
> <DisableSpecificWarnings>4464;4711;4770;4548;4820;4668;4255;5045;6001;6054;26451;28160;28196;30030;30029;%(DisableSpecificWarnings)</DisableSpecificWarnings>
> +      
> + <DisableSpecificWarnings>4061;4062;4464;4711;4770;4548;4820;4668;425
> + 5;5045;6001;6054;26451;28160;28196;30030;30029;%(DisableSpecificWarn
> + ings)</DisableSpecificWarnings>
>         <MultiProcessorCompilation>true</MultiProcessorCompilation>
>         <EnablePREfast>true</EnablePREfast>
>       </ClCompile>
> @@ -71,5 +71,10 @@
>     <ItemGroup>
>       <ResourceCompile Include="..\..\src\xennet\xennet.rc" />
>     </ItemGroup>
> +  <ItemDefinitionGroup>
> +    <DriverSign>
> +      <FileDigestAlgorithm>sha256</FileDigestAlgorithm>
> +    </DriverSign>
> +  </ItemDefinitionGroup>
>     <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
>   </Project>
> diff --git a/vs2019/xennet_coinst/xennet_coinst.vcxproj 
> b/vs2019/xennet_coinst/xennet_coinst.vcxproj
> index a159abd..45ca05a 100644
> --- a/vs2019/xennet_coinst/xennet_coinst.vcxproj
> +++ b/vs2019/xennet_coinst/xennet_coinst.vcxproj
> @@ -53,5 +53,10 @@
>     <ItemGroup>
>       <None Include="..\..\src\coinst\xennet_coinst.def" />
>     </ItemGroup>
> +  <ItemDefinitionGroup>
> +    <DriverSign>
> +      <FileDigestAlgorithm>sha256</FileDigestAlgorithm>
> +    </DriverSign>
> +  </ItemDefinitionGroup>
>     <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
>   </Project>
>