[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/3] Fix SDV/CodeQL log generation
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 7 Sep 2021 07:21:02 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TKurUCZUbU3gw+ky79n9IO3LeT0DaNi6QjI4hzloE8k=; b=Qu5z2c98SZuY0GqPBF1Ki/A0Ol5S4ppL4O5l7lvrRmu2yOvUF5FyqtFWRFZ5T5CErAGTYkdfTnl84eM8B9AMa6Zo2CQYEZ7Jmg1Ko/f+Gqtn8W3YUgchTN/BWiSx42isOL5rgH78oHJHNp6DTwjV0azcM91LfcQ1JhsCdClqSUv1oVwxGFbcOtGbBwLmJqfs6fbBUrxi7wBbc6y+uzi1oBUkVp8NtY0uZ+H1MoEs8TfK2EJ2Dx0LBBbW8bgH+LvdEWMSHWKOuckkl+r8rnNLtjmCIWg8gwvR1uCoHVNoLfpIszjb97YnB7Svg7xiWW+WaXhFiDoVWSsDIjTiP9RMIQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqobCuS4WoupJkz43DM//Qs9SEXmtGLlj7xJdzq3UIn2+ZKhYqai3c5YdNv/iVgM5ctyGgarGR5FFlj+e498thOgwVKT65VZQzbH3gK4riF6gXUaywnP/WqZPb76AxRd7oACdgu1QX+l9ZeIf04MShgm+u8HeWkq+AKkhAUCFTp41pb+DfHwBi8emlSFj+0Mf/lGUOJcC2rMToRF6uDeILuCwrsBoSCfqoS1EP0XguEamCoo+lGHxr5iakQXGzY5MJyBhCS7CHeBYx6meK3wUtVDzz/Llx3INWmhWibPsoTUUeO8+aulmyBPpv/p4vW+XhjCca5eFbA3p/InAGqkYw==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Tue, 07 Sep 2021 07:21:13 +0000
- Ironport-hdrordr: A9a23:bIB6zq3ZrRPUi1GxKlIHbwqjBQdyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5AEtQ4+xoS5PwPE80kqQFrrX5XI3SEDUO3VHHEGgM1/qF/9SNIVycygcZ79 YaT0EcMqy/MbEZt7eC3ODQKb9Jq7PnkJxAx92ut0uFJTsaM52IhD0JbzpzZ3cGIzWucqBJcK Z0iPA3xQaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6f9bbRuwqdnSW+fkNgNyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv9nZMOq59ks5Vka/pWVFaRl/1swGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlJhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OGDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowlLau3ieffFm+ac7vywlbF/NLQgF+/sukqSR4IeMNYYDGRfzO2wTrw==
- Ironport-sdr: /xVmQK6s1C/SWIQvIGuzPY2Xm7h67xDgUlbAc8Pa1mwFHPF3PoF6GDITGhW8rTGyBStFC4kQrA OSJNUgsJiv3xmsOEaroIgG7kd4XH1We1EDBb6La6pJBM9bpCn8VC0Vwg9XvbwUkJn1ZfYyyzFG ewK9a0wUnGcjlY4cXydtqy3SwX0tk4JcReGH1miT/8p3Zrrr8y45DB+4R0yLIdoYZWCNEUwLOP wFM9TV5B2yQr6uX6PYu7zlmqqGIxJIJc0Nk6TIs8CSJPnCbDBA5V4ZIhNdvIpwkHmy6lzMp6Yt dsXWtZRIw4KFkXHY38f3Tw7j
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXjf4dSbK6zPqx/U6rlVdURJ9VkKt8GTEAgBsEwgCAATRSoA==
- Thread-topic: [PATCH 2/3] Fix SDV/CodeQL log generation
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Paul Durrant
Sent: Monday, September 6, 2021 1:45 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/3] Fix SDV/CodeQL log generation
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
On 20/08/2021 09:08, Paul Durrant wrote:
> On 10/08/2021 16:40, Owen Smith wrote:
>> - sarif files need to be stored with SDV logs when generating the DVL
>> file
>> - Disable PREFast and CodeAnalysis by default
>> - Run a seperate CodeAnalysis build after SDV, but before generating
>> DVL file
>> DVL file should contain multiple summary lines for SDV, at least
>> 1 line
>> for CodeAnalysis and at least 1 line for Semmle (CodeQL)
>>
>> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
>
> Acked-by: Paul Durrant <paul@xxxxxxx>
Actually I withdraw my ack because CodeQL tool doesn't appear to be in the EWDK
toolchain as yet. This at least needs some explanation in BUILD.md as to how to
set it up... or perhaps we wait for a revised EWDK?
Paul
There are additional setup tasks needed on the build system to run CodeQL.
* download CodeQL engine from github (from
https://github.com/github/codeql-cli-binaries/releases, latest tag)
* add CodeQL to PATH
* use git to clone the MS driver rules repo
(https://github.com/microsoft/Windows-Driver-Developer-Supplemental-Tools)
Note: layout should be like:
<some-root>\
Codeql\
Windows-Driver-Developer-Supplemental-Tools\
From
https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/static-tools-and-codeql
CodeQL logs (*.sarif) must be present and clean when generating the *.DVL.XML
logs for the "Static Tools Logo Test" to succeed for Server 2022.
The DVL logs should contain a summary line for CodeQL and Code Analysis as well
as the SDV results.
Owen
|
