[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/4] Add /CETCOMPAT to linker options
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 2 Nov 2021 10:28:05 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ic/ptkykcQBh4DYPjvdDm8kzQLgzGozz/62464SrZ2E=; b=bwMQm8YQuNMb/2xZyNy55rZqpwggNj5Wk5d/dpZ3BwTMvnjaBqnP1vsQ7xGimMPFr7Y9ZpCd+jf8YCG4gpnUEilhASFlsT1JBLcWWP5/wasaggqb0QrNktK9MTCwG5sqzxPfJnw9LYN3Z/Tb0Ug7iNERH9PE6SJ541SlaFrQlWGuyqGUGZH+GWwB+EPaa4EsSkstxPswxcGr9Wkucu5OKNf/NK/UeBtGwdT+e0j1PD9kif9jCto9MmRgtKeWjVOdyXs6FoNohXuK5ci5KzyMhYDG6feKpwqtqduRbexvl1d50URhrqeNfpw9F8CbCTdWy9i91nHZ3xqyIoBu4dvYAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KlmuLm3B7cQZ4LtDdk6F6iWy3wGgyzrf3TtSy4LnqvFe5Sb+6FQWaBt4urECU5flFP02C4uKlbyoivoeZNdd9iY3h47xR4PlPePmqgFIMUDoNlcFqBnzAq+OTn9p/4vmrNe2jjh08cVBfQOeSiOQZjAnxmbPrRbRlU9PzLGY17I0J/JtVmkXpKvqoVjNXRiTVYZCCl86tpBpDFYXZzTxM/DT64nc7cLR64VnifR42PI68Zj5rdQF6T/fdXHCRLGdJIFvv2mnwcTfsI1TehkiVkLq+MyCguGgFDwevs4TaDrwlA2ZfUNA5xk901VZFvmUlNz1/qiDS/jyaYxtYKuYVg==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Tue, 02 Nov 2021 10:28:21 +0000
- Ironport-data: A9a23:nvPE+6ADHu1DqxVW/+Lkw5YqxClBgxIJ4kV8jS/XYbTApGt30GMGz WNNWGrUa/qCYWCnetknOYy2pk0Du8fSyt4wQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX540Ug7wobVv6Yz6TSHK1LV0 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/2m6Ys+srk opxjMbtGQU4H4jJxP5eXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr KFGbmBWBvyAr7veLLaTTfZhgII4Kcj3PKsUu216zCGfBvEjKXzGa/iUuYcEhWdr7ixINf/9a fQAZGZtUD6eOhByAXIbFJURzN790xETdBUH8QnI9MLb+VP70w13laDzddbYZNGObcFUhVqD4 HLL+XzjBRMXP8DZziCKmlq0j/LLtTP2XsQVDrLQyxJxqATNnCpJUkRQDAbl56ni4qKjZz5BA x1P6wYV9/JtyHXxE4n/TjydpSKe/RFJDrK8DNYGwA2Kz6PV5SOQCW4FUiNNZbQaiSMmedA5/ gTXxo20XFSDpJXQECvArenM8VteLABMdTdaDRLoWzfp9DUKTGsbqhvUBuhuH6eu5jEeMWGhm mvaxMTSalh6sCLq60lZ1QyX695PjsKQJuLQ2ukxdjj8hu+eTNX9D7FEEXCBsZ59wH+xFzFtR kQslcmE9/wpBpqQjiGLS+hlNOj3vKvaYWeE3gQ1RsVJG9GRF5iLJ9k4DNZWfx8BDyr5UWWxP B+7Vf15vcc70ISWgV9fPNvqVpVCIVnIHtX5TPHEBueikbAqHDJrCBpGPBbKt0i0yRBEufhmZ f+zLJb9ZV5HWP8P5GfnGI8gPUoDm3lWKZX7HsugkXxKENO2ORaodFvyGALVM71is//c+G04M b93bqO39vmWa8WnCgH/+o8PN1Eaa389AJH9sctMceCfZAFhHQkc5zX5m+hJl1VNk/sHm+HW0 Gu6X0MEmlPziWeecVeBa2x5aaOpVpF69CppMSspNFeu+n4ifYfws/tPK8ppJeEqpL550Pp5b /gZYMHcUP5BfSvKpmYGZp7noY08KBny3VCSPzCoaSQUdoJ7Q1Cb4cftewbirXFcDie+ucYkj aen0wfXHcgKSwh4VZ6EY/Oz1VKh+3ManbsqDUfPJ9BSfmTq8ZRrdHOt3qNmfZlUJEyalDWA1 guQDRMJnsX3otc4oIvTmKSJj4a1CO8iTEBUKHbWsOStPi7A82v9nYIZCLSUfSrQXX/f8bm5Y bkH1On1NfAKkQoYs4d4FLo3n6sy68G2+u1fxwVgWn7Kc06qGvVrJXzfhZtDsahEx7l4vwqqW x3QpokGaOvRYM61QkQMIAcFb/iY0aBGkzbf2v05PUHm6XIl57GAS0hTY0GBhSE1wGGZ62/5L TPNYPIr1jE=
- Ironport-hdrordr: A9a23:pDAep65E4Ge8BdJhEwPXwXmBI+orL9Y04lQ7vn2ZFiY6TiXIra +TdaoguSMc0AxhJU3I6urwRJVoJkmsuqKdgLNhcYtKOTOGhILGFvAa0WKP+UyDJ8S6zJ8m6U 4CSdkxNDSTNykDsS+S2mDReLxMoKjlzEnrv5ak854Ed3AzV0gK1XYcNu/vKDwReOAwP+tfKH Pz3LsjmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgDfIBej8AXeSIrCNWkH4oN69PNkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wGJSFcZ4KcuZkZkIMMjgX5q3Pki1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwU/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFjxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiIviYfzQTOYNSSj5uw5zvn9ehTIYd228LAv23FQgMyPeIbW
- Ironport-sdr: OQDdPslfM+Qrqq62zaTMlPTt87GA5CckPKuz+87Ho1EYt6DBC4ryPWHOYm6nI4RDXVaIUht38Q tLsSly30xpYabwM1hxnMJjvBJfkcsIFiWsRzNsLdzlJ7og3QVnZWXvj0j1uaufP4MaVUDOZ5+D m9sgqPPkFQQxNjnNxGZvGpXcgu5Q9uDuyGRqP5SsUazz+ph5K7KmxYrlq3zWfJR6FxV3p6ZBQI B3o0mPMAtUYe0oAp6aW6ckn/47Oxdfwm+TirLHaO76rd4tADDdGQlQuBON3VlSRhyytMLFhmCz 3Bvy8tEYcINX+ybonAo/VGGS
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXyjjWhxe2oO8bBEWLJURGN2/BD6vwDiKAgAAFwuA=
- Thread-topic: [PATCH 1/4] Add /CETCOMPAT to linker options
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Durrant, Paul
Sent: 02 November 2021 10:06
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/4] Add /CETCOMPAT to linker options
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
On 26/10/2021 08:12, Owen Smith wrote:
> The "Hardware Enforced Stack Protection Compatability" test introduced
> with the Server 2022 HLK requires drivers to be linked with /CETCOMPAT
>
Does this patch need applying to all drivers then?
It does - I've got a patch in our queue, and was intending on posting them once
I'd completed WHQL, but it had slipped my mind
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
Acked-by: Paul Durrant <paul@xxxxxxx>
> ---
> vs2019/xennet/xennet.vcxproj | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vs2019/xennet/xennet.vcxproj
> b/vs2019/xennet/xennet.vcxproj index ca89610..d79a691 100644
> --- a/vs2019/xennet/xennet.vcxproj
> +++ b/vs2019/xennet/xennet.vcxproj
> @@ -35,6 +35,7 @@
> <ImageHasSafeExceptionHandlers>false</ImageHasSafeExceptionHandlers>
>
> <AdditionalDependencies>$(DDK_LIB_PATH)\ndis.lib;$(DDK_LIB_PATH)/libcntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;$(DDK_LIB_PATH)/procgrp.lib;%(AdditionalDependencies)</AdditionalDependencies>
>
> <LinkTimeCodeGeneration>UseLinkTimeCodeGeneration</LinkTimeCodeGenerat
> ion>
> + <CETCompat>true</CETCompat>
> </Link>
> <DriverSign>
> <FileDigestAlgorithm>sha256</FileDigestAlgorithm>
>
|
