[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFC Add extra sync release step for late callbacks.


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: "Durrant, Paul" <xadimgnik@xxxxxxxxx>
  • Date: Fri, 29 Apr 2022 09:21:06 +0100
  • Delivery-date: Fri, 29 Apr 2022 08:21:12 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

On 28/04/2022 14:01, Martin Harvey wrote:
This patch for RFC. I think it solves some longstanding suspend/resume issues we have had.


Yes, this fixes the breakage introduced by commit 9b7a47317031 ("Re-work the code in sync.c to provide per-CPU 'early' and 'late' callbacks...") but things are getting a bit messy now. At this point I think it best we have a state model with helper functions to transition between the states. It should be possible to call these from SyncWorker() as well as the main entry points and hence avoid some of the code duplication that already exists.

Since it's my idea, I won't ask you to do the re-work :-) I'll get a patch together today and post it to the list.

  Paul



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.