[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] Remove varargs from AdapterVifCallback.
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Martin Harvey <martin.harvey@xxxxxxxxxx>
- Date: Thu, 19 May 2022 14:37:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fErMKVhcn10dIf35KEPRteTJZ0PRlLhyOAn86rSygZo=; b=GRt2oW0VzVG+vWpvCn9HorAKuZaw0saN2Hj5RCbhISfsPBMYd9IcyItvcmvqem9FwSlCK7eLZLsT4gHsGxsI3x/OR6lm+qcvkwE4C6r8w5RcfX8roPnvsQmokSaQq+h/eRuJHCdF2zeYc/bjkf9VaVcs+nm31qss3K0OZb/XxOKhNxc/WxknHHymM6ksgbLtoO2guzmwH3MPr9cTEF41C530MCUk9ckKpHMiOc9R90ZBIJ46K5GQDCJlng1iVhIn9kfChUZxCCGBIwNCimtnqvaV22ssYtQxCpyBkuLhonnROa+C9bAL0xtGWMipnSHq61IcUw+B6DUhuLAAnaS/xg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LD5jyccz9WquSu81AKIhdWGCMFvFM6KNNNDS/x07zcPorrQXCd2t0XtDdhJ2p54fM+Lmrx32Z1V/F33vX2nPRVQE08Z4YyIm35Q5JwhDZuaNHjz2bFKgve9nGGFO3MUoOvOQ2I9LwNLWj7+CWAtnbmPkip9HH4n4MkfPsD4HErdbRg+9Ku6Xj2tgrtlmouhRtwJk9kLBfmaG/tfZAAHZPEM2Dda18CwEOtJcxMhZgDFywNvOS/KrNwlvaFUulJQ+o4Kq/jh1zdC0nxUmbAmteS8KczKBNS5byIYt194JfjVlZ0fPB2HHev6GgzZFJSympPWTXKoiBtNYQaOkfe3HwA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Thu, 19 May 2022 14:38:00 +0000
- Ironport-data: A9a23:bLIAvKvH46/hFKnGr3HFU/U7mefnVDVfMUV32f8akzHdYApBsoF/q tZmKW6PO/7ZZGT0edgiPYTi8EgGscSAydZrGgRoqy88EXgX+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U6 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8KL4Tmgu9GSSJ+KHtjAb1hxpSZDGWW5Jn7I03uKxMAwt1IJWRuZ8gy3L8yBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IBmmtr7ixNNa+2i 84xbDN1cBXGJR1GIEkaGbo1nfuyh2m5eDpdwL6QjfVuvjaKkFMuuFTrGObSa9GVRuhvp1i/l j2Z4V/XB04FHvXKnFJp9Vrp3IcjhxjTQIsPEJWo+/gsh0ecrkQMCRtTTUX+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQnZKflhsVWt4VGetj7giIkvXQ+1zBWjNCSSNdYts7ssNwXSYty lKCg9LuA3poraGRTnWesLyTqFteJBQoEIPLXgdcJSNt3jUpiNhbYs7nJjq7LJOIsw==
- Ironport-hdrordr: A9a23:Kvb/Pa2PqXzn1Wkr4UbxhwqjBQZyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4exoS5PwOk80kqQFq7X5XI3SFzUO3VHFEGgM1/qH/9SNIUzDH6tmpN 5dmstFeZDN5DpB/KHHCWCDer5OruVvsprY49s2pE0dLj2CHpsQijuRfTzrcHGeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR /30lMd1opImjTslyqO0GHQMkHboUsTAjnZuBOlaDLY0LDEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77VLADvXzJmVXf3CP0A0feC8o/gxieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsZSRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGda48aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu188HLzou WybLp1jx9NR6u1M7zw4HRiyGG9fEytGTLw18pZ+591/rXhWbuDC1zxdGwT
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHYZrO57BEWPEzIEEyWwuNn09oQGq0mMbkAgAAZ31A=
- Thread-topic: [PATCH 2/2] Remove varargs from AdapterVifCallback.
> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
> Durrant, Paul
> Sent: 19 May 2022 13:54
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/2] Remove varargs from AdapterVifCallback.
>
> > -/* V9 is exactly the same as V8 */
> > -typedef struct _XENVIF_VIF_INTERFACE_V8 XENVIF_VIF_INTERFACE_V9;
> No, you can't do that. The point of the versioning is that we make no
> incompatible change. You need to introduce v9 in its final form.
OK. I have submitted two patches in the series in order to give you a choice -
as I will explain:
1) I assume you have noted the "-", to indicate that that these lines are
present after applying one of the two patches, but not both.
2) Would you like V9 to be just the interface as it is after [1/2] has been
applied to both xenvif and xennet (keep varargs), or as it is after both
patches have been applied to both xenvif and xennet.
3) I talked this thru with owen and we agree that the interface changes and
version bump for the interface and associated ID's should happen in one atomic
patch / change to the codebase. In which case, I should probably just be
submitting one patch. However, I have submitted it in two halves because I
don't know whether you want the varargs changes or not.
4) If we don't remove varargs (1 of 2 patches on both), I *have* to update the
version number, because the interfaces are not binary compatible. However, the
function prototypes for all the calls are, because the difference is hidden
away in varargs, hence the definition.
So, going back to previous points:
1) Would you like one or both?
2) If only one, do you want me to declare a v9 interface which has an identical
set of function calls (because the difference is hidden in varargs
implementation)?
MH.
|
