[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] Rate limit per DPC using both xenvif and xennet.
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Fri, 10 Jun 2022 12:52:51 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1y7TqiUUFu8EfqRKihDR5UkyDnErrWVh+3zjZuIghVI=; b=apFSavvi2NXJHYtUzxoKjPCLF9GAN+lrxQm3OYqoNbTGD3M/LQgT+6qOfe0OBRzvkxD+BYl1UcGnNzXjEmLmG1FrYylGD4lpN3fqOp8fU3kTP8ZOfm26ttz34heP6utkTeUSglBAWZAOT6F38X0LoxOyX5WOqPKZ8NUejosqsd1XbpLdNqMP/F2iyVGfECuPgKTaaGk9+XE5ILTB+r9Gs34LLvScisAwKlif8G7fYTyidegqNTVa+KzZCAhUqcyIBUdpKNNVbK70IpkGZK4Ald69BIhDD33UrIlEOh8ajrFZyGx/jDOEzfeWdfB6g0boqKZHTucZtrBnYIJv01MLFg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gXlIAiNB31SitQcEBy8PZpewmvOpLmlxuVuO3p9OMnIhULPJkCIqggyaaoa4b0eDwmiEZuoe5QcbQ9VXqh6oU8u/g7uNwNBHKb834XI3RIz/LBOo7cWAiEQsSbW7VfOkt0OZ9sCezKbha5k0J/X7UTfc4bTxNbgeepli4+WV/DfU1Na8MaLgn9ESvtP8mRxfKmFV7Ec4LE3vx4XqAJf6prnpsnZmiqyfXC++ELkvPmQO3I6Pd8os+Zb4KxSQWvQpIs9Lydr4J8vtZY2CwE/cShhLy8SGaYy0P3RC/Z6L9Lh0+v66c7XKeC23x1kiqRU26HCwSxVWMnkmQ8louSAwQw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Fri, 10 Jun 2022 12:53:29 +0000
- Ironport-data: A9a23:t97eTKpdknJkzoDzXYmbPF3swZFeBmJ5ZBIvgKrLsJaIsI4StFCzt garIBmAPP+LMWr8L490at7i80gHvZTUyYcwSlZv/HwxFHhE95uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvT4 Iuq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBebLTvbQkAx5iSh4gFK9douLLB1vlrpnGp6HGWyOEL/RGKmgTZNdd39ktRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkGgnFs2aiiHt6HD yYdQT1wYRKGeBhOJlc/A5Mihua4wHL4dlW0rXrK+PppsjiPnWSd1pDfEdHRZf+xGf93m028t n3n3mnHOhsVYYn3JT2ttyjEavX0tTvyRYY6BLC+sPlwjzW72W0VTQUIEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNyBUu1aBtx8YHt9PSesz7VjXzrKOu1rGQG8ZUjRGddoq8tcsQiAn3 UOImNWvAiFztLqSSjSW8bL8QS6OBBX55FQqPUcsJTbpKfG6+OnfUjqnog5fLZOI
- Ironport-hdrordr: A9a23:4zIuaKsRKEGYQiB9gDHFo99Z7skCwoMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H5BEDyewKmyXcT2/haAV7CZnishILMFu1fBOTZslnd8kHFl9K1kJ 0QCpSWa+eAQGSS7/yKhzVQeuxIqLbozEnrv5a5854Hd3AIV0gU1XYdNu/tKDwVeOApP/oEPa vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+wg+A2frfKVy1zx0eWzRAzfMJ6m 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRhOerRfb8y/T9GA+cyTpAV74RGYFqewpF5d1H3Wxa0O UkZS1Qe/ibpUmhOV1d6iGdoTUImAxelkMKj2XozUcL6PaJOA4SGo5Pg5lUfQDe7FdltNZg0L hT12bcrJZPCwjc9R6NkeQgeisa4nZcm0BS5tL7TkYvIbc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFkgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCPefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzve4PcV T6ISFlXEIJCjzT4Je1reJ2Gzj2MRSAdCWozN1C7J5kvbC5TKb3MES4OSMTr/c=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHYbFP+0CwBwK5H30KPOTOINQ/8Tq1Isg0AgAAG2RA=
- Thread-topic: [PATCH 2/2] Rate limit per DPC using both xenvif and xennet.
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Durrant, Paul
Sent: 10 June 2022 13:27
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/2] Rate limit per DPC using both xenvif and xennet.
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
On 20/05/2022 15:14, Martin Harvey wrote:
> Further development of rate limiting code, whereby both xenvif and
> xennet co-operate across the VIF interface to decide how many packets
> to push up the stack. This allows for the situation where NDIS could
> provide information at upstream push time about how many more packets
> it is prepared to accept in this DPC.
>
> Signed-off-by: Martin Harvey <martin.harvey@xxxxxxxxxx>
I've looked at this a bit and umm-ed and ah-ed and I think I'd like the change
from varargs to a struct in a separate patch. It'll mean burning a version
number but I still think it would be cleaner; I'll work on splitting it up.
Paul
Would it make sense to retire the 0x0800xxxx revisions at the same time. We're
not hitting the device ID length limits, and would be unlikely to hit them, but
it does make things a bit cleaner
Owen
|
