[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 5/5] Lazily construct slab objects
- To: Paul Durrant <xadimgnik@xxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Wed, 7 Sep 2022 08:53:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MeBDaxebTFkH8cff3tN0Q3U5BCSNADYrm/g6xJcb8Yo=; b=JWoM9jD7YJiPK11IGx+juYrXydqTAco9iE9aj9ui7zxRSiJ1f+Law3+PjEAsoPn10OSb7nAKNeeIeJuajU8qo7PMYHlaEfWQxTohFj+uZCAG+n/q5t2eA8saReMGdL0+/KaswvYuPF4Nmn7uz3tSr1toLSS+i0CK0IEUJBFo14URjp8Gvr0vu5t8zBD+L/LzHhKtkojarHB4A4VIBFUUf7dtW8sJr/sKsJtHi8/G+Hswty6FccvHZ/71bPmU+UOj9If4heP6RlGweMxmK0cNxnTGwxBd+ZvhBMyU9TeMfcHh19pNL8omMkNJWP/tug0MNSomYrGfwwaA3rmTbJ0bwA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VS4BON4BTtNzNL7n5lI7dRDx7z+eUSzYxjMRYNdudh3p0uqYATIBJpvG5oRBgngTprOU/PEv4BKITNQMcx1yfHQUuUgYqwZ1ULbHIxzb+QpCE8gDd4c+JRg1kJrBiGQH2d8XqkRsI26Cn3VlNLzPVGHspOf2B3OY7W1OyMKbaENf0KTd+f48PxdmGELyTfGYoslOy7G8WiIiZTM4Coa58d03u0Xc4nJv+3YJeyMt9QRPahij947za3/IBVkoPujRoAB/myszXARFURzYYfbFY1favaaLKwCIwpfziXE7Bj8Ti/fMDapn2M1LMDnw5zJPr+UDAdl06tE0LgxPkgLvtw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Wed, 07 Sep 2022 08:53:21 +0000
- Ironport-data: A9a23:fuI5hKr6gysxvSV0T6SL0wPTerxeBmIMZBIvgKrLsJaIsI4StFCzt garIBmEbquKajOhKNpxO4S+oUgG75/dyt5iTgVrri89FihB9JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6WtH5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVG09pQEUdSr sYfNXdTYVPdlc67xZiCH7wEasQLdKEHPas5k1Q5l3T1KKhjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/E4/NovgA/zyQouFTpGN3Kd9rMXsBUgkawr WPa5WXpRBodMbRzzBLaoyP33LCXxUsXXqoON6KjxNVp2mGM33FILF4pSFue/KSA3xvWt9V3b hZ8FjAVhbg7+E2uQd/8XDW3pXeFulgXXN84O/I77kSV1O/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRSXKa9THuc8vKYqG20MC1Md2saP3ZbEE0C/sXpp5w1glTXVNF/HaWpj9rzXzbt3 zSNqyt4jLIW5SIW65iGEZn8q2rEjvD0osQdv207gkrNAttFWbOY
- Ironport-hdrordr: A9a23:e37EWamHlXYydSkmFyHfJ7JFaFPpDfOSimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdG9qADnhOVICO4qTPyftWjdySOVxeRZgbcKrAeQfxEWmtQ96U 4kSdkGNDSSNykxsS+Z2njeLz9I+rDun86VbKXlvhFQpGpRGsJdBnJCe2Om+zpNNWt77PQCdK a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Ll1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoNOCXMsLlaFtzfsHfpWG1TYczAgNnzmpDs1L8eqq iMn/7nBbU315qeRBDwnfKn4Xib7N9n0Q6e9bbfuwqvnSWxfkNHN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3am+a/hGrDvAnZMZq59ms1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgn/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9MKOM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaCqDgDKFC66 gpfGkoy1LaIXiedvFm9Kc7gyzlUSG6QSnnzN1Y6txwpqD8LYCbQRG+dA==
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHYvVYdbe5VFe/df0WVT/M8QjgpUa3JOJMAgAADQYCACnakoA==
- Thread-topic: [PATCH 5/5] Lazily construct slab objects
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Paul Durrant
Sent: 31 August 2022 18:01
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 5/5] Lazily construct slab objects
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
On 31/08/2022 17:49, Martin Harvey wrote:
>
> This will help our resource usage issues as well as Owen's gnttab work. I
> have checked, and unless he modified more source files, this does not
> currently conflict with anything Owen has in the works.
>
> Approved, MCH.
>
Cool, thanks. If I don't hear in any dissenting voice I'll push these tomorrow.
Paul
This does not fit with the CACHE changes to a FreeList, but should work very
similarly. The XenVif GNTTAB caches should only create 2 slabs, 1 will be fully
populated (253 objects, unless the header efficiency improves this) and 1 will
be partially populated (7 objects). This should also help with some of XenVbds
buffer CACHEs, where each object internally allocates a PAGE of memory, which
should resolve another issue I've seen (will bump our internal ref for testing
now)
Patches look good to me.
Owen
>
> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On
> Behalf Of Paul Durrant
> Sent: 31 August 2022 17:24
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Paul Durrant <pdurrant@xxxxxxxxxx>
> Subject: [PATCH 5/5] Lazily construct slab objects
>
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
>
> To avoid a large overhead in both time and potemtially space when a new slab
> is created, only construct objects as they are allocated. When they are freed
> we keep them constructed to increase the chance of finding an already-
> constructed object during subsequent allocations.
>
> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
>
>
|
