[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] FdoCreate: bad memset in failure path.
- To: "Rabish Kumar (3P)" <Rabish.Kumar@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Thu, 17 Nov 2022 10:39:31 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kN3Y7LIQHUYnCkbtfTCBVc0CIf+HyuXg+GGjmK6XDKY=; b=OAbNx+napzStMAVqmzFGRYNPMGtwpkO0oEG/JzkWqwG2fTR6Lts+T+B8WZrFCBah+MXmGnLAXqh6asYGCemdIe/qlPmtKoSVqIkQ/1PcfD+u4KVBMI72ts0+DI12uIId0tHap085mSvQ3AmifyFeOoAQci3PjFpjZWKX7aqUrXkzUmH5NuQB+JVZ8kQdkGnH5F8NTx7gEMc9eFfiprUvJeOYmZGcobHAbSmgS+YMGVphfNhh8jGI+65XNkghLuGYN3kdRHBWKigBxDo/orQQOE9FzwOo/ry1H4I4GOx/AvYGEELoEZ11DcRrbwa/k2vaTU1FZt2i3Te9ivX44+Eqyg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hrVziwDmvwDLJjxchF7LL/V+57V5ArSXvgWdgZXLExmbWPK1E91tOBLCWMjclMZtCKlRUkj9F/X0DNS83WNfLv121hCkrF/Xycbp4NR79r5NJoF1pA4ts1SIQvkpSFtp+kxZK838jQffBotXwFT53OLkFneQDiZXjQJO7ECHUXuwQNvuumgdjbho1dffIEybIfMZnij9ia2Vl8r/a555FPleLLE0w4NLpwd7v/KVZwHNqWffnALnoWTX/XL7A2OlOA/aJlev8HHmdXOYxfOH6dVM24AV62FY1T8qtzJCAszLb2h9kYioukNAVw2uti51c3FfHRKKAR2Gc2zXHofPzw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "Rabish Kumar (3P)" <Rabish.Kumar@xxxxxxxxxx>
- Delivery-date: Thu, 17 Nov 2022 10:39:49 +0000
- Ironport-data: A9a23:qS+W16y6Rh/n2SkHOmt6t+c1xyrEfRIJ4+MujC+fZmUNrF6WrkVSz WIdWz/SP/aPazbwetx+b43i/RwPsJCDyIVnQABrrCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPK8T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXp8/ 9wFBAEBUg6k2L+P2ru2SMZoh+12eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQruFTuGIO9ltiiQtpYmACDo 2Pa/0zyAw0ANczZwj2Amp6prr+TxXyqCd9PfFG+3uI0sBqZnD0xMxITcEWK+N6ArW2bdusKf iT4/QJr98De7neDUdj7GgWm5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAOHKr+czTD0uk 1WPwNXgAGU3tKXPECrHsLCJsTm1JC4Za3cYYjMJRhcE5N+lp5wvihXITZBoF6vdYsDJJAwcC gui9EAW74j/R+ZSv0ln1TgrWw6Rm6U=
- Ironport-hdrordr: A9a23:xIaUgK4ibwBCcIgDrgPXwfKCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICO4qTP2ftWjdySCVxeRZgbcKrAeQfBEWmtQ96U 4kSdkHNDSSNyk2sS+Z2njfLz9I+rDun86VbKXlvg5QpGpRGsNdBnJCe2Km+zpNNWx77PQCdK a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbLcAMLHBku7SiJlHeN5KThGxaV8x8CW3cXqI1Svl Ttokjc3OGOovu7whjT2yv66IlXosLozp9uFdGBkc8cLxTrk0KNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4Dp0/5TyWQm1/AygPg2DEh5zvJ0lmDm0bupsT/WXYTF9dBrZgxSGqZ12MQ+PVHlI 5b1WOQsJRaSTnamj7m2tTOXxZ20mKpvHsZl/IJhXA3a/pfVFYRl/1dwKpmKuZEIMvI0vFiLA CoNrCa2B9iSyLZU5kehBgo/DXjZAVrIv7MeDl+hiXc6UkroJk+9TpX+CVXpAZ+yLstD5ZD/O jKKaJuifVHSdIXd7t0AKMbTdKwEXGle2O7DIu+GyWSKEg8AQO7l7fnpLEuoO26cp0By5U/3J zHTVNDrGY3P0bjE9eH0pFH+g3EBDzVZ0Wk9uhOo5xi/rHsTrviNiOODFgojsu7uv0aRsnWQe y6Np5aC+LqaWHuBYFK1QvjXIQ6EwhWbOQF/tIgH16eqMPCLYPn8uTdbfbIPbLoVS0pX2vua0 FzKQQb5P8wnHxDdkWI8CQ5AUmdBHAX1agAYZTy7qwU1JUHMJFKv0wclUm5j/v7WgF/jg==
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHY+mlN1segnDg3SU2ZyElWazxk165C7Fag
- Thread-topic: [PATCH] FdoCreate: bad memset in failure path.
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Rabish Kumar (3P)
Sent: 16 November 2022 16:14
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Rabish Kumar (3P) <Rabish.Kumar@xxxxxxxxxx>
Subject: [PATCH] FdoCreate: bad memset in failure path.
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
Signed-off-by: Rabish Kumar <rabish.kumar@xxxxxxxxxx>
Fail14 attempts to clear the wrong interface - possibly leading to the ASSERT
at line 3249 asserting
Acked-by: Owen Smith <owen.smith@xxxxxxxxxx>
---
src/xenvif/fdo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/xenvif/fdo.c b/src/xenvif/fdo.c index 8067e03..b684c7b 100644
--- a/src/xenvif/fdo.c
+++ b/src/xenvif/fdo.c
@@ -3173,8 +3173,8 @@ FdoCreate(
fail14:
Error("fail14\n");
- RtlZeroMemory(&Fdo->UnplugInterface,
- sizeof (XENBUS_UNPLUG_INTERFACE));
+ RtlZeroMemory(&Fdo->GnttabInterface,
+ sizeof (XENBUS_GNTTAB_INTERFACE));
fail13:
Error("fail13\n");
--
2.37.2.windows.2
|
