[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC: PATCH 5/5] Add Unplug v2


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Paul Durrant <xadimgnik@xxxxxxxxx>
  • Date: Tue, 12 Sep 2023 08:57:30 +0200
  • Delivery-date: Tue, 12 Sep 2023 06:57:37 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

On 31/08/2023 08:50, Owen Smith wrote:
If NICs have not been unplugged, do not start PV network devices and trigger a
required reboot.
This is to avoid the upgrade case where both emulated and PV devices could be
present, due to a 'revert to emulated' policy and emulated NICs not currently
getting IP configurations so the HasAlias value is not determined correctly.

Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>

Have you sent the XENBUS patch(es) for the new unplug interface version? I don't recall seeing them. Also, given its fairly specific meaning, perhaps IsUnplugRequested() is a better name than GetState()?

  Paul




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.