Re: [PATCH v2 4/6] Add Unplug v2 interface (REV_0900000A)

[Owen Smith <osmith@xxxxxxxxx>]

Theres a linker issue picking the correct functions - UNPLUG(WasRequested,...) -> UnplugWasRequested in unplug.c which needs to call UnplugIsRequested in xen.sys otherwise the linker complains about function redefinitions

Owen

On Thu, Sep 28, 2023 at 1:37 PM Paul Durrant <xadimgnik@xxxxxxxxx> wrote:

[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.

On 13/09/2023 14:45, Owen Smith wrote:
> Unplug v2 adds a query call to determine if a device type has had its unplug issued.
> This is useful during upgrade cases when the Unplug keys have been set to 0, and can
> be used to prevent XenVif from starting whilst emulated devices are present, but those
> emulated devices have not been assigned a valid configuration yet (emulated devices
> will receive valid configuration, but not at this point in the startup sequence during
> upgrade)
>
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>
> ---
>   include/revision.h         |  3 +-
>   include/unplug_interface.h | 30 +++++++++++++++++--
>   include/xen.h              |  7 +++++
>   src/xen/unplug.c           | 15 ++++++++++
>   src/xenbus/unplug.c        | 59 ++++++++++++++++++++++++++++++++++++++
>   5 files changed, 111 insertions(+), 3 deletions(-)
>

Not sure about the 'Was' versus 'Is' thing. I think I'd prefer
consistency, but I'll deal with that.

Acked-by: Paul Durrant <paul@xxxxxxx>