Re: Changing user-mode interfaces

[Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>]

On 30 lis 2023 16:10, Paul Durrant wrote:
> On 30/11/2023 15:03, Owen Smith wrote:
> > If xencontrol.dll is deemed the public stable interface then;
> > - xeniface.inf needs to include xencontrol.dll (its missing at the 
> > moment, trivial fix)
> Ok. I thought it was already there.
>
> > - xenagent should be modified to use xencontrol.dll calls
> Yes, that seems reasonable but not strictly necessary, since it is in 
> the same package.
> > - xencontrol.dll could be extended to handle 
> > RegisterDeviceNotification events and/or expose the raw device handle
> Ok.
>
> > - XenServer's usages would need to reference xencontrol.dll interfaces 
> > (its possible, via LoadLibrary/GetProcAddress, but not pretty)
> LoadLibrary() shouldn't be too ugly, I wouldn't have thought.
>
> Let's go with this plan. Rafał does that work for you?
Yes, this is fine. So, my changes will be as follows:
- New gnttab IOCTLs with modified parameters, the old ones will 
continnue to function as before (just that the request ID parameter will 
now be ignored by the driver),
- changes in xeniface IOCTL handling, but no changes in the GNTTAB 
driver interface,
- I guess I should also add new wrapper functions in xencontrol.

Any preferences as to the naming convention? Just add _V2 to the IOCTL 
struct and code names? The current ones don't have _V1 which was a bit 
of an oversight...
--
Rafał Wojdyła
Invisible Things Lab

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature