[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RFC PATCH 3/3] ASSERT(Frame->Mdl != NULL) before dereference



CodeAnalysis detects a false positive, where Frame->Mdl could be NULL in
GnttabContract. Without asserting a non-NULL pointer, SDV will generate a
DVL log file that will fail WHQL testing.

Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>
---
 src/xenbus/gnttab.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/xenbus/gnttab.c b/src/xenbus/gnttab.c
index 4f6617b..57c36df 100644
--- a/src/xenbus/gnttab.c
+++ b/src/xenbus/gnttab.c
@@ -274,6 +274,7 @@ GnttabContract(
 
         Info("removed refrences [%08llx - %08llx]\n", Start, End);
 
+        ASSERT(Frame->Mdl != NULL);
         Pfn = MmGetMdlPfnArray(Frame->Mdl)[0];
 
         (VOID) MemoryRemoveFromPhysmap(Pfn);
-- 
2.41.0.windows.3




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.