[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 0/3] Rework Power handlers


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Paul Durrant <xadimgnik@xxxxxxxxx>
  • Date: Thu, 1 Feb 2024 17:35:07 +0000
  • Delivery-date: Thu, 01 Feb 2024 17:35:16 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

On 10/01/2024 13:42, Owen Smith wrote:
Current power handler code is passed to a single threaded work thread which
can be delayed enough to trigger 0x9F (DRIVER_POWER_STATE_FAILURE) bugchecks.
Rework power handlers to math standard practive, using pended IRPs,
IoCompletionRoutines and deferred IoWorkItems where required.

Martin Harvey (2):
   [XenFilt] Asynchronous power handling.
   [XenBus] Asynchronous power handling


I advised Martin against these changes over a year ago. How prevalent is the problem? It took *years* to get this, and the PnP code stable. How much testing have these changes had?

  Paul

Owen Smith (1):
   ASSERT(Frame->Mdl != NULL) before dereference

  src/xenbus/fdo.c    | 792 ++++++++++++++++++++++++--------------------
  src/xenbus/gnttab.c |   1 +
  src/xenbus/pdo.c    | 250 ++++++--------
  src/xenfilt/fdo.c   | 498 +++++++---------------------
  src/xenfilt/pdo.c   | 503 +++++++---------------------
  5 files changed, 777 insertions(+), 1267 deletions(-)





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.