Re: [PATCH] xencontrol: Fix return values and simplify failure paths

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 15/03/2024 10:11, Rafał Wojdyła wrote:
> XcGnttabRevokeForeignAccess() and XcGnttabUnmapForeignPages()
> could return error values even when the calls succeeded. This was because
> GetLastError() was used to get the return value even if the previous call
> to DeviceIoControl() succeeded.
>
> This commit also reworks all xencontrol functions to use simpler control
> paths in failure cases.
>
> Signed-off-by: Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>   src/xencontrol/xencontrol.c | 268 ++++++++++++++++--------------------
>   1 file changed, 116 insertions(+), 152 deletions(-)
Acked-by: Paul Durrant <paul@xxxxxxx>