Re: [PATCH] Add DeviceID info to DisplayNames

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 28/10/2024 13:02, Owen Smith wrote:
> Append the DeviceID info to the strings used for the DisplayName strings.
> Use the current genfiles.ps1 script, as part of the version project, to
What is the 'version project'?

> populate the %XenBusName_VEND% value (or remove the lines) to match the
> binding hardware ID.
Also, shouldn't the PRODUCT_NAME already convey the requisite information?

> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>
> ---
>   src/xenbus.inf | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/xenbus.inf b/src/xenbus.inf
> index 73a2b11..7cc9ac2 100644
> --- a/src/xenbus.inf
> +++ b/src/xenbus.inf
> @@ -69,9 +69,9 @@ 
> xenbus_monitor_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.dl
>   ; DisplayName         Section         DeviceID
>   ; -----------         -------         --------
>   
> -%XenBusName%		=XenBus_Inst,	PCI\VEN_5853&DEV_@VENDOR_DEVICE_ID@&SUBSYS_@VENDOR_DEVICE_ID@5853&REV_01
> -%XenBusName%           =XenBus_Inst,   PCI\VEN_5853&DEV_0002
> -%XenBusName%           =XenBus_Inst,   PCI\VEN_5853&DEV_0001
> +%XenBusName_VEND%      =XenBus_Inst,   
> PCI\VEN_5853&DEV_@VENDOR_DEVICE_ID@&SUBSYS_@VENDOR_DEVICE_ID@5853&REV_01
> +%XenBusName_0002%      =XenBus_Inst,   PCI\VEN_5853&DEV_0002
> +%XenBusName_0001%      =XenBus_Inst,   PCI\VEN_5853&DEV_0001
>   
>   [XenBus_Inst]
>   CopyFiles=XenBus_CopyFiles
> @@ -149,6 +149,9 @@ HKR,,TypesSupported,0x00010001,7
>   Vendor="@VENDOR_NAME@"
>   DiskDesc="@PRODUCT_NAME@ PV Bus Package"
>   XenBusName="@PRODUCT_NAME@ PV Bus"
> +XenBusName_VEND="@PRODUCT_NAME@ PV Bus (@VENDOR_DEVICE_ID@)"
> +XenBusName_0002="@PRODUCT_NAME@ PV Bus (0002)"
> +XenBusName_0001="@PRODUCT_NAME@ PV Bus (0001)"
>   XenFiltName="@PRODUCT_NAME@ Generic Bus Filter"
>   MonitorName="@PRODUCT_NAME@ PV Driver Monitor"
>   MonitorDesc="Provides support for @PRODUCT_NAME@ PV drivers"