[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XENBUS PATCH v2 1/5] Cleanup duplicate error variables in TryAutoReboot

To: paul@xxxxxxx, win-pv-devel@xxxxxxxxxxxxxxxxxxxx
From: "Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>
Date: Wed, 11 Jun 2025 10:53:33 +0000
Delivery-date: Wed, 11 Jun 2025 10:53:49 +0000
Feedback-id: 30504962:30504962.20250611:md
List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

On 11/06/2025 12:48, Paul Durrant wrote:
> On 09/06/2025 15:00, Tu Dinh wrote:
>> These variables should also be DWORD instead of HRESULT.
>>
> 
> Why? According to the docs I have read StringCbPrintf() returns an HRESULT.
> 

I saw it used with a bunch of Reg* functions and missed it being used 
with StringCbPrintf as well. I'll split it into two variables then.

Best regards,

 | Vates

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

References:
- [XENBUS PATCH v2 0/5] Autoreboot rework
  - From: Tu Dinh
- [XENBUS PATCH v2 1/5] Cleanup duplicate error variables in TryAutoReboot
  - From: Tu Dinh
- Re: [XENBUS PATCH v2 1/5] Cleanup duplicate error variables in TryAutoReboot
  - From: Paul Durrant

Prev by Date: Re: [XENBUS PATCH v2 1/5] Cleanup duplicate error variables in TryAutoReboot
Next by Date: Re: [XENBUS PATCH v2 2/5] Rework autoreboot retry logic
Previous by thread: Re: [XENBUS PATCH v2 1/5] Cleanup duplicate error variables in TryAutoReboot
Next by thread: [XENBUS PATCH v2 5/5] Check for active installation before autoreboot
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.