Re: [XENBUS PATCH v2 0/5] Autoreboot rework

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 09/06/2025 15:00, Tu Dinh wrote:
> Rework and clean up reboot prompt and check logic:
> * Since autoreboot takes precedence over reboot prompts, make TryAutoReboot
>    call PromptForReboot instead of the other way around.
> * Any reboot request sets Context->RebootRequestedBy with the driver name.
> * Reboot requests can be paused by active installations, system power requests
>    or denied by the user (made explicit in the initial check).
> * Run the session prompts in a separate thread to avoid blocking main monitor.
> * Retry reboot request every minute (if exists).
>
> v2 changes:
> * Integrated Paul's feedback.
> * Reworked and reorganized the monitor code.
> * Made the retry actually work.
> * Added check for active installations.
> * Added commit to cleanup error variables in TryAutoReboot.
> v1: 
> https://lists.xenproject.org/archives/html/win-pv-devel/2025-05/msg00007.html
>
> Tu Dinh (5):
>    Cleanup duplicate error variables in TryAutoReboot
>    Rework autoreboot retry logic
>    Repeat TryAutoReboot() with timer
>    Don't autoreboot during ES_SYSTEM_REQUIRED
>    Check for active installation before autoreboot
>
>   src/monitor/monitor.c                        | 522 +++++++++++++------
>   vs2019/xenbus_monitor/xenbus_monitor.vcxproj |   2 +-
>   vs2022/xenbus_monitor/xenbus_monitor.vcxproj |   2 +-
>   3 files changed, 357 insertions(+), 169 deletions(-)
Are you planning to send a v3 without patch 1 (or with an amended patch 
1)? I can apply 2, 3, 4 and 5 as they stand but with fuzz rather than 
cleanly.