Re: [PATCH] Fix SAL annotations

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

On 07/07/2025 11:42, Owen Smith wrote:
> SyncDisableInterrupts needs to return a value to correctly identify as
> _IRQL_Saves_
> 
> ModuleLookup may return a null value in Name
> 
> LogAddDisposition may return a null value in Disposition, which leads to
> LogRemoveDisposition needing to tread Disposition as nullable
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

At first I thought using _IRQL_saves_ KIRQL SyncDisableInterrupts(VOID) 
would work but even that didn't help CA pick up the logic.

On a related note, I tried a few ways to fix the _IRQL_restores_ CodeQL 
warning but didn't find a good solution.


Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech