Re: [PATCH 1/3] registry: use RegCloseKey for RequestKey and ParametersKey

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

On 11/02/2026 11:08, Owen Smith wrote:
> CloseHandle silently fails for HKEY.
> 
> Signed-off-by: david ambu <david.preetham@xxxxxxxxx>
> 
> Refactored to before other patches
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/monitor/monitor.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
> index 1154de5..347bef0 100644
> --- a/src/monitor/monitor.c
> +++ b/src/monitor/monitor.c
> @@ -1502,7 +1502,7 @@ done:
>       free(Context->Question);
>       free(Context->Text);
>       free(Context->Title);
> -    CloseHandle(Context->RequestKey);
> +    RegCloseKey(Context->RequestKey);
>       free(RequestKeyName);
>       CloseHandle(Context->ResponseEvent);
>       CloseHandle(Context->RequestEvent);
> @@ -1512,7 +1512,7 @@ done:
>   
>       (VOID) DeregisterEventSource(Context->EventLog);
>   
> -    CloseHandle(Context->ParametersKey);
> +    RegCloseKey(Context->ParametersKey);
>       (VOID) RemoveStartOverride("stornvme");
>   
>       Log("<====");
> @@ -1530,7 +1530,7 @@ fail11:
>   fail10:
>       Log("fail10");
>   
> -    CloseHandle(Context->RequestKey);
> +    RegCloseKey(Context->RequestKey);
>   
>   fail9:
>       Log("fail9");
> @@ -1568,7 +1568,7 @@ fail3:
>   fail2:
>       Log("fail2");
>   
> -    CloseHandle(Context->ParametersKey);
> +    RegCloseKey(Context->ParametersKey);
>   
>   fail1:
>       Error = GetLastError();



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech