Xen project Mailing List

Re: [PATCH 1/2] Unplug: Set bit for NVME disk unplug

To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, Owen Smith <owen.smith@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>

From: David ambu <david.preetham@xxxxxxxxxx>

Date: Tue, 7 Apr 2026 08:31:56 +0000

Accept-language: en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HLFrJ0CamuZFkvs+4C1P4GN4Cmg0q24vBUUqEhAQGnE=; b=xZzc5WrMKlzyeOctarkudjx3aHvpbLAuJ4sJwRmVvz48jEoFta4twRr9EoV9tiOzZbwKZxvWKLIDmN7GyYT497AN7GOadf4rQvsuqXf4xvdjRZWUsP7PXuiovbUq0W1bxGQ8ZwfEq0zfcO3osxdEbgjziXyHIB9gbbqylpZ0e4cyyc0EZvAa2zXu2Sy9XrN/lsSSQtkM8259wX4S2wFCus7SeBPEEJLtsOanqsL8PXdkrVaP8eW0UFh5OGB44P9WxQ8TxQWvVFf+Hztbf81B6brQsTtoYCv81dzoePfvJlep6Qy6FU4SIL2thPpgcUk+KF3bBmYwpnqFlqDN8X+n5w==

Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hLEwvnYSN1oYqgoFKJKv0wT1ZazgOSfLxdpCTUOBY6pcM6P+t0YoljvCa5lYvrvKPBwCEsivfpqwywo/7gFz94dmmYCzcPYg3O86pAVOFhmWMxy2J0gVnF0vpTUxCtc8a7ZVmV77P50hwkziypGVziojY0De/AjB0jXN6jq9HFuOs7+iFDEg1B+J56OvyzzLmVKz/9ieG2HDxrKPkHOsawgrRUjIJxxU03TUwnd62u9Xya4w8kHdhIB2OJLuidkzrxQrjdjWTwyCVth80f1x2ZCm+Ni0YtAKOFySzf1A21f4nzwyWLZS7QRwC9/aBI6X4lmyHjiQNehfswODPcIa8w==

Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"

Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;

Delivery-date: Tue, 07 Apr 2026 13:24:18 +0000

List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Thread-index: AQHcxmc08XekXB7m6EWtklteHmg/NLXTQ9W/

Thread-topic: [PATCH 1/2] Unplug: Set bit for NVME disk unplug

Hi Tu Dinh,

Thanks for the reminder.

Just to note that Owen Smith is currently on leave due to vacation. We’ll follow up on the series once he’s back and can address the comment on patch 2.

Thanks for your patience.

Best regards,

David

From: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: Tuesday, April 7, 2026 9:19:04 AM
To: Owen Smith <owen.smith@xxxxxxxxxx>; win-pv-devel@xxxxxxxxxxxxxxxxxxxx <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>; David ambu <david.preetham@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] Unplug: Set bit for NVME disk unplug

Hello, I'd like to send a reminder for your series.

Patch 1 has received an ack and can be committed.
Patch 2 has a small comment about the removal of xenbus_monitor.dll.

Thanks,

On 06/03/2026 17:08, Owen Smith wrote:
> When issuing a DISK unplug command, set the bits for emulated IDE/SCSI
> and emulated NVME devices.
>
> Also defines and uses symbols to represent each bit in the unplug protocol.
>
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
>   src/xen/unplug.c | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/src/xen/unplug.c b/src/xen/unplug.c
> index 282ed93..3b6593a 100644
> --- a/src/xen/unplug.c
> +++ b/src/xen/unplug.c
> @@ -49,6 +49,12 @@
>
>   #define UNPLUG_TAG 'LPNU'
>
> +#define UNPLUG_FLAGS_IDE_SCSI_DISKS   0x0001
> +#define UNPLUG_FLAGS_ALL_NICS         0x0002
> +#define UNPLUG_FLAGS_AUX_IDE_DISKS    0x0004 // ignored if UNPLUG_FLAGS_IDE_SCSI_DISKS is set
> +#define UNPLUG_FLAGS_NVME_DISKS       0x0008
> +#define UNPLUG_FLAGS_ALL_DISKS        (UNPLUG_FLAGS_IDE_SCSI_DISKS | UNPLUG_FLAGS_NVME_DISKS)
> +
>   typedef struct _UNPLUG_DATA {
>       PSTR        Name;
>       BOOLEAN     Found;
> @@ -116,19 +122,19 @@ UnplugDeviceType(
>       case UNPLUG_DISKS:
>           if (Context->BootEmulated) {
>   #pragma prefast(suppress:28138)
> -            WRITE_PORT_USHORT((PUSHORT)0x10, 0x0004);
> +            WRITE_PORT_USHORT((PUSHORT)0x10, UNPLUG_FLAGS_AUX_IDE_DISKS);
>
>               LogPrintf(LOG_LEVEL_WARNING, "UNPLUG: AUX DISKS\n");
>           } else {
>   #pragma prefast(suppress:28138)
> -            WRITE_PORT_USHORT((PUSHORT)0x10, 0x0001);
> +            WRITE_PORT_USHORT((PUSHORT)0x10, UNPLUG_FLAGS_ALL_DISKS);
>
>               LogPrintf(LOG_LEVEL_WARNING, "UNPLUG: DISKS\n");
>           }
>           break;
>       case UNPLUG_NICS:
>   #pragma prefast(suppress:28138)
> -        WRITE_PORT_USHORT((PUSHORT)0x10, 0x0002);
> +        WRITE_PORT_USHORT((PUSHORT)0x10, UNPLUG_FLAGS_ALL_NICS);
>
>           LogPrintf(LOG_LEVEL_WARNING, "UNPLUG: NICS\n");
>           break;

--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech