[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/6] Use RegCloseKey for ParametersKey


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: "Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>
  • Date: Tue, 14 Apr 2026 11:44:27 +0000
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=mte1 header.d=mandrillapp.com header.i="@mandrillapp.com" header.h="From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID:Date:MIME-Version:Content-Type:Content-Transfer-Encoding"; dkim=pass header.s=mte1 header.d=vates.tech header.i="ngoc-tu.dinh@xxxxxxxxxx" header.h="From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID:Date:MIME-Version:Content-Type:Content-Transfer-Encoding"
  • Cc: "Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>, "Owen Smith" <owen.smith@xxxxxxxxxx>, "david ambu" <david.preetham@xxxxxxxxx>
  • Delivery-date: Tue, 14 Apr 2026 11:49:30 +0000
  • Feedback-id: 30504962:30504962.20260414:md
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

CloseHandle silently fails for HKEY.

Signed-off-by: david ambu <david.preetham@xxxxxxxxx>

Ported from Xenbus.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
 src/monitor/monitor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index 772bbf4..b5e042a 100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
@@ -1509,7 +1509,7 @@ MonitorMain(
 
     (VOID) DeregisterEventSource(Context->EventLog);
 
-    CloseHandle(Context->ParametersKey);
+    RegCloseKey(Context->ParametersKey);
 
     Log("<====");
 
@@ -1533,7 +1533,7 @@ fail3:
 fail2:
     Log("fail2");
 
-    CloseHandle(Context->ParametersKey);
+    RegCloseKey(Context->ParametersKey);
 
 fail1:
     Error = GetLastError();
-- 
2.53.0.windows.2



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.