[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XENBUS PATCH] Suppress quota error messages in CacheCreateSlab


  • To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Mon, 13 Jul 2026 10:08:27 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UpT4KHc4wiI+pf2PHNPtEBqUqT35+KomR3bH5lrIjiA=; b=kWUTFAd6NVQ8Hm2e5YR23FKryWJJU3qJRWpuYLc4HSbz3fWnceCThBo7XqsZL9L4JEomyLKdM07hn0FquWugDVqYfxCdFzy/p5PGfPntpzImn0RPD01ChTcONbcHfxFDrLROPSHG9qe+/HFBmu1tXCv2GHcTI/jkWXgXu4wXpL+zJYnOu1E/zsEhr2/j90iMapJncHkWRKkMZRFgOo6iu7uuXn2n+RQS9xVseM9qjqFalxrj/gc2Fp9x+Nn85rNKSPXEz9CJQp+dm5OgLEe/FLVyw3BeVGTJZIIj3i11iZ0HCQvTKsuDJ71rxjlFeaTCmiInRUwKwGjq3Uc7QiEEtg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dEHlUuvhFS6gtNR/iCMfu8NvubcICDjwZPgpLihSkdPyW30YvoyJYtbk+WGMKeMG1EiAw63KWvVoNdyo8ZwdJFYurdlxJ6ADo+aJ4QiNbGWpH4vwjqo5zvh/Py48ZptuyWi1Uz5h5rUM3nzdqS3PmF4LDk5TOdggEMi31lCwSQWL3T+duNfQRycEUPP2Dl7vtQRy+fiyLL3ITJAJYdS5qtaiIZxi1Fo97HqzjyNK79Pzm7EjlyawVbI98SW+o1vXX3L1WdNvqFdtL42k48nVlhrnOtJDI06tn/Yx+HhI83iSU8M26y2zMe82+OYFS/mRGQzB5whjEn4sd+PFakAiYg==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Delivery-date: Mon, 13 Jul 2026 10:08:34 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Msip_labels:
  • Thread-index: AQHdESvX+RIfkoBwh0myOW+ep/RFBrZrPDUd
  • Thread-topic: [XENBUS PATCH] Suppress quota error messages in CacheCreateSlab

> diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
> index e58e2f9..46201b4 100644
> --- a/src/xenbus/cache.c
> +++ b/src/xenbus/cache.c
> @@ -457,10 +457,9 @@ fail3:
>      __CacheFree(Slab);
> 
>  fail2:
> -    Error("fail2\n");
> +    Error("fail2 (%08x)\n", status);
> 
>  fail1:
> -    Error("fail1 (%08x)\n", status);

Should probably change the "Error" to "Trace", so the logging is present
in checked builds

> 
>      return status;
>  }
> --
> 2.54.0.windows.1

Owen


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.