[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 05/17] ioctl: fix annotations


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Mon, 5 Oct 2026 14:07:46 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Mon, 05 Oct 2026 12:08:04 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Buffer param is written later in IoctlLog(), IoctlStoreRead() and
IoctlStoreDirectory(). It should be annotated as _Inout_.
Corresponding signatures in header file are updated.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xeniface/ioctl_store.c | 4 ++--
 src/xeniface/ioctls.c      | 2 +-
 src/xeniface/ioctls.h      | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/xeniface/ioctl_store.c b/src/xeniface/ioctl_store.c
index 796f55d..dbe197b 100644
--- a/src/xeniface/ioctl_store.c
+++ b/src/xeniface/ioctl_store.c
@@ -113,7 +113,7 @@ DECLSPEC_NOINLINE
 NTSTATUS
 IoctlStoreRead(
     _In_ PXENIFACE_FDO  Fdo,
-    _In_ PCHAR          Buffer,
+    _Inout_ PCHAR       Buffer,
     _In_ ULONG          InLen,
     _In_ ULONG          OutLen,
     _Out_ PULONG_PTR    Info
@@ -228,7 +228,7 @@ DECLSPEC_NOINLINE
 NTSTATUS
 IoctlStoreDirectory(
     _In_ PXENIFACE_FDO  Fdo,
-    _In_ PCHAR          Buffer,
+    _Inout_ PCHAR       Buffer,
     _In_ ULONG          InLen,
     _In_ ULONG          OutLen,
     _Out_ PULONG_PTR    Info
diff --git a/src/xeniface/ioctls.c b/src/xeniface/ioctls.c
index d7d0aed..dec68d7 100644
--- a/src/xeniface/ioctls.c
+++ b/src/xeniface/ioctls.c
@@ -112,7 +112,7 @@ DECLSPEC_NOINLINE
 NTSTATUS
 IoctlLog(
     _In_ PXENIFACE_FDO  Fdo,
-    _In_ PCHAR          Buffer,
+    _Inout_ PCHAR       Buffer,
     _In_ ULONG          InLen,
     _In_ ULONG          OutLen
     )
diff --git a/src/xeniface/ioctls.h b/src/xeniface/ioctls.h
index bb5a2d3..71d74d3 100644
--- a/src/xeniface/ioctls.h
+++ b/src/xeniface/ioctls.h
@@ -118,7 +118,7 @@ DECLSPEC_NOINLINE
 NTSTATUS
 IoctlStoreRead(
     _In_ PXENIFACE_FDO  Fdo,
-    _In_ PCHAR          Buffer,
+    _Inout_ PCHAR       Buffer,
     _In_ ULONG          InLen,
     _In_ ULONG          OutLen,
     _Out_ PULONG_PTR    Info
@@ -137,7 +137,7 @@ DECLSPEC_NOINLINE
 NTSTATUS
 IoctlStoreDirectory(
     _In_ PXENIFACE_FDO  Fdo,
-    _In_ PCHAR          Buffer,
+    _Inout_ PCHAR       Buffer,
     _In_ ULONG          InLen,
     _In_ ULONG          OutLen,
     _Out_ PULONG_PTR    Info
@@ -395,7 +395,7 @@ IoctlSharedInfoGetTime(
 NTSTATUS
 IoctlLog(
     _In_ PXENIFACE_FDO  Fdo,
-    _In_ PCHAR          Buffer,
+    _Inout_ PCHAR       Buffer,
     _In_ ULONG          InLen,
     _In_ ULONG          OutLen
     );
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.