[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 15/17] include: update the annotations of shared interfaces


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Mon, 5 Oct 2026 17:59:02 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Mon, 05 Oct 2026 15:59:38 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

SharedInfoGetTime can be called with Local = Null and StoreWatchRemove
can be called with Watch = Null in wmi.c and the two functions handle these
cases in xenbus so we add _opt_ accordingly.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 include/shared_info_interface.h | 2 +-
 include/store_interface.h       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/shared_info_interface.h b/include/shared_info_interface.h
index b9b7874..37e92de 100644
--- a/include/shared_info_interface.h
+++ b/include/shared_info_interface.h
@@ -139,7 +139,7 @@ typedef VOID
 (*XENBUS_SHARED_INFO_GET_TIME)(
     _In_ PINTERFACE         Interface,
     _Out_ PLARGE_INTEGER    Time,
-    _Out_ PBOOLEAN          Local
+    _Out_opt_ PBOOLEAN      Local
     );
 
 // {7E73C34F-1640-4649-A8F3-263BC930A004}
diff --git a/include/store_interface.h b/include/store_interface.h
index 2f01674..83a76a1 100644
--- a/include/store_interface.h
+++ b/include/store_interface.h
@@ -246,8 +246,8 @@ typedef NTSTATUS
 */  
 typedef NTSTATUS
 (*XENBUS_STORE_WATCH_REMOVE)(
-    _In_ PINTERFACE             Interface,
-    _In_ PXENBUS_STORE_WATCH    Watch
+    _In_ PINTERFACE                 Interface,
+    _In_opt_ PXENBUS_STORE_WATCH    Watch
     );
 
 /*! \typedef XENBUS_STORE_POLL
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.