[PATCH 3/6] xennet: fix IN annotations

[Césaire Mounah <cesaire.mounah@xxxxxxxxxx>]

* string.c: FormatNumber only writes to Buffer, so it should be
annotated as _Out_

* adapter.c: __AdapterMultiSzToUpcaseAnsi reads and writes to Buffer param
so it should be annotated as _Inout_

* adapter.c: __AdapterMatchDistribution calls util.c::__strtork_r(buffer, ...)
that is annotated as (_Inout_opt_, _In_, _Inout_) so buffer paramater should
be annotated as _Inout_opt_.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xennet/adapter.c | 4 ++--
 src/xennet/string.c  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/xennet/adapter.c b/src/xennet/adapter.c
index ba7fd2a..9fd93d3 100644
--- a/src/xennet/adapter.c
+++ b/src/xennet/adapter.c
@@ -1542,7 +1542,7 @@ __AdapterFree(
 
 static FORCEINLINE PANSI_STRING
 __AdapterMultiSzToUpcaseAnsi(
-    _In_ PCHAR      Buffer
+    _Inout_ PCHAR   Buffer
     )
 {
     PANSI_STRING    Ansi;
@@ -1621,7 +1621,7 @@ __AdapterFreeAnsi(
 static FORCEINLINE BOOLEAN
 __AdapterMatchDistribution(
     _In_ PXENNET_ADAPTER    Adapter,
-    _In_ PCHAR              Buffer
+    _Inout_opt_ PCHAR       Buffer
     )
 {
     PCHAR                   Vendor;
diff --git a/src/xennet/string.c b/src/xennet/string.c
index b75e249..a740951 100644
--- a/src/xennet/string.c
+++ b/src/xennet/string.c
@@ -53,7 +53,7 @@ __StringPut(
 
 static PCHAR
 FormatNumber(
-    _In_ PCHAR      Buffer,
+    _Out_ PCHAR     Buffer,
     _In_ ULONGLONG  Value,
     _In_ UCHAR      Base,
     _In_ BOOLEAN    UpperCase
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech