[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/6] xennet: convert old annotations to SAL 2.0: Mechanical pass


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Mon, 5 Oct 2026 18:03:27 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Mon, 05 Oct 2026 16:03:48 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Convert to SAL 2.0 annotations

Mechanical pass, no functional change.

Annotations:
  IN/OUT/IN OUT        -> _In_/_Out_/_Inout_
  __in/__out/__inout   -> same, _opt_ variants preserved
  trailing OPTIONAL    -> folded into the annotation (_In_opt_ &c)
  _Out_ on a T **      -> _Outptr_
  __drv_*/__checkReturn-> _IRQL_requires_*/_Dispatch_type_/_Check_return_

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 include/vif_interface.h  | 158 +++++++++----------
 src/xennet/adapter.c     | 332 +++++++++++++++++++--------------------
 src/xennet/adapter.h     |  32 ++--
 src/xennet/assert.h      |  16 +-
 src/xennet/driver.c      |  20 +--
 src/xennet/driver.h      |   2 +-
 src/xennet/miniport.c    |  66 ++++----
 src/xennet/miniport.h    |   6 +-
 src/xennet/receiver.c    | 110 ++++++-------
 src/xennet/receiver.h    |  44 +++---
 src/xennet/string.c      |  28 ++--
 src/xennet/string.h      |  10 +-
 src/xennet/transmitter.c |  60 +++----
 src/xennet/transmitter.h |  22 +--
 src/xennet/util.h        |  12 +-
 15 files changed, 459 insertions(+), 459 deletions(-)

diff --git a/include/vif_interface.h b/include/vif_interface.h
index a63abba..05d472e 100644
--- a/include/vif_interface.h
+++ b/include/vif_interface.h
@@ -461,7 +461,7 @@ union _XENVIF_VIF_CALLBACK_PARAMETERS_V10 {
 */  
 typedef NTSTATUS
 (*XENVIF_VIF_ACQUIRE)(
-    IN  PINTERFACE  Interface
+    _In_ PINTERFACE Interface
     );
 
 /*! \typedef XENVIF_VIF_RELEASE
@@ -471,21 +471,21 @@ typedef NTSTATUS
 */  
 typedef VOID
 (*XENVIF_VIF_RELEASE)(
-    IN  PINTERFACE  Interface
+    _In_ PINTERFACE Interface
     );
 
 typedef VOID
 (*XENVIF_VIF_CALLBACK_V8)(
-    IN  PVOID                       Argument OPTIONAL,
-    IN  XENVIF_VIF_CALLBACK_TYPE    Type,
+    _In_opt_ PVOID                  Argument,
+    _In_ XENVIF_VIF_CALLBACK_TYPE   Type,
     ...
     );
 
 typedef VOID
 (*XENVIF_VIF_CALLBACK_V9)(
-    IN  PVOID                                       Argument OPTIONAL,
-    IN  XENVIF_VIF_CALLBACK_TYPE                    Type,
-    IN  union _XENVIF_VIF_CALLBACK_PARAMETERS_V9   *Parameters
+    _In_opt_ PVOID                                  Argument,
+    _In_ XENVIF_VIF_CALLBACK_TYPE                   Type,
+    _In_ union _XENVIF_VIF_CALLBACK_PARAMETERS_V9   *Parameters
     );
 
 typedef union _XENVIF_VIF_CALLBACK_PARAMETERS_V10 
XENVIF_VIF_CALLBACK_PARAMETERS, *PXENVIF_VIF_CALLBACK_PARAMETERS;
@@ -499,23 +499,23 @@ typedef union _XENVIF_VIF_CALLBACK_PARAMETERS_V10 
XENVIF_VIF_CALLBACK_PARAMETERS
 */
 typedef VOID
 (*XENVIF_VIF_CALLBACK)(
-    IN  PVOID                           Argument OPTIONAL,
-    IN  XENVIF_VIF_CALLBACK_TYPE        Type,
-    IN  PXENVIF_VIF_CALLBACK_PARAMETERS Parameters
+    _In_opt_ PVOID                          Argument,
+    _In_ XENVIF_VIF_CALLBACK_TYPE           Type,
+    _In_ PXENVIF_VIF_CALLBACK_PARAMETERS    Parameters
     );
 
 typedef NTSTATUS
 (*XENVIF_VIF_ENABLE_V8)(
-    IN  PINTERFACE              Interface,
-    IN  XENVIF_VIF_CALLBACK_V8  Callback,
-    IN  PVOID                   Argument OPTIONAL
+    _In_ PINTERFACE             Interface,
+    _In_ XENVIF_VIF_CALLBACK_V8 Callback,
+    _In_opt_ PVOID              Argument
     );
 
 typedef NTSTATUS
 (*XENVIF_VIF_ENABLE_V9)(
-    IN  PINTERFACE              Interface,
-    IN  XENVIF_VIF_CALLBACK_V9  Callback,
-    IN  PVOID                   Argument OPTIONAL
+    _In_ PINTERFACE             Interface,
+    _In_ XENVIF_VIF_CALLBACK_V9 Callback,
+    _In_opt_ PVOID              Argument
     );
 
 /*! \typedef XENVIF_VIF_ENABLE
@@ -530,9 +530,9 @@ typedef NTSTATUS
 */
 typedef NTSTATUS
 (*XENVIF_VIF_ENABLE)(
-    IN  PINTERFACE          Interface,
-    IN  XENVIF_VIF_CALLBACK Callback,
-    IN  PVOID               Argument OPTIONAL
+    _In_ PINTERFACE             Interface,
+    _In_ XENVIF_VIF_CALLBACK    Callback,
+    _In_opt_ PVOID              Argument
     );
 
 /*! \typedef XENVIF_VIF_DISABLE
@@ -545,7 +545,7 @@ typedef NTSTATUS
 */
 typedef VOID
 (*XENVIF_VIF_DISABLE)(
-    IN  PINTERFACE  Interface
+    _In_ PINTERFACE Interface
     );
 
 /*! \typedef XENVIF_VIF_QUERY_STATISTIC
@@ -562,9 +562,9 @@ typedef VOID
 */
 typedef NTSTATUS
 (*XENVIF_VIF_QUERY_STATISTIC)(
-    IN  PINTERFACE              Interface,
-    IN  XENVIF_VIF_STATISTIC    Index,
-    OUT PULONGLONG              Value
+    _In_ PINTERFACE             Interface,
+    _In_ XENVIF_VIF_STATISTIC   Index,
+    _Out_ PULONGLONG            Value
     );
 
 /*! \typedef XENVIF_VIF_QUERY_RING_COUNT
@@ -576,8 +576,8 @@ typedef NTSTATUS
 */
 typedef VOID
 (*XENVIF_VIF_QUERY_RING_COUNT)(
-    IN  PINTERFACE  Interface,
-    OUT PULONG      Count
+    _In_ PINTERFACE Interface,
+    _Out_ PULONG    Count
     );
 
 /*! \typedef XENVIF_VIF_UPDATE_HASH_MAPPING
@@ -591,9 +591,9 @@ typedef VOID
 */
 typedef NTSTATUS
 (*XENVIF_VIF_UPDATE_HASH_MAPPING)(
-    IN  PINTERFACE          Interface,
-    IN  PPROCESSOR_NUMBER   Mapping,
-    IN  ULONG               Size
+    _In_ PINTERFACE         Interface,
+    _In_ PPROCESSOR_NUMBER  Mapping,
+    _In_ ULONG              Size
     );
 
 /*! \typedef XENVIF_VIF_RECEIVER_RETURN_PACKET
@@ -605,8 +605,8 @@ typedef NTSTATUS
 */
 typedef VOID
 (*XENVIF_VIF_RECEIVER_RETURN_PACKET)(
-    IN  PINTERFACE  Interface,
-    IN  PVOID       Cookie
+    _In_ PINTERFACE Interface,
+    _In_ PVOID      Cookie
     );
 
 /*! \typedef XENVIF_VIF_TRANSMITTER_QUEUE_PACKET
@@ -625,16 +625,16 @@ typedef VOID
 */
 typedef NTSTATUS
 (*XENVIF_VIF_TRANSMITTER_QUEUE_PACKET)(
-    IN  PINTERFACE                  Interface,
-    IN  PMDL                        Mdl,
-    IN  ULONG                       Offset,
-    IN  ULONG                       Length,
-    IN  XENVIF_VIF_OFFLOAD_OPTIONS  OffloadOptions,
-    IN  USHORT                      MaximumSegmentSize,
-    IN  USHORT                      TagControlInformation,
-    IN  PXENVIF_PACKET_HASH         Hash,
-    IN  BOOLEAN                     More,
-    IN  PVOID                       Cookie
+    _In_ PINTERFACE                 Interface,
+    _In_ PMDL                       Mdl,
+    _In_ ULONG                      Offset,
+    _In_ ULONG                      Length,
+    _In_ XENVIF_VIF_OFFLOAD_OPTIONS OffloadOptions,
+    _In_ USHORT                     MaximumSegmentSize,
+    _In_ USHORT                     TagControlInformation,
+    _In_ PXENVIF_PACKET_HASH        Hash,
+    _In_ BOOLEAN                    More,
+    _In_ PVOID                      Cookie
     );
 
 /*! \typedef XENVIF_VIF_TRANSMITTER_QUERY_OFFLOAD_OPTIONS
@@ -646,8 +646,8 @@ typedef NTSTATUS
 */
 typedef VOID
 (*XENVIF_VIF_TRANSMITTER_QUERY_OFFLOAD_OPTIONS)(
-    IN  PINTERFACE                  Interface,
-    OUT PXENVIF_VIF_OFFLOAD_OPTIONS Options
+    _In_ PINTERFACE                     Interface,
+    _Out_ PXENVIF_VIF_OFFLOAD_OPTIONS   Options
     );
 
 /*! \typedef XENVIF_VIF_RECEIVER_SET_OFFLOAD_OPTIONS
@@ -659,8 +659,8 @@ typedef VOID
 */
 typedef VOID
 (*XENVIF_VIF_RECEIVER_SET_OFFLOAD_OPTIONS)(
-    IN  PINTERFACE                  Interface,
-    IN  XENVIF_VIF_OFFLOAD_OPTIONS  Options
+    _In_ PINTERFACE                 Interface,
+    _In_ XENVIF_VIF_OFFLOAD_OPTIONS Options
     );
 
 /*! \typedef XENVIF_VIF_RECEIVER_SET_BACKFILL_SIZE
@@ -672,8 +672,8 @@ typedef VOID
 */
 typedef VOID
 (*XENVIF_VIF_RECEIVER_SET_BACKFILL_SIZE)(
-    IN  PINTERFACE  Interface,
-    IN  ULONG       Size
+    _In_ PINTERFACE Interface,
+    _In_ ULONG      Size
     );
 
 /*! \typedef XENVIF_VIF_TRANSMITTER_QUERY_LARGE_PACKET_SIZE
@@ -686,9 +686,9 @@ typedef VOID
 */ 
 typedef VOID
 (*XENVIF_VIF_TRANSMITTER_QUERY_LARGE_PACKET_SIZE)(
-    IN  PINTERFACE  Interface,
-    IN  UCHAR       Version,
-    OUT PULONG      Size
+    _In_ PINTERFACE Interface,
+    _In_ UCHAR      Version,
+    _Out_ PULONG    Size
     );
 
 /*! \typedef XENVIF_VIF_TRANSMITTER_QUERY_RING_SIZE
@@ -700,8 +700,8 @@ typedef VOID
 */
 typedef VOID
 (*XENVIF_VIF_TRANSMITTER_QUERY_RING_SIZE)(
-    IN  PINTERFACE  Interface,
-    OUT PULONG      Size
+    _In_ PINTERFACE Interface,
+    _Out_ PULONG    Size
     );
 
 /*! \typedef XENVIF_VIF_RECEIVER_QUERY_RING_SIZE
@@ -713,8 +713,8 @@ typedef VOID
 */
 typedef VOID
 (*XENVIF_VIF_RECEIVER_QUERY_RING_SIZE)(
-    IN  PINTERFACE  Interface,
-    OUT PULONG      Size
+    _In_ PINTERFACE Interface,
+    _Out_ PULONG    Size
     );
 
 /*! \typedef XENVIF_VIF_RECEIVER_SET_HASH_ALGORITHM
@@ -726,8 +726,8 @@ typedef VOID
 */
 typedef NTSTATUS
 (*XENVIF_VIF_RECEIVER_SET_HASH_ALGORITHM)(
-    IN  PINTERFACE                      Interface,
-    IN  XENVIF_PACKET_HASH_ALGORITHM    Algorithm
+    _In_ PINTERFACE                     Interface,
+    _In_ XENVIF_PACKET_HASH_ALGORITHM   Algorithm
     );
 
 /*! \typedef XENVIF_VIF_RECEIVER_QUERY_HASH_CAPABILITIES
@@ -741,7 +741,7 @@ typedef NTSTATUS
 */
 typedef NTSTATUS
 (*XENVIF_VIF_RECEIVER_QUERY_HASH_CAPABILITIES)(
-    IN  PINTERFACE  Interface,
+    _In_ PINTERFACE Interface,
     ...
     );
 
@@ -757,7 +757,7 @@ typedef NTSTATUS
 */
 typedef NTSTATUS
 (*XENVIF_VIF_RECEIVER_UPDATE_HASH_PARAMETERS)(
-    IN  PINTERFACE  Interface,
+    _In_ PINTERFACE Interface,
     ...
     );
 
@@ -773,10 +773,10 @@ typedef NTSTATUS
 */
 typedef VOID
 (*XENVIF_VIF_MAC_QUERY_STATE)(
-    IN  PINTERFACE                  Interface,
-    OUT PNET_IF_MEDIA_CONNECT_STATE MediaConnectState OPTIONAL,
-    OUT PULONG64                    LinkSpeed OPTIONAL,
-    OUT PNET_IF_MEDIA_DUPLEX_STATE  MediaDuplexState OPTIONAL
+    _In_ PINTERFACE                         Interface,
+    _Out_opt_ PNET_IF_MEDIA_CONNECT_STATE   MediaConnectState,
+    _Out_opt_ PULONG64                      LinkSpeed,
+    _Out_opt_ PNET_IF_MEDIA_DUPLEX_STATE    MediaDuplexState
     );
 
 /*! \typedef XENVIF_VIF_MAC_QUERY_MAXIMUM_FRAME_SIZE
@@ -788,8 +788,8 @@ typedef VOID
 */
 typedef VOID
 (*XENVIF_VIF_MAC_QUERY_MAXIMUM_FRAME_SIZE)(
-    IN  PINTERFACE  Interface,
-    OUT PULONG      Size
+    _In_ PINTERFACE Interface,
+    _Out_ PULONG    Size
     );
 
 /*! \typedef XENVIF_VIF_MAC_QUERY_PERMANENT_ADDRESS
@@ -800,8 +800,8 @@ typedef VOID
 */
 typedef VOID
 (*XENVIF_VIF_MAC_QUERY_PERMANENT_ADDRESS)(
-    IN  PINTERFACE          Interface,
-    OUT PETHERNET_ADDRESS   Address
+    _In_ PINTERFACE         Interface,
+    _Out_ PETHERNET_ADDRESS Address
     );
 
 /*! \typedef XENVIF_VIF_MAC_QUERY_CURRENT_ADDRESS
@@ -816,8 +816,8 @@ typedef VOID
 */
 typedef VOID
 (*XENVIF_VIF_MAC_QUERY_CURRENT_ADDRESS)(
-    IN  PINTERFACE          Interface,
-    OUT PETHERNET_ADDRESS   Address
+    _In_ PINTERFACE         Interface,
+    _Out_ PETHERNET_ADDRESS Address
     );
 
 /*! \typedef XENVIF_VIF_MAC_QUERY_MULTICAST_ADDRESSES
@@ -833,9 +833,9 @@ typedef VOID
 */
 typedef NTSTATUS
 (*XENVIF_VIF_MAC_QUERY_MULTICAST_ADDRESSES)(
-    IN      PINTERFACE          Interface,
-    OUT     PETHERNET_ADDRESS   Address OPTIONAL,
-    IN OUT  PULONG              Count
+    _In_ PINTERFACE             Interface,
+    _Out_opt_ PETHERNET_ADDRESS Address,
+    _Inout_ PULONG              Count
     );
 
 /*! \typedef XENVIF_VIF_MAC_SET_MULTICAST_ADDRESSES
@@ -850,9 +850,9 @@ typedef NTSTATUS
 */
 typedef NTSTATUS
 (*XENVIF_VIF_MAC_SET_MULTICAST_ADDRESSES)(
-    IN  PINTERFACE          Interface,
-    IN  PETHERNET_ADDRESS   Address OPTIONAL,
-    IN  ULONG               Count
+    _In_ PINTERFACE             Interface,
+    _In_opt_ PETHERNET_ADDRESS  Address,
+    _In_ ULONG                  Count
     );
 
 /*! \typedef XENVIF_VIF_MAC_SET_FILTER_LEVEL
@@ -865,9 +865,9 @@ typedef NTSTATUS
 */
 typedef NTSTATUS
 (*XENVIF_VIF_MAC_SET_FILTER_LEVEL)(
-    IN  PINTERFACE              Interface,
-    IN  ETHERNET_ADDRESS_TYPE   Type,
-    IN  XENVIF_MAC_FILTER_LEVEL Level
+    _In_ PINTERFACE                 Interface,
+    _In_ ETHERNET_ADDRESS_TYPE      Type,
+    _In_ XENVIF_MAC_FILTER_LEVEL    Level
     );
 
 /*! \typedef XENVIF_VIF_MAC_QUERY_FILTER_LEVEL
@@ -880,9 +880,9 @@ typedef NTSTATUS
 */
 typedef NTSTATUS
 (*XENVIF_VIF_MAC_QUERY_FILTER_LEVEL)(
-    IN  PINTERFACE                  Interface,
-    IN  ETHERNET_ADDRESS_TYPE       Type,
-    OUT PXENVIF_MAC_FILTER_LEVEL    Level
+    _In_ PINTERFACE                 Interface,
+    _In_ ETHERNET_ADDRESS_TYPE      Type,
+    _Out_ PXENVIF_MAC_FILTER_LEVEL  Level
     );
 
 // {76F279CD-CA11-418B-92E8-C57F77DE0E2E}
diff --git a/src/xennet/adapter.c b/src/xennet/adapter.c
index 6e5a95a..ba7fd2a 100644
--- a/src/xennet/adapter.c
+++ b/src/xennet/adapter.c
@@ -163,13 +163,13 @@ static NDIS_OID XennetSupportedOids[] =
 
 #define ADAPTER_POOL_TAG    'AteN'
 
-__drv_functionClass(MINIPORT_PROCESS_SG_LIST)
+_Function_class_(MINIPORT_PROCESS_SG_LIST)
 static VOID
 AdapterProcessSGList(
-    IN PDEVICE_OBJECT       DeviceObject,
-    IN PVOID                Reserved,
-    IN PSCATTER_GATHER_LIST SGL,
-    IN PVOID                Context
+    _In_ PDEVICE_OBJECT         DeviceObject,
+    _In_ PVOID                  Reserved,
+    _In_ PSCATTER_GATHER_LIST   SGL,
+    _In_ PVOID                  Context
     )
 {
     UNREFERENCED_PARAMETER(DeviceObject);
@@ -180,14 +180,14 @@ AdapterProcessSGList(
     ASSERT(FALSE);
 }
 
-__drv_functionClass(MINIPORT_ALLOCATE_SHARED_MEM_COMPLETE)
+_Function_class_(MINIPORT_ALLOCATE_SHARED_MEM_COMPLETE)
 static VOID
 AdapterAllocateComplete (
-    IN NDIS_HANDLE              MiniportAdapterContext,
-    IN PVOID                    VirtualAddress,
-    IN PNDIS_PHYSICAL_ADDRESS   PhysicalAddress,
-    IN ULONG                    Length,
-    IN PVOID                    Context
+    _In_ NDIS_HANDLE            MiniportAdapterContext,
+    _In_ PVOID                  VirtualAddress,
+    _In_ PNDIS_PHYSICAL_ADDRESS PhysicalAddress,
+    _In_ ULONG                  Length,
+    _In_ PVOID                  Context
     )
 {
     UNREFERENCED_PARAMETER(MiniportAdapterContext);
@@ -201,12 +201,12 @@ AdapterAllocateComplete (
 
 static VOID
 AdapterVifCallback(
-    IN  PVOID                           Context,
-    IN  XENVIF_VIF_CALLBACK_TYPE        Type,
-    IN  PXENVIF_VIF_CALLBACK_PARAMETERS Parameters
+    _In_ PVOID                              Context,
+    _In_ XENVIF_VIF_CALLBACK_TYPE           Type,
+    _In_ PXENVIF_VIF_CALLBACK_PARAMETERS    Parameters
     )
 {
-    PXENNET_ADAPTER                     Adapter = Context;
+    PXENNET_ADAPTER                         Adapter = Context;
 
     switch (Type) {
     case XENVIF_TRANSMITTER_RETURN_PACKET:
@@ -239,8 +239,8 @@ AdapterVifCallback(
 
 static VOID
 DisplayOffload(
-    IN  const CHAR      *Type,
-    IN  PNDIS_OFFLOAD   Offload
+    _In_ const CHAR     *Type,
+    _In_ PNDIS_OFFLOAD  Offload
     )
 {
     Trace("%s:\n", Type);
@@ -313,7 +313,7 @@ DisplayOffload(
 
 static VOID
 AdapterIndicateOffloadChanged(
-    IN  PXENNET_ADAPTER         Adapter
+    _In_ PXENNET_ADAPTER        Adapter
     )
 {
     NDIS_STATUS_INDICATION      Status;
@@ -441,8 +441,8 @@ AdapterIndicateOffloadChanged(
 
 static VOID
 AdapterGetPacketFilter(
-    IN  PXENNET_ADAPTER         Adapter,
-    OUT PULONG                  PacketFilter
+    _In_ PXENNET_ADAPTER    Adapter,
+    _Out_ PULONG            PacketFilter
     )
 {
     XENVIF_MAC_FILTER_LEVEL UnicastFilterLevel;
@@ -487,8 +487,8 @@ AdapterGetPacketFilter(
 
 static NDIS_STATUS
 AdapterSetPacketFilter(
-    IN  PXENNET_ADAPTER         Adapter,
-    IN  PULONG                  PacketFilter
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PULONG             PacketFilter
     )
 {
     XENVIF_MAC_FILTER_LEVEL UnicastFilterLevel;
@@ -543,13 +543,13 @@ done:
 
 static NDIS_STATUS
 AdapterGetOffloadEncapsulation(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PNDIS_OFFLOAD_ENCAPSULATION Offload
+    _In_ PXENNET_ADAPTER                Adapter,
+    _In_ PNDIS_OFFLOAD_ENCAPSULATION    Offload
     )
 {
-    XENVIF_VIF_OFFLOAD_OPTIONS  Options;
-    PXENVIF_VIF_OFFLOAD_OPTIONS TxOptions;
-    PXENVIF_VIF_OFFLOAD_OPTIONS RxOptions;
+    XENVIF_VIF_OFFLOAD_OPTIONS          Options;
+    PXENVIF_VIF_OFFLOAD_OPTIONS         TxOptions;
+    PXENVIF_VIF_OFFLOAD_OPTIONS         RxOptions;
 
     if (Offload->IPv4.Enabled == NDIS_OFFLOAD_SET_ON &&
         Offload->IPv4.EncapsulationType != NDIS_ENCAPSULATION_IEEE_802_3)
@@ -624,8 +624,8 @@ invalid_parameter:
 
 static NDIS_STATUS
 AdapterGetTcpOffloadParameters(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PNDIS_OFFLOAD_PARAMETERS    Offload
+    _In_ PXENNET_ADAPTER            Adapter,
+    _In_ PNDIS_OFFLOAD_PARAMETERS   Offload
     )
 {
     XENVIF_VIF_OFFLOAD_OPTIONS      Options;
@@ -698,7 +698,7 @@ invalid_parameter:
 
 static VOID
 AdapterDisableRSSHash(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     Adapter->Rss.ScaleEnabled = FALSE;
@@ -711,9 +711,9 @@ AdapterDisableRSSHash(
 
 static NDIS_STATUS
 AdapterUpdateRSSTable(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PPROCESSOR_NUMBER   Table,
-    IN  ULONG               TableSize
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PPROCESSOR_NUMBER  Table,
+    _In_ ULONG              TableSize
     )
 {
     NTSTATUS                status;
@@ -740,12 +740,12 @@ AdapterUpdateRSSTable(
 
 static NDIS_STATUS
 AdapterUpdateRSSKey(
-    IN  PXENNET_ADAPTER Adapter,
-    IN  PUCHAR          Key,
-    IN  ULONG           KeySize
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PUCHAR             Key,
+    _In_ ULONG              KeySize
     )
 {
-    NTSTATUS            status;
+    NTSTATUS                status;
 
     if (KeySize == 0) {
         AdapterDisableRSSHash(Adapter);
@@ -769,13 +769,13 @@ AdapterUpdateRSSKey(
 
 static NDIS_STATUS
 AdapterUpdateRSSHash(
-    IN  PXENNET_ADAPTER Adapter,
-    IN  ULONG           Information
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ ULONG              Information
     )
 {
-    ULONG               HashType = 
NDIS_RSS_HASH_TYPE_FROM_HASH_INFO(Information);
-    ULONG               HashFunc = 
NDIS_RSS_HASH_FUNC_FROM_HASH_INFO(Information);
-    NTSTATUS            status;
+    ULONG                   HashType = 
NDIS_RSS_HASH_TYPE_FROM_HASH_INFO(Information);
+    ULONG                   HashFunc = 
NDIS_RSS_HASH_FUNC_FROM_HASH_INFO(Information);
+    NTSTATUS                status;
 
     if (HashFunc == 0) {
         AdapterDisableRSSHash(Adapter);
@@ -824,7 +824,7 @@ AdapterUpdateRSSHash(
 
 static VOID
 DisplayRss(
-    IN  PXENNET_RSS Rss
+    _In_ PXENNET_RSS    Rss
     )
 {
     Trace("HashEnabled: %s\n", (Rss->HashEnabled) ? "TRUE" : "FALSE");
@@ -926,9 +926,9 @@ DisplayRss(
 
 static NDIS_STATUS
 AdapterGetReceiveScaleParameters(
-    IN  PXENNET_ADAPTER                 Adapter,
-    IN  PNDIS_RECEIVE_SCALE_PARAMETERS  Parameters,
-    OUT PULONG                          BytesRead
+    _In_ PXENNET_ADAPTER                Adapter,
+    _In_ PNDIS_RECEIVE_SCALE_PARAMETERS Parameters,
+    _Out_ PULONG                        BytesRead
     )
 {
     NDIS_STATUS                         ndisStatus;
@@ -999,8 +999,8 @@ fail:
 
 static NDIS_STATUS
 AdapterGetReceiveHashParameters(
-    IN  PXENNET_ADAPTER                 Adapter,
-    IN  PNDIS_RECEIVE_HASH_PARAMETERS   Parameters
+    _In_ PXENNET_ADAPTER                Adapter,
+    _In_ PNDIS_RECEIVE_HASH_PARAMETERS  Parameters
     )
 {
     NDIS_STATUS                         ndisStatus;
@@ -1047,13 +1047,13 @@ fail:
 
 static NDIS_STATUS
 AdapterQueryGeneralStatistics(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PNDIS_STATISTICS_INFO   Info,
-    IN  ULONG               BufferLength,
-    IN OUT PULONG           BytesWritten
+    _In_ PXENNET_ADAPTER        Adapter,
+    _In_ PNDIS_STATISTICS_INFO  Info,
+    _In_ ULONG                  BufferLength,
+    _Inout_ PULONG              BytesWritten
     )
 {
-    ULONGLONG   Value;
+    ULONGLONG                   Value;
 
     if (BufferLength < sizeof(NDIS_STATISTICS_INFO))
         goto fail1;
@@ -1225,16 +1225,16 @@ fail1:
 
 static NDIS_STATUS
 AdapterQueryMulticastList(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PVOID               Buffer,
-    IN  ULONG               BufferLength,
-    IN OUT PULONG           BytesNeeded,
-    IN OUT PULONG           BytesWritten
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PVOID              Buffer,
+    _In_ ULONG              BufferLength,
+    _Inout_ PULONG          BytesNeeded,
+    _Inout_ PULONG          BytesWritten
     )
 {
-    ULONG       Count;
-    NDIS_STATUS ndisStatus;
-    NTSTATUS    status;
+    ULONG                   Count;
+    NDIS_STATUS             ndisStatus;
+    NTSTATUS                status;
 
     XENVIF_VIF(MacQueryMulticastAddresses,
                &Adapter->VifInterface,
@@ -1265,12 +1265,12 @@ fail1:
 
 static FORCEINLINE NDIS_STATUS
 AdapterSetMulticastAddresses(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PETHERNET_ADDRESS   Address,
-    IN  ULONG               Count
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PETHERNET_ADDRESS  Address,
+    _In_ ULONG              Count
     )
 {
-    NTSTATUS        status;
+    NTSTATUS                status;
 
     status = XENVIF_VIF(MacSetMulticastAddresses,
                         &Adapter->VifInterface,
@@ -1284,11 +1284,11 @@ AdapterSetMulticastAddresses(
 
 static FORCEINLINE VOID
 AdapterGetXmitOk(
-    IN  PXENNET_ADAPTER     Adapter,
-    OUT PULONGLONG          Buffer
+    _In_ PXENNET_ADAPTER    Adapter,
+    _Out_ PULONGLONG        Buffer
     )
 {
-    ULONGLONG   Value;
+    ULONGLONG               Value;
 
     XENVIF_VIF(QueryStatistic,
                 &Adapter->VifInterface,
@@ -1314,11 +1314,11 @@ AdapterGetXmitOk(
 
 static FORCEINLINE VOID
 AdapterGetRcvOk(
-    IN  PXENNET_ADAPTER     Adapter,
-    OUT PULONGLONG          Buffer
+    _In_ PXENNET_ADAPTER    Adapter,
+    _Out_ PULONGLONG        Buffer
     )
 {
-    ULONGLONG   Value;
+    ULONGLONG               Value;
 
     XENVIF_VIF(QueryStatistic,
                 &Adapter->VifInterface,
@@ -1344,11 +1344,11 @@ AdapterGetRcvOk(
 
 static NDIS_STATUS
 AdapterGetXmitError(
-    IN  PXENNET_ADAPTER     Adapter,
-    OUT PULONG              Buffer
+    _In_ PXENNET_ADAPTER    Adapter,
+    _Out_ PULONG            Buffer
     )
 {
-    ULONGLONG   Value;
+    ULONGLONG               Value;
 
     XENVIF_VIF(QueryStatistic,
                 &Adapter->VifInterface,
@@ -1369,11 +1369,11 @@ AdapterGetXmitError(
 
 static FORCEINLINE NDIS_STATUS
 AdapterGetRcvError(
-    IN  PXENNET_ADAPTER     Adapter,
-    OUT PULONG              Buffer
+    _In_ PXENNET_ADAPTER    Adapter,
+    _Out_ PULONG            Buffer
     )
 {
-    ULONGLONG   Value;
+    ULONGLONG               Value;
 
     XENVIF_VIF(QueryStatistic,
                 &Adapter->VifInterface,
@@ -1394,10 +1394,10 @@ AdapterGetRcvError(
 
 static FORCEINLINE NDIS_STATUS
 AdapterInterruptModeration(
-    IN  PXENNET_ADAPTER                         Adapter,
-    IN  PNDIS_INTERRUPT_MODERATION_PARAMETERS   Params,
-    IN  ULONG                                   BufferLength,
-    IN OUT PULONG                               BytesWritten
+    _In_ PXENNET_ADAPTER                        Adapter,
+    _In_ PNDIS_INTERRUPT_MODERATION_PARAMETERS  Params,
+    _In_ ULONG                                  BufferLength,
+    _Inout_ PULONG                              BytesWritten
     )
 {
     UNREFERENCED_PARAMETER(Adapter);
@@ -1422,10 +1422,10 @@ fail1:
 
 static FORCEINLINE NDIS_STATUS
 AdapterReceiveHash(
-    IN  PXENNET_ADAPTER                 Adapter,
-    IN  PNDIS_RECEIVE_HASH_PARAMETERS   Params,
-    IN  ULONG                           BufferLength,
-    IN OUT PULONG                       BytesWritten
+    _In_ PXENNET_ADAPTER                Adapter,
+    _In_ PNDIS_RECEIVE_HASH_PARAMETERS  Params,
+    _In_ ULONG                          BufferLength,
+    _Inout_ PULONG                      BytesWritten
     )
 {
     ULONG                               HashType;
@@ -1475,7 +1475,7 @@ fail1:
 
 NDIS_HANDLE
 AdapterGetHandle(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     return Adapter->NdisAdapterHandle;
@@ -1483,10 +1483,10 @@ AdapterGetHandle(
 
 ULONG
 AdapterGetNblMaxBatchSize(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
-    ULONG val = (ULONG)Adapter->Properties.nblbatchmax;
+    ULONG                   val = (ULONG)Adapter->Properties.nblbatchmax;
     if (val == 0 || val > NBL_BATCH_SIZE_MAX)
         return NBL_BATCH_SIZE_DEFAULT;
     return val;
@@ -1494,7 +1494,7 @@ AdapterGetNblMaxBatchSize(
 
 PXENVIF_VIF_INTERFACE
 AdapterGetVifInterface(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     return &Adapter->VifInterface;
@@ -1502,7 +1502,7 @@ AdapterGetVifInterface(
 
 PXENNET_TRANSMITTER
 AdapterGetTransmitter(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     return Adapter->Transmitter;
@@ -1510,7 +1510,7 @@ AdapterGetTransmitter(
 
 PXENNET_RECEIVER
 AdapterGetReceiver(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     return Adapter->Receiver;
@@ -1518,7 +1518,7 @@ AdapterGetReceiver(
 
 PWCHAR
 AdapterGetLocation(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     return Adapter->Location;
@@ -1526,7 +1526,7 @@ AdapterGetLocation(
 
 static FORCEINLINE PVOID
 __AdapterAllocate(
-    IN  ULONG   Length
+    _In_ ULONG  Length
     )
 {
     return __AllocatePoolWithTag(NonPagedPool, Length, ADAPTER_POOL_TAG);
@@ -1534,7 +1534,7 @@ __AdapterAllocate(
 
 static FORCEINLINE VOID
 __AdapterFree(
-    IN  PVOID   Buffer
+    _In_ PVOID  Buffer
     )
 {
     __FreePoolWithTag(Buffer, ADAPTER_POOL_TAG);
@@ -1542,7 +1542,7 @@ __AdapterFree(
 
 static FORCEINLINE PANSI_STRING
 __AdapterMultiSzToUpcaseAnsi(
-    IN  PCHAR       Buffer
+    _In_ PCHAR      Buffer
     )
 {
     PANSI_STRING    Ansi;
@@ -1607,7 +1607,7 @@ fail1:
 
 static FORCEINLINE VOID
 __AdapterFreeAnsi(
-    IN  PANSI_STRING    Ansi
+    _In_ PANSI_STRING   Ansi
     )
 {
     ULONG               Index;
@@ -1620,17 +1620,17 @@ __AdapterFreeAnsi(
 
 static FORCEINLINE BOOLEAN
 __AdapterMatchDistribution(
-    IN  PXENNET_ADAPTER Adapter,
-    IN  PCHAR           Buffer
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PCHAR              Buffer
     )
 {
-    PCHAR               Vendor;
-    PCHAR               Product;
-    PCHAR               Context;
-    const CHAR          *Text;
-    BOOLEAN             Match;
-    ULONG               Index;
-    NTSTATUS            status;
+    PCHAR                   Vendor;
+    PCHAR                   Product;
+    PCHAR                   Context;
+    const CHAR              *Text;
+    BOOLEAN                 Match;
+    ULONG                   Index;
+    NTSTATUS                status;
 
     UNREFERENCED_PARAMETER(Adapter);
 
@@ -1680,13 +1680,13 @@ fail1:
 
 static FORCEINLINE VOID
 __AdapterClearDistribution(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
-    PCHAR               Buffer;
-    PANSI_STRING        Distributions;
-    ULONG               Index;
-    NTSTATUS            status;
+    PCHAR                   Buffer;
+    PANSI_STRING            Distributions;
+    ULONG                   Index;
+    NTSTATUS                status;
 
     Trace("====>\n");
 
@@ -1743,15 +1743,15 @@ done:
 
 static FORCEINLINE NTSTATUS
 __AdapterSetDistribution(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
-    ULONG               Index;
-    CHAR                Distribution[MAXNAMELEN];
-    CHAR                Vendor[MAXNAMELEN];
-    STRING              String;
-    const CHAR          *Product;
-    NTSTATUS            status;
+    ULONG                   Index;
+    CHAR                    Distribution[MAXNAMELEN];
+    CHAR                    Vendor[MAXNAMELEN];
+    STRING                  String;
+    const CHAR              *Product;
+    NTSTATUS                status;
 
     Trace("====>\n");
 
@@ -1844,7 +1844,7 @@ fail1:
 
 static DECLSPEC_NOINLINE VOID
 AdapterSuspendCallbackLate(
-    IN  PVOID       Argument
+    _In_ PVOID      Argument
     )
 {
     PXENNET_ADAPTER Adapter = Argument;
@@ -1861,11 +1861,11 @@ AdapterSuspendCallbackLate(
 
 static NTSTATUS
 AdapterSetDistribution(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
-    LONG                Count;
-    NTSTATUS            status;
+    LONG                    Count;
+    NTSTATUS                status;
 
     Trace("====>\n");
 
@@ -1900,10 +1900,10 @@ fail1:
 
 static VOID
 AdapterClearDistribution(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
-    LONG                Count;
+    LONG                    Count;
 
     Trace("====>\n");
 
@@ -1922,7 +1922,7 @@ AdapterClearDistribution(
 
 NDIS_STATUS
 AdapterEnable(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     NTSTATUS                status;
@@ -1973,7 +1973,7 @@ fail1:
 
 VOID
 AdapterDisable(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     if (!Adapter->Enabled)
@@ -1995,8 +1995,8 @@ AdapterDisable(
 
 static VOID
 DisplayLinkState(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PNDIS_LINK_STATE    LinkState
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PNDIS_LINK_STATE   LinkState
     )
 {
     if (LinkState->MediaConnectState == MediaConnectStateUnknown) {
@@ -2021,7 +2021,7 @@ DisplayLinkState(
 
 VOID
 AdapterMediaStateChange(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     NDIS_LINK_STATE         LinkState;
@@ -2062,8 +2062,8 @@ AdapterMediaStateChange(
 
 NDIS_STATUS
 AdapterSetInformation(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PNDIS_OID_REQUEST   Request
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PNDIS_OID_REQUEST  Request
     )
 {
     PVOID                   Buffer;
@@ -2216,11 +2216,11 @@ AdapterSetInformation(
 
 static FORCEINLINE NDIS_STATUS
 __CopyBuffer(
-    IN  PVOID   Destination,
-    IN  ULONG   DestinationLength,
-    IN  PVOID   Source,
-    IN  ULONG   SourceLength,
-    OUT PULONG  CopyLength
+    _In_ PVOID      Destination,
+    _In_ ULONG      DestinationLength,
+    _In_ PVOID      Source,
+    _In_ ULONG      SourceLength,
+    _Out_ PULONG    CopyLength
     )
 {
     *CopyLength = __min(SourceLength, DestinationLength);
@@ -2233,10 +2233,10 @@ __CopyBuffer(
 
 static FORCEINLINE NDIS_STATUS
 __SetUlong(
-    IN  PVOID   Destination,
-    IN  ULONG   DestinationLength,
-    IN  ULONG   Source,
-    OUT PULONG  CopyLength
+    _In_ PVOID      Destination,
+    _In_ ULONG      DestinationLength,
+    _In_ ULONG      Source,
+    _Out_ PULONG    CopyLength
     )
 {
     return __CopyBuffer(Destination,
@@ -2248,13 +2248,13 @@ __SetUlong(
 
 static FORCEINLINE NDIS_STATUS
 __SetUlong64(
-    IN  PVOID   Destination,
-    IN  ULONG   DestinationLength,
-    IN  ULONG64 Source,
-    OUT PULONG  CopyLength
+    _In_ PVOID      Destination,
+    _In_ ULONG      DestinationLength,
+    _In_ ULONG64    Source,
+    _Out_ PULONG    CopyLength
     )
 {
-    NDIS_STATUS ndisStatus;
+    NDIS_STATUS     ndisStatus;
 
     ndisStatus =  __CopyBuffer(Destination,
                                DestinationLength & ~3,
@@ -2269,8 +2269,8 @@ __SetUlong64(
 
 NDIS_STATUS
 AdapterQueryInformation(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PNDIS_OID_REQUEST   Request
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PNDIS_OID_REQUEST  Request
     )
 {
     PVOID                   Buffer;
@@ -2777,15 +2777,15 @@ AdapterQueryInformation(
     return ndisStatus;
 }
 
-__drv_requiresIRQL(PASSIVE_LEVEL)
+_IRQL_requires_(PASSIVE_LEVEL)
 static NTSTATUS
 __QueryInterface(
-    IN  PDEVICE_OBJECT  DeviceObject,
-    IN  const GUID      *Guid,
-    IN  ULONG           Version,
-    OUT PINTERFACE      Interface,
-    IN  ULONG           Size,
-    IN  BOOLEAN         Optional
+    _In_ PDEVICE_OBJECT DeviceObject,
+    _In_ const GUID     *Guid,
+    _In_ ULONG          Version,
+    _Out_ PINTERFACE    Interface,
+    _In_ ULONG          Size,
+    _In_ BOOLEAN        Optional
     )
 {
     KEVENT              Event;
@@ -2855,8 +2855,8 @@ fail1:
 
 static NTSTATUS
 __QueryLocationInformation(
-    IN  PDEVICE_OBJECT  DeviceObject,
-    OUT PWCHAR          *Location
+    _In_ PDEVICE_OBJECT DeviceObject,
+    _Outptr_ PWCHAR     *Location
     )
 {
     ULONG               Size;
@@ -2921,7 +2921,7 @@ fail1:
 
 static NDIS_STATUS
 AdapterGetAdvancedSettings(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER        Adapter
     )
 {
     NDIS_CONFIGURATION_OBJECT   Config;
@@ -2967,7 +2967,7 @@ fail1:
 
 static NDIS_STATUS
 AdapterSetRegistrationAttributes(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER                            Adapter
     )
 {
     NDIS_MINIPORT_ADAPTER_REGISTRATION_ATTRIBUTES   Attribs;
@@ -2993,7 +2993,7 @@ AdapterSetRegistrationAttributes(
 
 static NDIS_STATUS
 AdapterSetGeneralAttributes(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER                        Adapter
     )
 {
     NDIS_MINIPORT_ADAPTER_GENERAL_ATTRIBUTES    Attribs;
@@ -3134,7 +3134,7 @@ done:
 
 static NDIS_STATUS
 AdapterSetOffloadAttributes(
-    IN  PXENNET_ADAPTER Adapter
+    _In_ PXENNET_ADAPTER                        Adapter
     )
 {
     NDIS_MINIPORT_ADAPTER_OFFLOAD_ATTRIBUTES    Attribs;
@@ -3320,14 +3320,14 @@ AdapterSetOffloadAttributes(
 
 NDIS_STATUS
 AdapterInitialize(
-    IN  NDIS_HANDLE         Handle,
-    OUT PXENNET_ADAPTER     *Adapter
+    _In_ NDIS_HANDLE            Handle,
+    _Outptr_ PXENNET_ADAPTER    *Adapter
     )
 {
-    NDIS_STATUS             ndisStatus;
-    NTSTATUS                status;
-    PDEVICE_OBJECT          DeviceObject;
-    NDIS_SG_DMA_DESCRIPTION Dma;
+    NDIS_STATUS                 ndisStatus;
+    NTSTATUS                    status;
+    PDEVICE_OBJECT              DeviceObject;
+    NDIS_SG_DMA_DESCRIPTION     Dma;
 
     *Adapter = __AdapterAllocate(sizeof (XENNET_ADAPTER));
 
@@ -3464,7 +3464,7 @@ fail1:
 
 VOID
 AdapterTeardown(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     )
 {
     TransmitterTeardown(Adapter->Transmitter);
diff --git a/src/xennet/adapter.h b/src/xennet/adapter.h
index a54cb4d..c6eb99f 100644
--- a/src/xennet/adapter.h
+++ b/src/xennet/adapter.h
@@ -57,68 +57,68 @@ typedef struct _XENNET_ADAPTER XENNET_ADAPTER, 
*PXENNET_ADAPTER;
 
 extern NDIS_STATUS
 AdapterInitialize(
-    IN  NDIS_HANDLE         Handle,
-    OUT PXENNET_ADAPTER     *Adapter
+    _In_ NDIS_HANDLE            Handle,
+    _Outptr_ PXENNET_ADAPTER    *Adapter
     );
 
 extern VOID
 AdapterTeardown(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 extern NDIS_HANDLE
 AdapterGetHandle(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 #include <vif_interface.h>
 extern PXENVIF_VIF_INTERFACE
 AdapterGetVifInterface(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 #include "transmitter.h"
 extern PXENNET_TRANSMITTER
 AdapterGetTransmitter(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 #include "receiver.h"
 extern PXENNET_RECEIVER
 AdapterGetReceiver(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 extern PWCHAR
 AdapterGetLocation(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 extern NDIS_STATUS
 AdapterEnable(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 extern VOID
 AdapterDisable(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 extern VOID
 AdapterMediaStateChange(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 extern NDIS_STATUS
 AdapterSetInformation(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PNDIS_OID_REQUEST   Request
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PNDIS_OID_REQUEST  Request
     );
 
 extern NDIS_STATUS
 AdapterQueryInformation(
-    IN  PXENNET_ADAPTER     Adapter,
-    IN  PNDIS_OID_REQUEST   Request
+    _In_ PXENNET_ADAPTER    Adapter,
+    _In_ PNDIS_OID_REQUEST  Request
     );
 
 #define NBL_BATCH_SIZE_DEFAULT  32
@@ -126,7 +126,7 @@ AdapterQueryInformation(
 
 extern ULONG
 AdapterGetNblMaxBatchSize(
-    IN  PXENNET_ADAPTER     Adapter
+    _In_ PXENNET_ADAPTER    Adapter
     );
 
 #endif // _XENNET_ADAPTER_H_
diff --git a/src/xennet/assert.h b/src/xennet/assert.h
index a2f407d..240ae44 100644
--- a/src/xennet/assert.h
+++ b/src/xennet/assert.h
@@ -154,10 +154,10 @@ __Bug(
 
 static __inline BOOLEAN
 _IsZeroMemory(
-    _In_ PCSTR          Caller,
-    _In_ PCSTR          Name,
-    _In_ PVOID          Buffer,
-    _In_ ULONG          Length
+    _In_ PCSTR      Caller,
+    _In_ PCSTR      Name,
+    _In_ PVOID      Buffer,
+    _In_ ULONG      Length
     )
 {
     ULONG           Offset;
@@ -178,10 +178,10 @@ _IsZeroMemory(
 
 static __inline BOOLEAN
 _IsZeroMemory(
-    _In_ PCSTR          Caller,
-    _In_ PCSTR          Name,
-    _In_ PVOID          Buffer,
-    _In_ ULONG          Length
+    _In_ PCSTR  Caller,
+    _In_ PCSTR  Name,
+    _In_ PVOID  Buffer,
+    _In_ ULONG  Length
     )
 {
     UNREFERENCED_PARAMETER(Caller);
diff --git a/src/xennet/driver.c b/src/xennet/driver.c
index 5f31ac2..bcf3f0b 100644
--- a/src/xennet/driver.c
+++ b/src/xennet/driver.c
@@ -48,7 +48,7 @@ static XENNET_DRIVER Driver;
 
 VOID
 DriverUnload(
-    IN  PDRIVER_OBJECT  DriverObject
+    _In_ PDRIVER_OBJECT DriverObject
     )
 {
     UNREFERENCED_PARAMETER(DriverObject);
@@ -75,17 +75,17 @@ DRIVER_INITIALIZE       DriverEntry;
 
 NTSTATUS
 DriverEntry (
-    IN  PDRIVER_OBJECT  DriverObject,
-    IN  PUNICODE_STRING RegistryPath
+    _In_ PDRIVER_OBJECT             DriverObject,
+    _In_ PUNICODE_STRING            RegistryPath
     )
 {
-    NDIS_STATUS ndisStatus;
-    NDIS_CONFIGURATION_OBJECT ConfigurationObject;
-    NDIS_HANDLE ConfigurationHandle;
-    NDIS_STRING ParameterName;
-    PNDIS_CONFIGURATION_PARAMETER ParameterValue;
-    ULONG FailCreateClose;
-    ULONG FailDeviceControl;
+    NDIS_STATUS                     ndisStatus;
+    NDIS_CONFIGURATION_OBJECT       ConfigurationObject;
+    NDIS_HANDLE                     ConfigurationHandle;
+    NDIS_STRING                     ParameterName;
+    PNDIS_CONFIGURATION_PARAMETER   ParameterValue;
+    ULONG                           FailCreateClose;
+    ULONG                           FailDeviceControl;
 
     ExInitializeDriverRuntime(DrvRtPoolNxOptIn);
     WdmlibProcgrpInitialize();
diff --git a/src/xennet/driver.h b/src/xennet/driver.h
index 1c167c6..a0ccc11 100644
--- a/src/xennet/driver.h
+++ b/src/xennet/driver.h
@@ -35,7 +35,7 @@
 
 extern VOID
 DriverUnload(
-    IN  PDRIVER_OBJECT  DriverObject
+    _In_ PDRIVER_OBJECT DriverObject
     );
 
 #endif  // _XENNET_DRIVER_H
diff --git a/src/xennet/miniport.c b/src/xennet/miniport.c
index 9f3a8c6..fe3bfd0 100644
--- a/src/xennet/miniport.c
+++ b/src/xennet/miniport.c
@@ -43,8 +43,8 @@ static
 _Function_class_(SET_OPTIONS)
 NDIS_STATUS
 MiniportSetOptions(
-    IN  NDIS_HANDLE NdisDriverHandle,
-    IN  NDIS_HANDLE DriverContext
+    _In_ NDIS_HANDLE    NdisDriverHandle,
+    _In_ NDIS_HANDLE    DriverContext
     )
 {
     UNREFERENCED_PARAMETER(NdisDriverHandle);
@@ -59,9 +59,9 @@ static
 _Function_class_(MINIPORT_INITIALIZE)
 NDIS_STATUS
 MiniportInitializeEx(
-    IN  NDIS_HANDLE                     NdisMiniportHandle,
-    IN  NDIS_HANDLE                     MiniportDriverContext,
-    IN  PNDIS_MINIPORT_INIT_PARAMETERS  MiniportInitParameters
+    _In_ NDIS_HANDLE                    NdisMiniportHandle,
+    _In_ NDIS_HANDLE                    MiniportDriverContext,
+    _In_ PNDIS_MINIPORT_INIT_PARAMETERS MiniportInitParameters
     )
 {
     PXENNET_ADAPTER                     Adapter;
@@ -86,8 +86,8 @@ static
 _Function_class_(MINIPORT_HALT)
 VOID
 MiniportHaltEx(
-    IN  NDIS_HANDLE         MiniportAdapterContext,
-    IN  NDIS_HALT_ACTION    HaltAction
+    _In_ NDIS_HANDLE        MiniportAdapterContext,
+    _In_ NDIS_HALT_ACTION   HaltAction
     )
 {
     PXENNET_ADAPTER         Adapter = (PXENNET_ADAPTER)MiniportAdapterContext;
@@ -104,7 +104,7 @@ static
 _Function_class_(MINIPORT_UNLOAD)
 VOID
 MiniportDriverUnload(
-    IN  PDRIVER_OBJECT  DriverObject
+    _In_ PDRIVER_OBJECT DriverObject
     )
 {
     DriverUnload(DriverObject);
@@ -114,11 +114,11 @@ static
 _Function_class_(MINIPORT_PAUSE)
 NDIS_STATUS
 MiniportPause(
-    IN  NDIS_HANDLE                     MiniportAdapterContext,
-    IN  PNDIS_MINIPORT_PAUSE_PARAMETERS MiniportPauseParameters
+    _In_ NDIS_HANDLE                        MiniportAdapterContext,
+    _In_ PNDIS_MINIPORT_PAUSE_PARAMETERS    MiniportPauseParameters
     )
 {
-    PXENNET_ADAPTER                     Adapter = 
(PXENNET_ADAPTER)MiniportAdapterContext;
+    PXENNET_ADAPTER                         Adapter = 
(PXENNET_ADAPTER)MiniportAdapterContext;
 
     UNREFERENCED_PARAMETER(MiniportPauseParameters);
 
@@ -131,8 +131,8 @@ static
 _Function_class_(MINIPORT_RESTART)
 NDIS_STATUS
 MiniportRestart(
-    IN  NDIS_HANDLE                         MiniportAdapterContext,
-    IN  PNDIS_MINIPORT_RESTART_PARAMETERS   MiniportRestartParameters
+    _In_ NDIS_HANDLE                        MiniportAdapterContext,
+    _In_ PNDIS_MINIPORT_RESTART_PARAMETERS  MiniportRestartParameters
     )
 {
     PXENNET_ADAPTER                         Adapter = 
(PXENNET_ADAPTER)MiniportAdapterContext;
@@ -149,8 +149,8 @@ static
 _Function_class_(MINIPORT_OID_REQUEST)
 NDIS_STATUS
 MiniportOidRequest(
-    IN  NDIS_HANDLE         MiniportAdapterContext,
-    IN  PNDIS_OID_REQUEST   OidRequest
+    _In_ NDIS_HANDLE        MiniportAdapterContext,
+    _In_ PNDIS_OID_REQUEST  OidRequest
     )
 {
     PXENNET_ADAPTER         Adapter = (PXENNET_ADAPTER)MiniportAdapterContext;
@@ -178,10 +178,10 @@ static
 _Function_class_(MINIPORT_SEND_NET_BUFFER_LISTS)
 VOID
 MiniportSendNetBufferLists(
-    IN  NDIS_HANDLE         MiniportAdapterContext,
-    IN  PNET_BUFFER_LIST    NetBufferList,
-    IN  NDIS_PORT_NUMBER    PortNumber,
-    IN  ULONG               SendFlags
+    _In_ NDIS_HANDLE        MiniportAdapterContext,
+    _In_ PNET_BUFFER_LIST   NetBufferList,
+    _In_ NDIS_PORT_NUMBER   PortNumber,
+    _In_ ULONG              SendFlags
     )
 {
     PXENNET_ADAPTER         Adapter = (PXENNET_ADAPTER)MiniportAdapterContext;
@@ -197,9 +197,9 @@ static
 _Function_class_(MINIPORT_RETURN_NET_BUFFER_LISTS)
 VOID
 MiniportReturnNetBufferLists(
-    IN  NDIS_HANDLE         MiniportAdapterContext,
-    IN  PNET_BUFFER_LIST    NetBufferLists,
-    IN  ULONG               ReturnFlags
+    _In_ NDIS_HANDLE        MiniportAdapterContext,
+    _In_ PNET_BUFFER_LIST   NetBufferLists,
+    _In_ ULONG              ReturnFlags
     )
 {
     PXENNET_ADAPTER         Adapter = (PXENNET_ADAPTER)MiniportAdapterContext;
@@ -214,8 +214,8 @@ static
 _Function_class_(MINIPORT_CANCEL_SEND)
 VOID
 MiniportCancelSend(
-    IN  NDIS_HANDLE MiniportAdapterContext,
-    IN  PVOID       CancelId
+    _In_ NDIS_HANDLE    MiniportAdapterContext,
+    _In_ PVOID          CancelId
     )
 {
     UNREFERENCED_PARAMETER(MiniportAdapterContext);
@@ -226,8 +226,8 @@ static
 _Function_class_(MINIPORT_DEVICE_PNP_EVENT_NOTIFY)
 VOID
 MiniportDevicePnPEventNotify(
-    IN  NDIS_HANDLE             MiniportAdapterContext,
-    IN  PNET_DEVICE_PNP_EVENT   NetDevicePnPEvent
+    _In_ NDIS_HANDLE            MiniportAdapterContext,
+    _In_ PNET_DEVICE_PNP_EVENT  NetDevicePnPEvent
     )
 {
     PXENNET_ADAPTER             Adapter = 
(PXENNET_ADAPTER)MiniportAdapterContext;
@@ -246,8 +246,8 @@ static
 _Function_class_(MINIPORT_SHUTDOWN)
 VOID
 MiniportShutdownEx(
-    IN  NDIS_HANDLE             MiniportAdapterContext,
-    IN  NDIS_SHUTDOWN_ACTION    ShutdownAction
+    _In_ NDIS_HANDLE            MiniportAdapterContext,
+    _In_ NDIS_SHUTDOWN_ACTION   ShutdownAction
     )
 {
     PXENNET_ADAPTER             Adapter = 
(PXENNET_ADAPTER)MiniportAdapterContext;
@@ -266,8 +266,8 @@ static
 _Function_class_(MINIPORT_CANCEL_OID_REQUEST)
 VOID
 MiniportCancelOidRequest(
-    IN  NDIS_HANDLE MiniportAdapterContext,
-    IN  PVOID       RequestId
+    _In_ NDIS_HANDLE    MiniportAdapterContext,
+    _In_ PVOID          RequestId
     )
 {
     UNREFERENCED_PARAMETER(MiniportAdapterContext);
@@ -278,9 +278,9 @@ MiniportCancelOidRequest(
 
 NDIS_STATUS
 MiniportRegister(
-    IN  PDRIVER_OBJECT                      DriverObject,
-    IN  PUNICODE_STRING                     RegistryPath,
-    OUT PNDIS_HANDLE                        NdisMiniportDriverHandle
+    _In_ PDRIVER_OBJECT                     DriverObject,
+    _In_ PUNICODE_STRING                    RegistryPath,
+    _Out_ PNDIS_HANDLE                      NdisMiniportDriverHandle
     )
 {
     NDIS_STATUS                             NdisStatus;
diff --git a/src/xennet/miniport.h b/src/xennet/miniport.h
index 16e9395..7ef76c7 100644
--- a/src/xennet/miniport.h
+++ b/src/xennet/miniport.h
@@ -35,9 +35,9 @@
 
 extern NDIS_STATUS
 MiniportRegister(
-    IN  PDRIVER_OBJECT  DriverObject,
-    IN  PUNICODE_STRING RegistryPath,
-    OUT PNDIS_HANDLE    NdisMiniportDriverHandle
+    _In_ PDRIVER_OBJECT     DriverObject,
+    _In_ PUNICODE_STRING    RegistryPath,
+    _Out_ PNDIS_HANDLE      NdisMiniportDriverHandle
     );
 
 #endif  // _XENNET_MINIPORT_H
diff --git a/src/xennet/receiver.c b/src/xennet/receiver.c
index 55492f2..1cb6519 100644
--- a/src/xennet/receiver.c
+++ b/src/xennet/receiver.c
@@ -72,7 +72,7 @@ C_ASSERT(sizeof (NET_BUFFER_LIST_RESERVED) <= 
RTL_FIELD_SIZE(NET_BUFFER_LIST, Mi
 
 static FORCEINLINE PNET_BUFFER_LIST
 __ReceiverGetNetBufferList(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     )
 {
     ULONG                   Index;
@@ -99,8 +99,8 @@ __ReceiverGetNetBufferList(
 
 static FORCEINLINE VOID
 __ReceiverPutNetBufferList(
-    IN  PXENNET_RECEIVER    Receiver,
-    IN  PNET_BUFFER_LIST    NetBufferList
+    _In_ PXENNET_RECEIVER   Receiver,
+    _In_ PNET_BUFFER_LIST   NetBufferList
     )
 {
     PNET_BUFFER_LIST        Old;
@@ -118,12 +118,12 @@ __ReceiverPutNetBufferList(
 
 static PNET_BUFFER_LIST
 __ReceiverAllocateNetBufferList(
-    IN  PXENNET_RECEIVER        Receiver,
-    IN  PMDL                    Mdl,
-    IN  ULONG                   Offset,
-    IN  ULONG                   Length,
-    IN  PXENVIF_PACKET_INFO     Info,
-    IN  PVOID                   Cookie
+    _In_ PXENNET_RECEIVER       Receiver,
+    _In_ PMDL                   Mdl,
+    _In_ ULONG                  Offset,
+    _In_ ULONG                  Length,
+    _In_ PXENVIF_PACKET_INFO    Info,
+    _In_ PVOID                  Cookie
     )
 {
     PNET_BUFFER_LIST            NetBufferList;
@@ -187,9 +187,9 @@ __ReceiverAllocateNetBufferList(
 
 static PVOID
 __ReceiverReleaseNetBufferList(
-    IN  PXENNET_RECEIVER        Receiver,
-    IN  PNET_BUFFER_LIST        NetBufferList,
-    IN  BOOLEAN                 Cache
+    _In_ PXENNET_RECEIVER       Receiver,
+    _In_ PNET_BUFFER_LIST       NetBufferList,
+    _In_ BOOLEAN                Cache
     )
 {
     PNET_BUFFER_LIST_RESERVED   ListReserved;
@@ -210,9 +210,9 @@ __ReceiverReleaseNetBufferList(
 
 static FORCEINLINE VOID
 __ReceiverReturnNetBufferLists(
-    IN  PXENNET_RECEIVER    Receiver,
-    IN  PNET_BUFFER_LIST    NetBufferList,
-    IN  BOOLEAN             Cache
+    _In_ PXENNET_RECEIVER   Receiver,
+    _In_ PNET_BUFFER_LIST   NetBufferList,
+    _In_ BOOLEAN            Cache
     )
 {
     PXENVIF_VIF_INTERFACE   VifInterface;
@@ -245,16 +245,16 @@ __ReceiverReturnNetBufferLists(
 
 static PNET_BUFFER_LIST
 __ReceiverReceivePacket(
-    IN  PXENNET_RECEIVER                        Receiver,
-    IN  PMDL                                    Mdl,
-    IN  ULONG                                   Offset,
-    IN  ULONG                                   Length,
-    IN  XENVIF_PACKET_CHECKSUM_FLAGS            Flags,
-    IN  USHORT                                  MaximumSegmentSize,
-    IN  USHORT                                  TagControlInformation,
-    IN  PXENVIF_PACKET_INFO                     Info,
-    IN  PXENVIF_PACKET_HASH                     Hash,
-    IN  PVOID                                   Cookie
+    _In_ PXENNET_RECEIVER                       Receiver,
+    _In_ PMDL                                   Mdl,
+    _In_ ULONG                                  Offset,
+    _In_ ULONG                                  Length,
+    _In_ XENVIF_PACKET_CHECKSUM_FLAGS           Flags,
+    _In_ USHORT                                 MaximumSegmentSize,
+    _In_ USHORT                                 TagControlInformation,
+    _In_ PXENVIF_PACKET_INFO                    Info,
+    _In_ PXENVIF_PACKET_HASH                    Hash,
+    _In_ PVOID                                  Cookie
     )
 {
     PNET_BUFFER_LIST                            NetBufferList;
@@ -352,11 +352,11 @@ fail1:
 
 static FORCEINLINE VOID
 __IndicateReceiveNetBufferLists(
-    IN  PXENNET_RECEIVER    Receiver,
-    IN  PNET_BUFFER_LIST    Remaining,
-    IN  NDIS_PORT_NUMBER    PortNumber,
-    IN  ULONG               NumberOfNetBufferLists,
-    IN  ULONG               ReceiveFlags
+    _In_ PXENNET_RECEIVER   Receiver,
+    _In_ PNET_BUFFER_LIST   Remaining,
+    _In_ NDIS_PORT_NUMBER   PortNumber,
+    _In_ ULONG              NumberOfNetBufferLists,
+    _In_ ULONG              ReceiveFlags
     )
 {
     PXENNET_ADAPTER         Adapter = Receiver->Adapter;
@@ -432,9 +432,9 @@ __IndicateReceiveNetBufferLists(
 
 static VOID
 __ReceiverPushPackets(
-    IN  PXENNET_RECEIVER    Receiver,
-    IN  ULONG               Index,
-    OUT PBOOLEAN            Pause
+    _In_ PXENNET_RECEIVER   Receiver,
+    _In_ ULONG              Index,
+    _Out_ PBOOLEAN          Pause
     )
 {
     ULONG                   Flags;
@@ -480,8 +480,8 @@ __ReceiverPushPackets(
 
 NDIS_STATUS
 ReceiverInitialize(
-    IN  PXENNET_ADAPTER     Adapter,
-    OUT PXENNET_RECEIVER    *Receiver
+    _In_ PXENNET_ADAPTER            Adapter,
+    _Outptr_ PXENNET_RECEIVER       *Receiver
     )
 {
     NET_BUFFER_LIST_POOL_PARAMETERS Params;
@@ -530,7 +530,7 @@ fail1:
 
 VOID
 ReceiverTeardown(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     )
 {
     ULONG                   Index;
@@ -577,9 +577,9 @@ ReceiverTeardown(
 
 VOID
 ReceiverReturnNetBufferLists(
-    IN  PXENNET_RECEIVER    Receiver,
-    IN  PNET_BUFFER_LIST    NetBufferList,
-    IN  ULONG               ReturnFlags
+    _In_ PXENNET_RECEIVER   Receiver,
+    _In_ PNET_BUFFER_LIST   NetBufferList,
+    _In_ ULONG              ReturnFlags
     )
 {
     UNREFERENCED_PARAMETER(ReturnFlags);
@@ -589,19 +589,19 @@ ReceiverReturnNetBufferLists(
 
 VOID
 ReceiverQueuePacket(
-    IN  PXENNET_RECEIVER                Receiver,
-    IN  ULONG                           Index,
-    IN  PMDL                            Mdl,
-    IN  ULONG                           Offset,
-    IN  ULONG                           Length,
-    IN  XENVIF_PACKET_CHECKSUM_FLAGS    Flags,
-    IN  USHORT                          MaximumSegmentSize,
-    IN  USHORT                          TagControlInformation,
-    IN  PXENVIF_PACKET_INFO             Info,
-    IN  PXENVIF_PACKET_HASH             Hash,
-    IN  BOOLEAN                         More,
-    IN  PVOID                           Cookie,
-    OUT PBOOLEAN                        Pause
+    _In_ PXENNET_RECEIVER               Receiver,
+    _In_ ULONG                          Index,
+    _In_ PMDL                           Mdl,
+    _In_ ULONG                          Offset,
+    _In_ ULONG                          Length,
+    _In_ XENVIF_PACKET_CHECKSUM_FLAGS   Flags,
+    _In_ USHORT                         MaximumSegmentSize,
+    _In_ USHORT                         TagControlInformation,
+    _In_ PXENVIF_PACKET_INFO            Info,
+    _In_ PXENVIF_PACKET_HASH            Hash,
+    _In_ BOOLEAN                        More,
+    _In_ PVOID                          Cookie,
+    _Out_ PBOOLEAN                      Pause
     )
 {
     PXENVIF_VIF_INTERFACE               VifInterface;
@@ -657,7 +657,7 @@ done:
 
 PXENVIF_VIF_OFFLOAD_OPTIONS
 ReceiverOffloadOptions(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     )
 {
     return &Receiver->OffloadOptions;
@@ -665,7 +665,7 @@ ReceiverOffloadOptions(
 
 VOID
 ReceiverEnable(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     )
 {
     PXENNET_ADAPTER         Adapter = Receiver->Adapter;
@@ -676,7 +676,7 @@ ReceiverEnable(
 
 VOID
 ReceiverDisable(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     )
 {
     PXENNET_ADAPTER         Adapter = Receiver->Adapter;
diff --git a/src/xennet/receiver.h b/src/xennet/receiver.h
index d8b8c84..0b17b8c 100644
--- a/src/xennet/receiver.h
+++ b/src/xennet/receiver.h
@@ -40,52 +40,52 @@ typedef struct _XENNET_RECEIVER XENNET_RECEIVER, 
*PXENNET_RECEIVER;
 #include "adapter.h"
 extern NDIS_STATUS
 ReceiverInitialize(
-    IN  PXENNET_ADAPTER     Adapter,
-    OUT PXENNET_RECEIVER    *Receiver
+    _In_ PXENNET_ADAPTER        Adapter,
+    _Outptr_ PXENNET_RECEIVER   *Receiver
     );
 
 extern VOID
 ReceiverTeardown(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     );
 
 extern VOID
 ReceiverReturnNetBufferLists(
-    IN  PXENNET_RECEIVER    Receiver,
-    IN  PNET_BUFFER_LIST    NetBufferList,
-    IN  ULONG               ReturnFlags
+    _In_ PXENNET_RECEIVER   Receiver,
+    _In_ PNET_BUFFER_LIST   NetBufferList,
+    _In_ ULONG              ReturnFlags
     );
 
 extern VOID
 ReceiverQueuePacket(
-    IN  PXENNET_RECEIVER                Receiver,
-    IN  ULONG                           Index,
-    IN  PMDL                            Mdl,
-    IN  ULONG                           Offset,
-    IN  ULONG                           Length,
-    IN  XENVIF_PACKET_CHECKSUM_FLAGS    Flags,
-    IN  USHORT                          MaximumSegmentSize,
-    IN  USHORT                          TagControlInformation,
-    IN  PXENVIF_PACKET_INFO             Info,
-    IN  PXENVIF_PACKET_HASH             Hash,
-    IN  BOOLEAN                         More,
-    IN  PVOID                           Cookie,
-    OUT PBOOLEAN                        Pause
+    _In_ PXENNET_RECEIVER               Receiver,
+    _In_ ULONG                          Index,
+    _In_ PMDL                           Mdl,
+    _In_ ULONG                          Offset,
+    _In_ ULONG                          Length,
+    _In_ XENVIF_PACKET_CHECKSUM_FLAGS   Flags,
+    _In_ USHORT                         MaximumSegmentSize,
+    _In_ USHORT                         TagControlInformation,
+    _In_ PXENVIF_PACKET_INFO            Info,
+    _In_ PXENVIF_PACKET_HASH            Hash,
+    _In_ BOOLEAN                        More,
+    _In_ PVOID                          Cookie,
+    _Out_ PBOOLEAN                      Pause
     );
 
 extern PXENVIF_VIF_OFFLOAD_OPTIONS
 ReceiverOffloadOptions(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     );
 
 extern VOID
 ReceiverEnable(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     );
 
 extern VOID
 ReceiverDisable(
-    IN  PXENNET_RECEIVER    Receiver
+    _In_ PXENNET_RECEIVER   Receiver
     );
 
 #endif // _XENNET_RECEIVER_H_
diff --git a/src/xennet/string.c b/src/xennet/string.c
index e0e22a7..b75e249 100644
--- a/src/xennet/string.c
+++ b/src/xennet/string.c
@@ -40,8 +40,8 @@
 
 static FORCEINLINE NTSTATUS
 __StringPut(
-    IN  PSTRING String,
-    IN  CHAR    Character
+    _In_ PSTRING    String,
+    _In_ CHAR       Character
     )
 {
     if (String->Length >= String->MaximumLength - 1)
@@ -53,10 +53,10 @@ __StringPut(
 
 static PCHAR
 FormatNumber(
-    IN  PCHAR       Buffer,
-    IN  ULONGLONG   Value,
-    IN  UCHAR       Base,
-    IN  BOOLEAN     UpperCase
+    _In_ PCHAR      Buffer,
+    _In_ ULONGLONG  Value,
+    _In_ UCHAR      Base,
+    _In_ BOOLEAN    UpperCase
     )
 {
     ULONGLONG       Next = Value / Base;
@@ -113,9 +113,9 @@ FormatNumber(
 
 static NTSTATUS
 StringWriteBuffer(
-    IN  PSTRING         String,
-    IN  const CHAR      *Format,
-    IN  va_list         Arguments
+    _In_ PSTRING        String,
+    _In_ const CHAR     *Format,
+    _In_ va_list        Arguments
     )
 {
     CHAR                Character;
@@ -419,9 +419,9 @@ done:
 
 NTSTATUS
 StringVPrintf(
-    IN  PSTRING     String,
-    IN  const CHAR  *Format,
-    IN  va_list     Arguments
+    _In_ PSTRING    String,
+    _In_ const CHAR *Format,
+    _In_ va_list    Arguments
     )
 {
     NTSTATUS        status;
@@ -452,8 +452,8 @@ fail1:
 
 NTSTATUS
 StringPrintf(
-    IN  PSTRING     String,
-    IN  const CHAR  *Format,
+    _In_ PSTRING    String,
+    _In_ const CHAR *Format,
     ...
     )
 {
diff --git a/src/xennet/string.h b/src/xennet/string.h
index 03a96ce..295617c 100644
--- a/src/xennet/string.h
+++ b/src/xennet/string.h
@@ -37,15 +37,15 @@
 
 extern NTSTATUS
 StringVPrintf(
-    IN  PSTRING     String,
-    IN  const CHAR  *Format,
-    IN  va_list     Arguments
+    _In_ PSTRING    String,
+    _In_ const CHAR *Format,
+    _In_ va_list    Arguments
     );
 
 extern NTSTATUS
 StringPrintf(
-    IN  PSTRING     String,
-    IN  const CHAR  *Format,
+    _In_ PSTRING    String,
+    _In_ const CHAR *Format,
     ...
     );
 
diff --git a/src/xennet/transmitter.c b/src/xennet/transmitter.c
index 4bb82bc..01693ca 100644
--- a/src/xennet/transmitter.c
+++ b/src/xennet/transmitter.c
@@ -49,11 +49,11 @@ struct _XENNET_TRANSMITTER {
 
 NDIS_STATUS
 TransmitterInitialize (
-    IN  PXENNET_ADAPTER     Adapter,
-    OUT PXENNET_TRANSMITTER *Transmitter
+    _In_ PXENNET_ADAPTER            Adapter,
+    _Outptr_ PXENNET_TRANSMITTER    *Transmitter
     )
 {
-    NTSTATUS                status;
+    NTSTATUS                        status;
 
     *Transmitter = __AllocatePoolWithTag(NonPagedPool,
                                          sizeof(XENNET_TRANSMITTER),
@@ -79,7 +79,7 @@ fail1:
 
 VOID
 TransmitterTeardown(
-    IN  PXENNET_TRANSMITTER Transmitter
+    _In_ PXENNET_TRANSMITTER    Transmitter
     )
 {
     Transmitter->Adapter = NULL;
@@ -99,9 +99,9 @@ C_ASSERT(sizeof (NET_BUFFER_LIST_RESERVED) <= 
RTL_FIELD_SIZE(NET_BUFFER_LIST, Mi
 
 static VOID
 __TransmitterCompleteNetBufferList(
-    IN  PXENNET_TRANSMITTER     Transmitter,
-    IN  PNET_BUFFER_LIST        NetBufferList,
-    IN  NDIS_STATUS             Status
+    _In_ PXENNET_TRANSMITTER    Transmitter,
+    _In_ PNET_BUFFER_LIST       NetBufferList,
+    _In_ NDIS_STATUS            Status
     )
 {
     ASSERT3P(NET_BUFFER_LIST_NEXT_NBL(NetBufferList), ==, NULL);
@@ -125,8 +125,8 @@ __TransmitterCompleteNetBufferList(
 
 static VOID
 __TransmitterGetNetBufferList(
-    IN  PXENNET_TRANSMITTER     Transmitter,
-    IN  PNET_BUFFER_LIST        NetBufferList
+    _In_ PXENNET_TRANSMITTER    Transmitter,
+    _In_ PNET_BUFFER_LIST       NetBufferList
     )
 {
     PNET_BUFFER_LIST_RESERVED   ListReserved;
@@ -141,8 +141,8 @@ __TransmitterGetNetBufferList(
 
 static VOID
 __TransmitterPutNetBufferList(
-    IN  PXENNET_TRANSMITTER     Transmitter,
-    IN  PNET_BUFFER_LIST        NetBufferList
+    _In_ PXENNET_TRANSMITTER    Transmitter,
+    _In_ PNET_BUFFER_LIST       NetBufferList
     )
 {
     PNET_BUFFER_LIST_RESERVED   ListReserved;
@@ -160,9 +160,9 @@ __TransmitterPutNetBufferList(
 
 static VOID
 __TransmitterReturnPacket(
-    IN  PXENNET_TRANSMITTER     Transmitter,
-    IN  PVOID                   Cookie,
-    IN  NDIS_STATUS             Status
+    _In_ PXENNET_TRANSMITTER    Transmitter,
+    _In_ PVOID                  Cookie,
+    _In_ NDIS_STATUS            Status
     )
 {
     PNET_BUFFER_LIST            NetBufferList = Cookie;
@@ -178,10 +178,10 @@ __TransmitterReturnPacket(
 
 static VOID
 __TransmitterOffloadOptions(
-    IN  PNET_BUFFER_LIST            NetBufferList,
-    OUT PXENVIF_VIF_OFFLOAD_OPTIONS OffloadOptions,
-    OUT PUSHORT                     TagControlInformation,
-    OUT PUSHORT                     MaximumSegmentSize
+    _In_ PNET_BUFFER_LIST                               NetBufferList,
+    _Out_ PXENVIF_VIF_OFFLOAD_OPTIONS                   OffloadOptions,
+    _Out_ PUSHORT                                       TagControlInformation,
+    _Out_ PUSHORT                                       MaximumSegmentSize
     )
 {
     PNDIS_TCP_LARGE_SEND_OFFLOAD_NET_BUFFER_LIST_INFO   LargeSendInfo;
@@ -247,8 +247,8 @@ __TransmitterOffloadOptions(
 
 static VOID
 __TransmitterHash(
-    IN  PNET_BUFFER_LIST        NetBufferList,
-    OUT PXENVIF_PACKET_HASH     Hash
+    _In_ PNET_BUFFER_LIST       NetBufferList,
+    _Out_ PXENVIF_PACKET_HASH   Hash
     )
 {
     switch (NET_BUFFER_LIST_GET_HASH_FUNCTION(NetBufferList)) {
@@ -287,8 +287,8 @@ __TransmitterHash(
 
 static VOID
 __TransmitterSendNetBufferList(
-    IN  PXENNET_TRANSMITTER     Transmitter,
-    IN  PNET_BUFFER_LIST        NetBufferList
+    _In_ PXENNET_TRANSMITTER    Transmitter,
+    _In_ PNET_BUFFER_LIST       NetBufferList
     )
 {
     PNET_BUFFER_LIST_RESERVED   ListReserved;
@@ -360,10 +360,10 @@ __TransmitterSendNetBufferList(
 
 VOID
 TransmitterSendNetBufferLists(
-    IN  PXENNET_TRANSMITTER     Transmitter,
-    IN  PNET_BUFFER_LIST        NetBufferList,
-    IN  NDIS_PORT_NUMBER        PortNumber,
-    IN  ULONG                   SendFlags
+    _In_ PXENNET_TRANSMITTER    Transmitter,
+    _In_ PNET_BUFFER_LIST       NetBufferList,
+    _In_ NDIS_PORT_NUMBER       PortNumber,
+    _In_ ULONG                  SendFlags
     )
 {
     LIST_ENTRY                  List;
@@ -397,9 +397,9 @@ TransmitterSendNetBufferLists(
 
 VOID
 TransmitterReturnPacket(
-    IN  PXENNET_TRANSMITTER                         Transmitter,
-    IN  PVOID                                       Cookie,
-    IN  PXENVIF_TRANSMITTER_PACKET_COMPLETION_INFO  Completion
+    _In_ PXENNET_TRANSMITTER                        Transmitter,
+    _In_ PVOID                                      Cookie,
+    _In_ PXENVIF_TRANSMITTER_PACKET_COMPLETION_INFO Completion
     )
 {
     NDIS_STATUS                                     Status;
@@ -415,7 +415,7 @@ TransmitterReturnPacket(
 
 PXENVIF_VIF_OFFLOAD_OPTIONS
 TransmitterOffloadOptions(
-    IN  PXENNET_TRANSMITTER Transmitter
+    _In_ PXENNET_TRANSMITTER    Transmitter
     )
 {
     return &Transmitter->OffloadOptions;
diff --git a/src/xennet/transmitter.h b/src/xennet/transmitter.h
index 97d2f74..4dc8937 100644
--- a/src/xennet/transmitter.h
+++ b/src/xennet/transmitter.h
@@ -40,33 +40,33 @@ typedef struct _XENNET_TRANSMITTER XENNET_TRANSMITTER, 
*PXENNET_TRANSMITTER;
 #include "adapter.h"
 extern NDIS_STATUS
 TransmitterInitialize(
-    IN  PXENNET_ADAPTER     Adapter,
-    OUT PXENNET_TRANSMITTER *Transmitter
+    _In_ PXENNET_ADAPTER            Adapter,
+    _Outptr_ PXENNET_TRANSMITTER    *Transmitter
     );
 
 extern VOID
 TransmitterTeardown(
-    IN  PXENNET_TRANSMITTER Transmitter
+    _In_ PXENNET_TRANSMITTER    Transmitter
     );
 
 extern VOID
 TransmitterSendNetBufferLists (
-    IN  PXENNET_TRANSMITTER Transmitter,
-    IN  PNET_BUFFER_LIST    NetBufferList,
-    IN  NDIS_PORT_NUMBER    PortNumber,
-    IN  ULONG               SendFlags
+    _In_ PXENNET_TRANSMITTER    Transmitter,
+    _In_ PNET_BUFFER_LIST       NetBufferList,
+    _In_ NDIS_PORT_NUMBER       PortNumber,
+    _In_ ULONG                  SendFlags
     );
 
 extern VOID
 TransmitterReturnPacket(
-    IN  PXENNET_TRANSMITTER                         Transmitter,
-    IN  PVOID                                       Cookie,
-    IN  PXENVIF_TRANSMITTER_PACKET_COMPLETION_INFO  Completion
+    _In_ PXENNET_TRANSMITTER                        Transmitter,
+    _In_ PVOID                                      Cookie,
+    _In_ PXENVIF_TRANSMITTER_PACKET_COMPLETION_INFO Completion
     );
 
 extern PXENVIF_VIF_OFFLOAD_OPTIONS
 TransmitterOffloadOptions(
-    IN  PXENNET_TRANSMITTER Transmitter
+    _In_ PXENNET_TRANSMITTER    Transmitter
     );
 
 #endif // _XENNET_TRANSMITTER_H_
diff --git a/src/xennet/util.h b/src/xennet/util.h
index 597a2e1..59ca37e 100644
--- a/src/xennet/util.h
+++ b/src/xennet/util.h
@@ -89,7 +89,7 @@ __CpuId(
     _Out_opt_ PULONG    EDX
     )
 {
-    int         Value[4] = {0};
+    int                 Value[4] = {0};
 
     __cpuid(Value, Leaf);
 
@@ -112,8 +112,8 @@ __InterlockedAdd(
     _In_ LONG       Delta
     )
 {
-    LONG        New;
-    LONG        Old;
+    LONG            New;
+    LONG            Old;
 
     do {
         Old = *Value;
@@ -129,8 +129,8 @@ __InterlockedSubtract(
     _In_ LONG       Delta
     )
 {
-    LONG        New;
-    LONG        Old;
+    LONG            New;
+    LONG            Old;
 
     do {
         Old = *Value;
@@ -262,7 +262,7 @@ __FreePages(
     _In_ PMDL   Mdl
     )
 {
-    PUCHAR     MdlMappedSystemVa;
+    PUCHAR      MdlMappedSystemVa;
 
     ASSERT(Mdl->MdlFlags & MDL_MAPPED_TO_SYSTEM_VA);
     MdlMappedSystemVa = Mdl->MappedSystemVa;
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.