[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] receiver: Remove dependencies on HVM_MAX_VCPUS


  • To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Thu, 8 Oct 2026 10:31:24 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IPtE48CCF/Rsx/u7slGeX1gFsqtzE8YpJDA8s3a1DMc=; b=W7l80aNQItgysATT4WfxIcwV+IFhBqb13BaOX5ZkaP5CW/3dyY6dsNtWTlzpLmYF8VM+CDZtc9pHTB0eN00DxL+G3yqk2VqbazbHhIb4TBUxsAqgS2eDbBBnd3wN6WvjwHGpanUFn6Kynj6EW0n2yhLlmoFNa3+/MUt/tI18SEToIMK/IkaB0RMH5fTpCPc2ixSL7tyripS9e2zJHd+hP8EetuTtG2+lNmWd5JTdgX/+zgZCkEseBcHNQTA2sf2FAUBo78JvL0V6LBTkA2v7jTN7NrxBZ/m42gN1Bhlb0M18RxmrFPw0LEcJXoMGoxKbneXJ9aupblCRcUrWakTnKQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YZMonrkQ9DYRsHgH5Jp9B5twqH30JeMUKqZJuoMC6Qasx/Ul8aUrf9NeC6zcfKtFMhh2rQTezmYDyAZz76HElTF/MTQW7Rtx5bYA/hQjUjippKoCYOpDXXBPZYXl//GhI12oaKcq5zHI8mf25GtK+G52pcWnDGAQtMHPX4aSYr1HA7QO/EO8CQ4zPuaCFGmSJ+c3XNpquVbn2nJ7eji8uO4Id8jvP9Iz7PI3jU5ZFnj8WNm/wOoXU+sDea/O5ChRoR3jzixJpDRX2XX7xwYq3h0AxQuBEVjTv3PGSGxgrmLlDOo0y+D0TYEsQIde0AMFfIIObKBuXE329RFfCx4Kog==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Delivery-date: Thu, 08 Oct 2026 10:31:33 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Msip_labels:
  • Thread-index: AQHdVwLM5ENtsnaoREG6Oqxrhuc2xbbzcI2D
  • Thread-topic: [PATCH 1/2] receiver: Remove dependencies on HVM_MAX_VCPUS

> diff --git a/src/xennet/receiver.c b/src/xennet/receiver.c
> index 565d31b..91e344b 100644
> --- a/src/xennet/receiver.c
> +++ b/src/xennet/receiver.c
> @@ -33,7 +33,6 @@
>  #include <ndis.h>
>  #include <procgrp.h>
>  #include <tcpip.h>
> -#include <xen.h>
>  #include <ethernet.h>
> 
>  #include "util.h"
> @@ -53,8 +52,9 @@ struct _XENNET_RECEIVER {
>      PXENNET_ADAPTER             Adapter;
>      NDIS_HANDLE                 NetBufferListPool;
>      PNET_BUFFER_LIST            PutList;
> -    PNET_BUFFER_LIST            GetList[HVM_MAX_VCPUS];
> -    XENNET_RECEIVER_QUEUE       Queue[HVM_MAX_VCPUS];
> +    ULONG                       Count;
> +    PNET_BUFFER_LIST            *GetList;
> +    XENNET_RECEIVER_QUEUE       *Queue;
>      LONG                        Indicated;
>      LONG                        Returned;
>      XENVIF_VIF_OFFLOAD_OPTIONS  OffloadOptions;

It may be useful to group all Queue related fields in the XENNET_RECEIVER_QUEUE
structure.
A PutList, GetList, Indicated and Received specific to each queue would help 
with multi-queue
scaling, though it would require stashing the queue index in the NBL reserved 
data.

Owen


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.