[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 04/10] xeniface: fix __MultiSzLen never incrementing string count


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: david ambu <david.preetham@xxxxxxxxxx>
  • Date: Thu, 8 Oct 2026 13:01:56 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=citrix.com header.i="@citrix.com" header.h="Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From"
  • Cc: david ambu <david.preetham@xxxxxxxxxx>
  • Delivery-date: Thu, 08 Oct 2026 12:05:20 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

if (*Count) checked the value which is always 0, so Count
was never incremented and callers always received 0 strings.
Change to if (Count) to guard the pointer as intended.

Signed-off-by: david ambu <david.preetham@xxxxxxxxxx>
Assisted by Claude Sonnet 4.6
---
 src/xeniface/ioctl_store.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xeniface/ioctl_store.c b/src/xeniface/ioctl_store.c
index dbe197b..5e422b5 100644
--- a/src/xeniface/ioctl_store.c
+++ b/src/xeniface/ioctl_store.c
@@ -87,7 +87,7 @@ __MultiSzLen(
     do {
         for ( ; *Str; ++Str, ++Length) ;
         ++Str; ++Length;
-        if (*Count) ++(*Count);
+        if (Count) ++(*Count);
     } while (*Str);
     return Length;
 }
-- 
2.51.0.windows.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.