[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 3/7] xeniface: Enforce read-only foreign page views


  • To: Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>, win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
  • Date: Sat, 21 Nov 2026 13:52:19 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Rafał Wojdyła <omeg@xxxxxxx>
  • Delivery-date: Sat, 21 Nov 2026 12:52:26 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

On 10/11/2026 19:36, Rafał Wojdyła wrote:
> From: Rafał Wojdyła <omeg@xxxxxxx>
> 
> Pass MdlMappingNoWrite when exposing read-only foreign pages to user
> mode. Reject notify byte configuration for these mappings because cleanup
> must not write through a read-only foreign mapping.
> 
> Assisted-by: LLM
> Signed-off-by: Rafał Wojdyła <omeg@xxxxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/xeniface/ioctl_gnttab.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xeniface/ioctl_gnttab.c b/src/xeniface/ioctl_gnttab.c
> index c6d82bc..12b1c0a 100644
> --- a/src/xeniface/ioctl_gnttab.c
> +++ b/src/xeniface/ioctl_gnttab.c
> @@ -717,7 +717,8 @@ IoctlGnttabMapForeignPages(
>       }
>   
>       if ((In->Flags & XENIFACE_GNTTAB_USE_NOTIFY_OFFSET) &&
> -        (In->NotifyOffset >= In->NumberPages * PAGE_SIZE)) {
> +        (In->NotifyOffset >= In->NumberPages * PAGE_SIZE ||
> +         (In->Flags & XENIFACE_GNTTAB_READONLY))) {
>           goto fail7;
>       }
>   
> @@ -771,7 +772,8 @@ IoctlGnttabMapForeignPages(
>                                                          MmCached,
>                                                          NULL,
>                                                          FALSE,
> -                                                       NormalPagePriority);
> +                                                       NormalPagePriority |
> +                                                       ((Context->Flags & 
> XENIFACE_GNTTAB_READONLY) ? MdlMappingNoWrite : 0));
>       } except (EXCEPTION_EXECUTE_HANDLER) {
>           status = GetExceptionCode();
>           goto fail12;



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.