Re: [Xen-API] [PATCH] imported patch removing-warnings

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>]

On 09/11/10 17:27, Rok Strnisa wrote:
> Patch subject is complete summary.
>
>
>   ocaml/idl/dm_api.ml                       |   4 ++--
>   ocaml/idl/ocaml_backend/event_helper.ml   |   2 +-
>   ocaml/idl/ocaml_backend/gen_db_actions.ml |   8 ++++----
>   ocaml/idl/ocaml_backend/gen_rbac.ml       |   4 ++--
>   ocaml/idl/ocaml_backend/gen_server.ml     |   6 +++---
>   ocaml/perftest/createVM.ml                |   4 ++--
>   ocaml/util/stats.ml                       |   4 ++--
>   ocaml/xapi/dbsync_slave.ml                |   8 ++++----
>   ocaml/xapi/events.ml                      |   4 ++--
>   ocaml/xapi/message_forwarding.ml          |  24 ++++++++++++------------
>   ocaml/xapi/sparse_dd.ml                   |  14 +++++++-------
>   ocaml/xapi/xapi.ml                        |   4 ++--
>   ocaml/xapi/xapi_host.ml                   |  10 +++++-----
>   ocaml/xapi/xapi_pool.ml                   |  13 ++++++-------
>   ocaml/xapi/xapi_vm.ml                     |   4 +---
>   ocaml/xenops/domain.ml                    |   2 +-
>   ocaml/xenops/squeeze.ml                   |   4 ++--
>   ocaml/xenops/squeeze_xen.ml               |   2 +-
>   ocaml/xenops/watch.ml                     |   2 +-
>   ocaml/xenops/xal.ml                       |   5 ++---
>   20 files changed, 62 insertions(+), 66 deletions(-)
Hi Rok,

That doesn't look like the right thing to do.

if things doesn't need a name, either the right side is not necessary in 
the first place (beware check for side effect) eg:
-  let t = io.gettimeofday () in
+  let _ (* t *) = io.gettimeofday () in

-                       let oldstate = devstate.backstate in
+                       let _ (* oldstate *) = devstate.backstate in

or you should have a:

let (_: type expected) = ....

to avoid future partial application.

--
Vincent

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api