Re: [Xen-API] [Xen-devel] [PATCH 02 of 15] libxl: Add LIBXL_SHUTDOWN_REASON_UNKNOWN

[Rob Hoes <Rob.Hoes@xxxxxxxxxx>]

> libxl: Add LIBXL_SHUTDOWN_REASON_UNKNOWN
> 
> libxl_dominfo.shutdown_reason is valid iff (shutdown||dying). This is a bit
> annoying when generating language bindings since it needs all sorts of
> special casing. Just introduce an explicit value instead.
> 
> Signed-off-by: Ian Campbell <ian.cambell@xxxxxxxxxx>

This change is very useful from an ocaml-bindings point of view.

Acked-by: Rob Hoes <rob.hoes@xxxxxxxxxx>
 
> diff -r 601dc257a740 -r 8195cb0ebac6 tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c     Tue Nov 20 17:22:16 2012 +0000
> +++ b/tools/libxl/libxl.c     Tue Nov 20 17:22:21 2012 +0000
> @@ -526,7 +526,7 @@ static void xcinfo2xlinfo(const xc_domai
>      if (xlinfo->shutdown || xlinfo->dying)
>          xlinfo->shutdown_reason = (xcinfo-
> >flags>>XEN_DOMINF_shutdownshift) & XEN_DOMINF_shutdownmask;
>      else
> -        xlinfo->shutdown_reason  = ~0;
> +        xlinfo->shutdown_reason = LIBXL_SHUTDOWN_REASON_UNKNOWN;
> 
>      xlinfo->current_memkb = PAGE_TO_MEMKB(xcinfo->tot_pages);
>      xlinfo->shared_memkb = PAGE_TO_MEMKB(xcinfo->shr_pages); diff -r
> 601dc257a740 -r 8195cb0ebac6 tools/libxl/libxl_types.idl
> --- a/tools/libxl/libxl_types.idl     Tue Nov 20 17:22:16 2012 +0000
> +++ b/tools/libxl/libxl_types.idl     Tue Nov 20 17:22:21 2012 +0000
> @@ -118,14 +118,15 @@ libxl_scheduler = Enumeration("scheduler
>      (7, "arinc653"),
>      ])
> 
> -# Consistent with SHUTDOWN_* in sched.h
> +# Consistent with SHUTDOWN_* in sched.h (apart from UNKNOWN)
>  libxl_shutdown_reason = Enumeration("shutdown_reason", [
> +    (-1, "unknown"),
>      (0, "poweroff"),
>      (1, "reboot"),
>      (2, "suspend"),
>      (3, "crash"),
>      (4, "watchdog"),
> -    ])
> +    ], init_val = "LIBXL_SHUTDOWN_REASON_UNKNOWN")
> 
>  libxl_vga_interface_type = Enumeration("vga_interface_type", [
>      (1, "CIRRUS"),
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-api mailing list
Xen-api@xxxxxxxxxxxxx
http://lists.xen.org/cgi-bin/mailman/listinfo/xen-api