[Xen-bugs] [Bug 996] New: Bug in vfbif.py when using vncdisplay=

[bugzilla-daemon@xxxxxxxxxxxxxxxxxxx]

http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=996

           Summary: Bug in vfbif.py when using vncdisplay=
           Product: Xen
           Version: 3.0.3
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Tools
        AssignedTo: xen-bugs@xxxxxxxxxxxxxxxxxxx
        ReportedBy: felipe_alfaro@xxxxxxxxxxxxx


There is a subtle bug in xen/xend/server/vfbif.py where the Python code tries
to sum up 5900 with the value of the "vncdisplay" configuration option, but the
value of "vncdisplay" is a string, and not an integer.

Here is the fix:

--- /usr/lib64/python2.4/site-packages/xen/xend/server/vfbif.py.OLD
2007-06-11 10:39:38.000000000 +0200
+++ /usr/lib64/python2.4/site-packages/xen/xend/server/vfbif.py 2007-06-11
10:39:19.000000000 +0200
@@ -96,7 +96,7 @@
            if sxp.child_value(config, "vncunused") is not None:
                args += ["--unused"]
            elif sxp.child_value(config, "vncdisplay") is not None:
-                args += ["--vncport", "%d" % (5900 + sxp.child_value(config,
"vncdisplay"))]
+                args += ["--vncport", "%d" % (5900 +
int(sxp.child_value(config, "vncdisplay")))]
            vnclisten = sxp.child_value(config, 'vnclisten',

xen.xend.XendRoot.instance().get_vnclisten_address())
            args += [ "--listen", vnclisten ]

You can reproduce by running xm create on the following Xen config file:

# Automatically generated xen config file
name = "centos_devel"
memory = "500"
disk = [ 'tap:aio:/vm/centos_devel,xvda,w', ]
vif = [ 'mac=00:16:3e:20:33:85, bridge=xenbr0', ]
vfb = ["type=vnc,vncdisplay=3,vncpasswd=foo"]
uuid = "36110fc7-e51a-2817-dd49-328af6489a2d"
bootloader="/usr/bin/pygrub"
vcpus = 1
vnc = 1
on_reboot = 'restart'
on_crash = 'restart'


-- 
Configure bugmail: 
http://bugzilla.xensource.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

_______________________________________________
Xen-bugs mailing list
Xen-bugs@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-bugs