[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] Remove some unnecessary flush_page_update_queue() calls.



ChangeSet 1.1379, 2005/03/26 02:25:05+00:00, kaf24@xxxxxxxxxxxxxxxxxxxx

        Remove some unnecessary flush_page_update_queue() calls.
        Signed-off-by: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>



 linux-2.4.29-xen-sparse/arch/xen/mm/fault.c             |    3 ---
 linux-2.6.11-xen-sparse/arch/xen/i386/mm/init.c         |    5 +----
 linux-2.6.11-xen-sparse/drivers/xen/netfront/netfront.c |    6 ------
 3 files changed, 1 insertion(+), 13 deletions(-)


diff -Nru a/linux-2.4.29-xen-sparse/arch/xen/mm/fault.c 
b/linux-2.4.29-xen-sparse/arch/xen/mm/fault.c
--- a/linux-2.4.29-xen-sparse/arch/xen/mm/fault.c       2005-03-25 22:02:53 
-05:00
+++ b/linux-2.4.29-xen-sparse/arch/xen/mm/fault.c       2005-03-25 22:02:53 
-05:00
@@ -84,9 +84,6 @@
         error_code &= 3;
         error_code |= (regs->xcs & 2) << 1;
 
-       /* ensure all updates have completed */
-       flush_page_update_queue();
-
        /*
         * We fault-in kernel-space virtual memory on-demand. The
         * 'reference' page table is init_mm.pgd.
diff -Nru a/linux-2.6.11-xen-sparse/arch/xen/i386/mm/init.c 
b/linux-2.6.11-xen-sparse/arch/xen/i386/mm/init.c
--- a/linux-2.6.11-xen-sparse/arch/xen/i386/mm/init.c   2005-03-25 22:02:53 
-05:00
+++ b/linux-2.6.11-xen-sparse/arch/xen/i386/mm/init.c   2005-03-25 22:02:53 
-05:00
@@ -192,7 +192,6 @@
                                }
                                pte_ofs = 0;
                        }
-                       flush_page_update_queue();
                }
                pmd_idx = 0;
        }       
@@ -359,9 +358,8 @@
        queue_pgd_pin(__pa(new_pgd));
        load_cr3(new_pgd);
        queue_pgd_unpin(__pa(old_pgd));
-       __flush_tlb_all(); /* implicit flush */
        make_page_writable(old_pgd);
-       flush_page_update_queue();
+       __flush_tlb_all(); /* implicit flush */
        free_bootmem(__pa(old_pgd), PAGE_SIZE);
 
        kernel_physical_mapping_init(new_pgd);
@@ -564,7 +562,6 @@
        zone_sizes_init();
 
        /* Switch to the real shared_info page, and clear the dummy page. */
-       flush_page_update_queue();
        set_fixmap_ma(FIX_SHARED_INFO, xen_start_info.shared_info);
        HYPERVISOR_shared_info = (shared_info_t *)fix_to_virt(FIX_SHARED_INFO);
        memset(empty_zero_page, 0, sizeof(empty_zero_page));
diff -Nru a/linux-2.6.11-xen-sparse/drivers/xen/netfront/netfront.c 
b/linux-2.6.11-xen-sparse/drivers/xen/netfront/netfront.c
--- a/linux-2.6.11-xen-sparse/drivers/xen/netfront/netfront.c   2005-03-25 
22:02:53 -05:00
+++ b/linux-2.6.11-xen-sparse/drivers/xen/netfront/netfront.c   2005-03-25 
22:02:53 -05:00
@@ -387,12 +387,6 @@
         rx_mcl[i].args[2] = 0;
     }
 
-    /*
-     * We may have allocated buffers which have entries outstanding in the page
-     * update queue -- make sure we flush those first!
-     */
-    flush_page_update_queue();
-
     /* After all PTEs have been zapped we blow away stale TLB entries. */
     rx_mcl[i-1].args[2] = UVMF_FLUSH_TLB;
 


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.